[Bug 1355830] Review Request: hidrd - HID report descriptor I/ O library and conversion tool
https://bugzilla.redhat.com/show_bug.cgi?id=1355830 --- Comment #15 from Fedora Update System --- hidrd-0.2.0-3.20160712git1abf7033.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1355830] Review Request: hidrd - HID report descriptor I/ O library and conversion tool
https://bugzilla.redhat.com/show_bug.cgi?id=1355830 --- Comment #14 from Fedora Update System --- hidrd-0.2.0-3.20160712git1abf7033.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1355830] Review Request: hidrd - HID report descriptor I/ O library and conversion tool
https://bugzilla.redhat.com/show_bug.cgi?id=1355830 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed|2016-07-20 12:23:31 |2016-07-28 19:53:41 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1355830] Review Request: hidrd - HID report descriptor I/ O library and conversion tool
https://bugzilla.redhat.com/show_bug.cgi?id=1355830 --- Comment #13 from Fedora Update System --- hidrd-0.2.0-3.20160712git1abf7033.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-72c0a31b17 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1355830] Review Request: hidrd - HID report descriptor I/ O library and conversion tool
https://bugzilla.redhat.com/show_bug.cgi?id=1355830 Fedora Update System changed: What|Removed |Added Status|CLOSED |ON_QA Resolution|NEXTRELEASE |--- Keywords||Reopened --- Comment #12 from Fedora Update System --- hidrd-0.2.0-3.20160712git1abf7033.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-b86cca1f5b -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1355830] Review Request: hidrd - HID report descriptor I/ O library and conversion tool
https://bugzilla.redhat.com/show_bug.cgi?id=1355830 Jaroslav Škarvada changed: What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |NEXTRELEASE Last Closed||2016-07-20 12:23:31 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1355830] Review Request: hidrd - HID report descriptor I/ O library and conversion tool
https://bugzilla.redhat.com/show_bug.cgi?id=1355830 --- Comment #11 from Fedora Update System --- hidrd-0.2.0-3.20160712git1abf7033.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-b86cca1f5b -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1355830] Review Request: hidrd - HID report descriptor I/ O library and conversion tool
https://bugzilla.redhat.com/show_bug.cgi?id=1355830 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1355830] Review Request: hidrd - HID report descriptor I/ O library and conversion tool
https://bugzilla.redhat.com/show_bug.cgi?id=1355830 --- Comment #10 from Fedora Update System --- hidrd-0.2.0-3.20160712git1abf7033.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-72c0a31b17 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1355830] Review Request: hidrd - HID report descriptor I/ O library and conversion tool
https://bugzilla.redhat.com/show_bug.cgi?id=1355830 --- Comment #9 from Jon Ciesla --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/hidrd -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1355830] Review Request: hidrd - HID report descriptor I/ O library and conversion tool
https://bugzilla.redhat.com/show_bug.cgi?id=1355830 Ondřej Lysoněk changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #8 from Ondřej Lysoněk --- Package Review == Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: === - No issues found = MUST items = C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: ldconfig called in %post and %postun if required. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "GPL (v2 or later)", "Unknown or generated". 3 files have unknown license. Detailed output of licensecheck in /home/makerpm/2 /review-hidrd/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/share/xml(xml-common) [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local = SHOULD items = Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in hidrd- debuginfo [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Scriptlets must be sane, if used. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if ava
[Bug 1355830] Review Request: hidrd - HID report descriptor I/ O library and conversion tool
https://bugzilla.redhat.com/show_bug.cgi?id=1355830 --- Comment #7 from Jaroslav Škarvada --- (In reply to Jaroslav Škarvada from comment #6) Spec URL: https://jskarvad.fedorapeople.org/hidrd/hidrd.spec SRPM URL: https://jskarvad.fedorapeople.org/hidrd/hidrd-0.2.0-3.20160712git1abf7033.fc23.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1355830] Review Request: hidrd - HID report descriptor I/ O library and conversion tool
https://bugzilla.redhat.com/show_bug.cgi?id=1355830 --- Comment #6 from Jaroslav Škarvada --- (In reply to Jaroslav Škarvada from comment #5) Spec URL: https://jskarvad.fedorapeople.org/hidrd/hidrd.spec SRPM URL: https://jskarvad.fedorapeople.org/hidrd-0.2.0-3.20160712git1abf7033.fc23.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1355830] Review Request: hidrd - HID report descriptor I/ O library and conversion tool
https://bugzilla.redhat.com/show_bug.cgi?id=1355830 Jaroslav Škarvada changed: What|Removed |Added Flags|needinfo?(jskarvad@redhat.c | |om) | --- Comment #5 from Jaroslav Škarvada --- Sorry, I haven't noticed there is libtool and my rpmlint didn't spot the problem, hopefully it's fixed now, new version: Spec URL: https://jskarvad.fedorapeople.org/hidrd/hidrd.spec SRPM URL: hidrd-0.2.0-3.20160712git1abf7033.fc23.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1355830] Review Request: hidrd - HID report descriptor I/ O library and conversion tool
https://bugzilla.redhat.com/show_bug.cgi?id=1355830 Ondřej Lysoněk changed: What|Removed |Added Flags||needinfo?(jskarvad@redhat.c ||om) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1355830] Review Request: hidrd - HID report descriptor I/ O library and conversion tool
https://bugzilla.redhat.com/show_bug.cgi?id=1355830 --- Comment #4 from Ondřej Lysoněk --- Created attachment 1182029 --> https://bugzilla.redhat.com/attachment.cgi?id=1182029&action=edit patch The fix for 'unused-direct-shlib-dependency' you provided doesn't seem to work. The attached patch created according to the instructions for libtool at [1] works. [1] https://fedoraproject.org/wiki/Common_Rpmlint_issues#unused-direct-shlib-dependency -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1355830] Review Request: hidrd - HID report descriptor I/ O library and conversion tool
https://bugzilla.redhat.com/show_bug.cgi?id=1355830 Jaroslav Škarvada changed: What|Removed |Added Flags|needinfo?(jskarvad@redhat.c | |om) | --- Comment #3 from Jaroslav Škarvada --- Thanks for the review, hopefully all fixed, new files: Spec URL: https://jskarvad.fedorapeople.org/hidrd/hidrd.spec SRPM URL: hidrd-0.2.0-2.20160712git1abf7033.fc23.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1355830] Review Request: hidrd - HID report descriptor I/ O library and conversion tool
https://bugzilla.redhat.com/show_bug.cgi?id=1355830 Ondřej Lysoněk changed: What|Removed |Added CC||jskar...@redhat.com Flags||needinfo?(jskarvad@redhat.c ||om) --- Comment #2 from Ondřej Lysoněk --- Issues: === - xml-common dependency unnecessary - https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#The_directory_is_owned_by_a_package_which_is_not_required_for_your_package_to_function Suggestions: - no %check section (the upstream package has a test suite) - hidrd-convert should have a man page - rpmlint complains about 'unused-direct-shlib-dependency', fix acording to instructions for libtool at https://fedoraproject.org/wiki/Common_Rpmlint_issues#unused-direct-shlib-dependency -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1355830] Review Request: hidrd - HID report descriptor I/ O library and conversion tool
https://bugzilla.redhat.com/show_bug.cgi?id=1355830 Ondřej Lysoněk changed: What|Removed |Added Status|NEW |ASSIGNED CC||olyso...@redhat.com Assignee|nob...@fedoraproject.org|olyso...@redhat.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1355830] Review Request: hidrd - HID report descriptor I/ O library and conversion tool
https://bugzilla.redhat.com/show_bug.cgi?id=1355830 --- Comment #1 from Jaroslav Škarvada --- Spec URL: https://jskarvad.fedorapeople.org/hidrd/hidrd.spec SRPM URL: https://jskarvad.fedorapeople.org/hidrd/hidrd-0.2.0-1.20160712git1abf7033.fc23.src.rpm Description: Hidrd is a library and a tool for reading, writing and converting HID report descriptors in/between various formats. Fedora Account System Username: jskarvad -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org