[Bug 1366997] Review Request: tcl-critcl - Compiled Runtime In Tcl
https://bugzilla.redhat.com/show_bug.cgi?id=1366997 Dmitrij S. Kryzhevich changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |NOTABUG Last Closed||2019-04-25 09:10:19 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1366997] Review Request: tcl-critcl - Compiled Runtime In Tcl
https://bugzilla.redhat.com/show_bug.cgi?id=1366997 Gerd Pokorra changed: What|Removed |Added Flags|needinfo?(g...@zimt.uni-siege | |n.de) | --- Comment #8 from Gerd Pokorra --- Yes, we could close it. I do not need the package any more. Ubuntu has a nice critcl package but I not not able to transport this to Fedora. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1366997] Review Request: tcl-critcl - Compiled Runtime In Tcl
https://bugzilla.redhat.com/show_bug.cgi?id=1366997 Dmitrij S. Kryzhevich changed: What|Removed |Added Flags||needinfo?(g...@zimt.uni-siege ||n.de) --- Comment #7 from Dmitrij S. Kryzhevich --- Should we close it? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1366997] Review Request: tcl-critcl - Compiled Runtime In Tcl
https://bugzilla.redhat.com/show_bug.cgi?id=1366997 --- Comment #6 from Yin.JianHong --- great! any update? hope get critcl in Fedora-26 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1366997] Review Request: tcl-critcl - Compiled Runtime In Tcl
https://bugzilla.redhat.com/show_bug.cgi?id=1366997 --- Comment #5 from Dmitrij S. Kryzhevich --- (In reply to Gerd Pokorra from comment #2) > Should the files > /usr/share/tcl8.6/critcl3.1.15/critcl_c/tcl8.?/X11* > be excluded? > > I will sent an email to upstream to fix the misprint in license.terms. It must be removed in acse it's not required. It must get permission from releng if it does. And what can you say about zlib sources? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1366997] Review Request: tcl-critcl - Compiled Runtime In Tcl
https://bugzilla.redhat.com/show_bug.cgi?id=1366997
--- Comment #4 from Gerd Pokorra ---
I saw that the new release 3.1.16 is online. I updated to 3.1.16.
The spec files of version 3.1.15 are moved to:
ftp://ftp.uni-siegen.de/pub/review/spec/v3.1.15
The link: ftp://ftp.uni-siegen.de/pub/review/spec/tcl-critcl.spec
is updated and now points to first version of 3.1.16:
ftp://ftp.uni-siegen.de/pub/review/spec/tcl-critcl.spec.1
new SRPM URL:
ftp://ftp.uni-siegen.de/pub/review/srpm/tcl-critcl-3.1.16-1.fc25.src.rpm
This two lines are added in the spec file:
%{__rm} -r lib/critcl/critcl_c/tcl8.[45]
%{__rm} -r lib/critcl/critcl_c/tcl8.6/X11
If I build the rpm at my computer the architecture dependent file
/usr/share/tcl8.6/critcl_md5c0.12/linux-x86_64/md5c.so
will generated.
Do anybody know what BuildRequires I must add that this will also be generated
at a scratch build?
f25 scratch build URL:
https://koji.fedoraproject.org/koji/taskinfo?taskID=18193058
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1366997] Review Request: tcl-critcl - Compiled Runtime In Tcl
https://bugzilla.redhat.com/show_bug.cgi?id=1366997 --- Comment #3 from Gerd Pokorra --- P.S. I do not know if it is useful. Scratch build URLs are: rawhide,F27: https://koji.fedoraproject.org/koji/taskinfo?taskID=18153983 F26: https://koji.fedoraproject.org/koji/taskinfo?taskID=18154185 F25: https://koji.fedoraproject.org/koji/taskinfo?taskID=18154377 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1366997] Review Request: tcl-critcl - Compiled Runtime In Tcl
https://bugzilla.redhat.com/show_bug.cgi?id=1366997 --- Comment #2 from Gerd Pokorra --- The link: ftp://ftp.uni-siegen.de/pub/review/spec/tcl-critcl.spec is updated and now points to: ftp://ftp.uni-siegen.de/pub/review/spec/tcl-critcl.spec.2 new SRPM URL: ftp://ftp.uni-siegen.de/pub/review/srpm/tcl-critcl-3.1.15-2.fc25.src.rpm - manually gzipping man files removed - defattr is removed - Group tag removed, Provides: critcl with version-release added - build the package as a noarch package Should the files /usr/share/tcl8.6/critcl3.1.15/critcl_c/tcl8.?/X11* be excluded? I will sent an email to upstream to fix the misprint in license.terms. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1366997] Review Request: tcl-critcl - Compiled Runtime In Tcl
https://bugzilla.redhat.com/show_bug.cgi?id=1366997
Dmitrij S. Kryzhevich changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||kryz...@ispms.ru
Assignee|nob...@fedoraproject.org|kryz...@ispms.ru
--- Comment #1 from Dmitrij S. Kryzhevich ---
The are some minor issues I could see.
1. Group tag is not required.
2. You should add "Provides: critcl"
3. man files are auto-gzipped during run, do not do it manually.
4. defattr is obsoleted.
5. license.terms file must go under %license macro.
6. I believe there is a misprint in license.terms:
"other parties" should be "and other parties".
And I'm not sure whether zlib sources could be supplied in examples. I suppose
"yes" (and mark it somewhere near License tag in spec) but if you know other
example that's would be great.
Not so minor.
1. As I can see it is a fully noarch package. So all extensions must go to
%{_datadir}/tcl%{tcl_version} but not %{_libdir}/tcl%{tcl_version} and
"BuildArch: noarch" must be added.
2. critcl_c subdir contain parts of tcl and tk of different versions and part
of X11. Is it really necessary? You should consider to use system ones or get
the permission.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
