[Bug 1367971] Review Request: plasma-applet-weather-widget

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367971



--- Comment #16 from Fedora Update System  ---
plasma-applet-weather-widget-1.6.7-4.fc25 has been pushed to the Fedora 25
stable repository. If problems still persist, please make note of it in this
bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1367971] Review Request: plasma-applet-weather-widget

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367971



--- Comment #15 from Fedora Update System  ---
plasma-applet-weather-widget-1.6.7-4.fc24 has been pushed to the Fedora 24
stable repository. If problems still persist, please make note of it in this
bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1367971] Review Request: plasma-applet-weather-widget

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367971

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-09-02 16:53:25



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1367971] Review Request: plasma-applet-weather-widget

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367971

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #14 from Fedora Update System  ---
plasma-applet-weather-widget-1.6.7-4.fc25 has been pushed to the Fedora 25
testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-9adc606b69

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1367971] Review Request: plasma-applet-weather-widget

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367971



--- Comment #13 from Fedora Update System  ---
plasma-applet-weather-widget-1.6.7-4.fc25 has been submitted as an update to
Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-9adc606b69

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1367971] Review Request: plasma-applet-weather-widget

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367971

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1367971] Review Request: plasma-applet-weather-widget

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367971

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #12 from Fedora Update System  ---
plasma-applet-weather-widget-1.6.7-4.fc24 has been pushed to the Fedora 24
testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-e8809eec46

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1367971] Review Request: plasma-applet-weather-widget

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367971



--- Comment #11 from Gerald Cox  ---
plasma-applet-weather-widget-1.6.7.3 was created to addition additional build
requirements to assist in F25 build which was failing.  Discovered that F25
build was failing because of missing packages due to F25 alpha freeze.  Created
~1.6.7.4 update to backout changes introduced by ~1.6.7.3

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1367971] Review Request: plasma-applet-weather-widget

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367971



--- Comment #10 from Fedora Update System  ---
plasma-applet-weather-widget-1.6.7-4.fc24 has been submitted as an update to
Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-e8809eec46

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1367971] Review Request: plasma-applet-weather-widget

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367971



--- Comment #9 from Fedora Update System  ---
plasma-applet-weather-widget-1.6.7-2.fc24 has been submitted as an update to
Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-ca227e0f2d

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1367971] Review Request: plasma-applet-weather-widget

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367971

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1367971] Review Request: plasma-applet-weather-widget

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367971



--- Comment #8 from Gerald Cox  ---
Rex Dieter responded to the email on the KDE Mailing list:

Thanks, I've added ownership of these to kf5-kdeclarative and kf5-plasma
packages (rawhide), next kf5 update for stable releases will include the
fixes

-- Rex

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1367971] Review Request: plasma-applet-weather-widget

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367971



--- Comment #7 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/plasma-applet-weather-widget

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1367971] Review Request: plasma-applet-weather-widget

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367971



--- Comment #6 from Gerald Cox  ---
Great... thanks much Jerry.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1367971] Review Request: plasma-applet-weather-widget

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367971

Jerry James  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #5 from Jerry James  ---
(In reply to Gerald Cox from comment #4)
> Didn't hear anything back yet on the directory ownership, but as mentioned
> in the ticket:  https://fedorahosted.org/FedoraReview/ticket/269 - it's just
> notifying you that it could not determine the owner - and mentioning that my
> package must own any files it creates... and I do.  I didn't create those
> directories.  I could certainly take ownership and get rid of those messages
> by adding:
> 
> %dir %{_kf5_qmldir}/org/
> %dir %{_kf5_qmldir}/org/kde/
> %dir %{_kf5_qmldir}/org/kde/private/
> 
> but I don't think that would be appropriate since I did not create those
> directories.  It will need to be handled by whomever created them.

Agreed.  I see no further blocking issues, so this package is APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1367971] Review Request: plasma-applet-weather-widget

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367971



--- Comment #4 from Gerald Cox  ---
OK, I've revised the spec and src.rpm:
Location of source files:
Spec URL:
https://gbcox.fedorapeople.org/review/plasma-applet-weather-widget.spec
SRPM URL:
https://gbcox.fedorapeople.org/review/plasma-applet-weather-widget-1.6.7-2.fc24.src.rpm

Didn't hear anything back yet on the directory ownership, but as mentioned in
the ticket:  https://fedorahosted.org/FedoraReview/ticket/269 - it's just
notifying you that it could not determine the owner - and mentioning that my
package must own any files it creates... and I do.  I didn't create those
directories.  I could certainly take ownership and get rid of those messages by
adding:

%dir %{_kf5_qmldir}/org/
%dir %{_kf5_qmldir}/org/kde/
%dir %{_kf5_qmldir}/org/kde/private/

but I don't think that would be appropriate since I did not create those
directories.  It will need to be handled by whomever created them.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1367971] Review Request: plasma-applet-weather-widget

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367971



--- Comment #3 from Gerald Cox  ---
Wow, that was fast... Thanks Jerry!

This is just a quick note to comment on some things before I lost track.

1.  Since the Fonts issue is a "should" I'll deal with that at another time.

2.  The "description too long" error is a known problem reported here:
https://bugzilla.redhat.com/show_bug.cgi?id=768393
I've re-opened, but apparently no one in the rpmlint team deems it worthy
enough to even comment.

3.  I've submitted a question on the kde mailing list regarding the directories
that were created by other packages that are not owned.  Regarding
/usr/share/plasma/plasmoids; that directory is actually owned by two packages:

rpm -qf /usr/share/plasma/plasmoids
plasma-workspace-5.7.3-2.fc24.x86_64
plasma-desktop-5.7.3-1.fc24.x86_64

and appears to be this issue:
https://fedorahosted.org/FedoraReview/ticket/269

It has been tagged as *WONTFIX* "...this is not a false positive, fedora-review
just cannot determine the directory owner. That is what the message says, it's
not saying that there is no owner. Basically, it means that a manual check is
necessary."

Regarding the other directories, I can certainly claim ownership to eliminate
the error but I'm unsure if that is the correct thing to do.  I'll wait to hear
back from the mailing list for guidance on that.  When I receive, I'll update
this ticket.

I'm also going to remove the icon cache processing... that was an oversight on
my part, it isn't needed.  There are no desktop icons.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1367971] Review Request: plasma-applet-weather-widget

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367971



--- Comment #2 from Jerry James  ---
Issues
==
1. See the list of unowned directories generated by rpmlint below:
   - /usr/lib64/qt5/qml/org
   - /usr/lib64/qt5/qml/org/kde
   - /usr/lib64/qt5/qml/ord/kde/private
   - /usr/lib64/qt5/qml/org/kde/private/weatherWidget
   - /usr/share/plasma/plasmoids

2. The package contains a font file:
  
/usr/share/plasma/plasmoids/org.kde.weatherWidget/contents/fonts/weathericons-regular-webfont-2.0.10.ttf

   See
https://fedoraproject.org/wiki/Packaging:Guidelines#Avoid_bundling_of_fonts_in_other_packages
   for how this should be handled.

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated

= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[!]: Package requires other packages for directories it uses.
 Note: No known owner of
 /usr/lib64/qt5/qml/org/kde/private/weatherWidget,
 /usr/lib64/qt5/qml/org/kde, /usr/lib64/qt5/qml/org
[!]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/share/plasma/plasmoids,
 /usr/lib64/qt5/qml/org, /usr/lib64/qt5/qml/org/kde/private,
 /usr/lib64/qt5/qml/org/kde/private/weatherWidget,
 /usr/lib64/qt5/qml/org/kde
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: The spec file handles locales properly.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
 desktop-file-validate if there is such a file.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable. 
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[!]: Avoid bundling fonts in non-fonts packages.
 Note: Package contains font files

[Bug 1367971] Review Request: plasma-applet-weather-widget

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367971

Jerry James  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||loganje...@gmail.com
   Assignee|nob...@fedoraproject.org|loganje...@gmail.com
  Flags||fedora-review?



--- Comment #1 from Jerry James  ---
I will take this review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org