[Bug 1369374] Review Request: python2-faulthandler - Display the Python traceback on a crash
https://bugzilla.redhat.com/show_bug.cgi?id=1369374 --- Comment #15 from Fedora Update System --- python2-faulthandler-2.4-1.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1369374] Review Request: python2-faulthandler - Display the Python traceback on a crash
https://bugzilla.redhat.com/show_bug.cgi?id=1369374 --- Comment #14 from Fedora Update System --- python2-faulthandler-2.4-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1369374] Review Request: python2-faulthandler - Display the Python traceback on a crash
https://bugzilla.redhat.com/show_bug.cgi?id=1369374 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2016-09-09 12:53:49 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1369374] Review Request: python2-faulthandler - Display the Python traceback on a crash
https://bugzilla.redhat.com/show_bug.cgi?id=1369374 --- Comment #13 from Fedora Update System --- python2-faulthandler-2.4-1.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1369374] Review Request: python2-faulthandler - Display the Python traceback on a crash
https://bugzilla.redhat.com/show_bug.cgi?id=1369374 --- Comment #12 from Fedora Update System --- python2-faulthandler-2.4-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-aba642f93a -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1369374] Review Request: python2-faulthandler - Display the Python traceback on a crash
https://bugzilla.redhat.com/show_bug.cgi?id=1369374 --- Comment #11 from Fedora Update System --- python2-faulthandler-2.4-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-6cf8254448 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1369374] Review Request: python2-faulthandler - Display the Python traceback on a crash
https://bugzilla.redhat.com/show_bug.cgi?id=1369374 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #10 from Fedora Update System --- python2-faulthandler-2.4-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-0320cb771f -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1369374] Review Request: python2-faulthandler - Display the Python traceback on a crash
https://bugzilla.redhat.com/show_bug.cgi?id=1369374 --- Comment #9 from Fedora Update System --- python2-faulthandler-2.4-1.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-0320cb771f -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1369374] Review Request: python2-faulthandler - Display the Python traceback on a crash
https://bugzilla.redhat.com/show_bug.cgi?id=1369374 Fedora Update System changed: What|Removed |Added Status|NEW |MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1369374] Review Request: python2-faulthandler - Display the Python traceback on a crash
https://bugzilla.redhat.com/show_bug.cgi?id=1369374 --- Comment #8 from Fedora Update System --- python2-faulthandler-2.4-1.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-6cf8254448 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1369374] Review Request: python2-faulthandler - Display the Python traceback on a crash
https://bugzilla.redhat.com/show_bug.cgi?id=1369374 --- Comment #7 from Fedora Update System --- python2-faulthandler-2.4-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-aba642f93a -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1369374] Review Request: python2-faulthandler - Display the Python traceback on a crash
https://bugzilla.redhat.com/show_bug.cgi?id=1369374 --- Comment #6 from Jon Ciesla --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/python2-faulthandler -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1369374] Review Request: python2-faulthandler - Display the Python traceback on a crash
https://bugzilla.redhat.com/show_bug.cgi?id=1369374
Lumír Balhar changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #5 from Lumír Balhar ---
Everything looks good to me.
Package APPROVED
Review output:
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Note: Unversioned so-files in private %_libdir subdirectory (see
attachment). Verify they are not in ld path.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "BSD (2 clause)", "Unknown or generated". 9 files have unknown
license. Detailed output of licensecheck in
/home/lbalhar/Review/1369374-python2-faulthandler/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build
process.
[x]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep
= SHOULD items =
Generic:
[x]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments)
[Bug 1369374] Review Request: python2-faulthandler - Display the Python traceback on a crash
https://bugzilla.redhat.com/show_bug.cgi?id=1369374 --- Comment #4 from Dominika Krejčí --- (In reply to Igor Gnatenko from comment #3) > * Missing BuildRequires: python2-setuptools > * python-nose -> python2-nose Thanks, fixed. Spec URL: https://dkrejci.fedorapeople.org/python2-faulthandler/python2-faulthandler.spec SRPM URL: https://dkrejci.fedorapeople.org/python2-faulthandler/python2-faulthandler-2.4-1.fc24.src.rpm Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=15425839 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1369374] Review Request: python2-faulthandler - Display the Python traceback on a crash
https://bugzilla.redhat.com/show_bug.cgi?id=1369374 --- Comment #3 from Igor Gnatenko --- * Missing BuildRequires: python2-setuptools * python-nose -> python2-nose -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1369374] Review Request: python2-faulthandler - Display the Python traceback on a crash
https://bugzilla.redhat.com/show_bug.cgi?id=1369374 --- Comment #2 from Dominika Krejčí --- It should be up-to-date, now. :) Spec URL: https://dkrejci.fedorapeople.org/python2-faulthandler/python2-faulthandler.spec SRPM URL: https://dkrejci.fedorapeople.org/python2-faulthandler/python2-faulthandler-2.4-1.fc24.src.rpm Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=15425733 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1369374] Review Request: python2-faulthandler - Display the Python traceback on a crash
https://bugzilla.redhat.com/show_bug.cgi?id=1369374 --- Comment #1 from Lumír Balhar --- Hello Dominiko. I've worked on tests for this package and I found the solution: - You need to add python-nose to BR - You need to extend PYTHONPATH environment variable before you run nosetests command, because tests need module installed in %buildroot/%python2_sitearch. But this is not all. I've found one problematic test which gets stuck on x86_64 and ARMv7. On i686 all 30 tests pass correctly, but on other architectures this test needs to be skipped. I don't know why so I opened upstream issue [0] and skip this test in specfile [1] for specified architectures. [0] https://github.com/haypo/faulthandler/issues/25 [1] https://lbalhar.fedorapeople.org/python2-faulthandler.spec Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=15351883 Please, look at this specfile, check it and actualize your one with SRPM. Then we can continue with review :) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1369374] Review Request: python2-faulthandler - Display the Python traceback on a crash
https://bugzilla.redhat.com/show_bug.cgi?id=1369374 Lumír Balhar changed: What|Removed |Added CC||lbal...@redhat.com Assignee|nob...@fedoraproject.org|lbal...@redhat.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
