[Bug 1375380] Review Request: icestorm - Lattice iCE40 FPGA bitstream creation/analysis/ programming tools

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1375380



--- Comment #11 from Fedora Update System  ---
icestorm-0-0.3.20170914git5c4d4db.fc27 has been pushed to the Fedora 27 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1375380] Review Request: icestorm - Lattice iCE40 FPGA bitstream creation/analysis/ programming tools

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1375380

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-09-24 20:52:00



--- Comment #10 from Fedora Update System  ---
icestorm-0-0.3.20170914git5c4d4db.fc26 has been pushed to the Fedora 26 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1375380] Review Request: icestorm - Lattice iCE40 FPGA bitstream creation/analysis/ programming tools

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1375380



--- Comment #9 from Fedora Update System  ---
icestorm-0-0.3.20170914git5c4d4db.fc27 has been pushed to the Fedora 27 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-918d1763f5

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1375380] Review Request: icestorm - Lattice iCE40 FPGA bitstream creation/analysis/ programming tools

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1375380

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #8 from Fedora Update System  ---
icestorm-0-0.3.20170914git5c4d4db.fc26 has been pushed to the Fedora 26 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-a8a9bc3bd3

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1375380] Review Request: icestorm - Lattice iCE40 FPGA bitstream creation/analysis/ programming tools

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1375380



--- Comment #7 from Fedora Update System  ---
icestorm-0-0.3.20170914git5c4d4db.fc26 has been submitted as an update to
Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-a8a9bc3bd3

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1375380] Review Request: icestorm - Lattice iCE40 FPGA bitstream creation/analysis/ programming tools

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1375380



--- Comment #6 from Fedora Update System  ---
icestorm-0-0.3.20170914git5c4d4db.fc27 has been submitted as an update to
Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2017-918d1763f5

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1375380] Review Request: icestorm - Lattice iCE40 FPGA bitstream creation/analysis/ programming tools

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1375380

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1375380] Review Request: icestorm - Lattice iCE40 FPGA bitstream creation/analysis/ programming tools

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1375380



--- Comment #5 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/icestorm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1375380] Review Request: icestorm - Lattice iCE40 FPGA bitstream creation/analysis/ programming tools

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1375380

Lubomir Rintel  changed:

   What|Removed |Added

 Blocks||1375383




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1375383
[Bug 1375383] Review Request: arachne-pnr - Place and route for FPGA
compilation
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1375380] Review Request: icestorm - Lattice iCE40 FPGA bitstream creation/analysis/ programming tools

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1375380

Lubomir Rintel  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1375380] Review Request: icestorm - Lattice iCE40 FPGA bitstream creation/analysis/ programming tools

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1375380

Lubomir Rintel  changed:

   What|Removed |Added

 CC||lkund...@v3.sk
   Assignee|nob...@fedoraproject.org|lkund...@v3.sk
  Flags||fedora-review+



--- Comment #4 from Lubomir Rintel  ---
* Package named correctly
* License tag okay
* License good for Fedora
* SPEC file clean and legible, uses up to date macros
* Filelist sane
* Requires/provides look good
* Uses proper compiler flags
* Builds fine in mock

0.) Not packaging the latest version. Probably all right since upstream doesn't
do formal releases, but please bump it to a later snapshot when importing,
given how long has this review been stalled

rpmlint is sort of happy, but there are points that should be addressed:

1.) version-control-internal-file /usr/share/doc/icestorm/examples/*/.gitignore

Please %exclude or remove this

2.) wrong-file-end-of-line-encoding
/usr/share/doc/icestorm/examples/icestick/icestick.pcf

Please dos2unix this. We read the examples on Linux.

The above is trivial enough to be addressed on import.

This package is APPROVED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1375380] Review Request: icestorm - Lattice iCE40 FPGA bitstream creation/analysis/ programming tools

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1375380



--- Comment #3 from Eric Smith  ---
Spec URL: https://fedorapeople.org/~brouhaha/icestorm/icestorm.spec
SRPM URL:
https://fedorapeople.org/~brouhaha/icestorm/icestorm-0-0.2.20161101git01b9822.fc24.src.rpm

Updated to latest upstream, and updated per comments #1 and #2.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1375380] Review Request: icestorm - Lattice iCE40 FPGA bitstream creation/analysis/ programming tools

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1375380



--- Comment #2 from Till Maas  ---
Actually icebox.py is also a module and not a proper script.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1375380] Review Request: icestorm - Lattice iCE40 FPGA bitstream creation/analysis/ programming tools

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1375380

Till Maas  changed:

   What|Removed |Added

 CC||opensou...@till.name



--- Comment #1 from Till Maas  ---
It is awesome, that you want to package this. Unfortunately I have found some
issues at first glance:

- The README file contains mostly the license, therefore IMHO it should be
included with %license.

- Have you considered shipping the examples and doc dirs as %doc?

- iceboxdb.py seems to be a module and not a program, therefore it does not
belong to /usr/bin but rather %python_sitelib I think. It might be a good idea
to discuss the proper path with upstream. For future-proofness it might be a
good idea to put it in a directory in %python_sitelib such as icebox and put it
in a db.py file there. Having it in /usr/bin also creates the problem that it
might create .pyc/.pyo files there, since iceboxdb.py is imported

- Also the files in /usr/bin should not have a .py suffix

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org