[Bug 1376412] Review Request: golang-github-mattn-go-colorable - Colorable writer for windows.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376412

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-10-04 18:21:35



--- Comment #24 from Fedora Update System  ---
golang-github-mattn-go-colorable-0-0.5.20170816gitad5389d.fc26 has been pushed
to the Fedora 26 stable repository. If problems still persist, please make note
of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1376412] Review Request: golang-github-mattn-go-colorable - Colorable writer for windows.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376412

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #23 from Fedora Update System  ---
golang-github-mattn-go-colorable-0-0.5.20170816gitad5389d.fc26 has been pushed
to the Fedora 26 testing repository. If problems still persist, please make
note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-1767a27810

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1376412] Review Request: golang-github-mattn-go-colorable - Colorable writer for windows.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376412

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1376412] Review Request: golang-github-mattn-go-colorable - Colorable writer for windows.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376412



--- Comment #22 from Fedora Update System  ---
golang-github-mattn-go-colorable-0-0.5.20170816gitad5389d.fc26 has been
submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-1767a27810

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1376412] Review Request: golang-github-mattn-go-colorable - Colorable writer for windows.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376412

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #21 from Fedora Update System  ---
golang-github-mattn-go-colorable-0-0.4.20170816gitad5389d.fc26 has been pushed
to the Fedora 26 testing repository. If problems still persist, please make
note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-bf5e7f8700

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1376412] Review Request: golang-github-mattn-go-colorable - Colorable writer for windows.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376412



--- Comment #20 from Fedora Update System  ---
golang-github-mattn-go-colorable-0-0.4.20170816gitad5389d.fc26 has been
submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-bf5e7f8700

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1376412] Review Request: golang-github-mattn-go-colorable - Colorable writer for windows.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376412

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1376412] Review Request: golang-github-mattn-go-colorable - Colorable writer for windows.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376412



--- Comment #19 from Ed Marshall  ---
Apologies for missing this when I originally filed my review request; there's
actually a problem with the packaging for this version relating to the import
path, but I'll open a separate BZ for that now that the package is approved and
pushed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1376412] Review Request: golang-github-mattn-go-colorable - Colorable writer for windows.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376412
Bug 1376412 depends on bug 1430143, which changed state.

Bug 1430143 Summary: Review Request: golang-github-mattn-go-isatty - isatty for 
Go (golang)
https://bugzilla.redhat.com/show_bug.cgi?id=1430143

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1376412] Review Request: golang-github-mattn-go-colorable - Colorable writer for windows.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376412
Bug 1376412 depends on bug 1430143, which changed state.

Bug 1430143 Summary: Review Request: golang-github-mattn-go-isatty - isatty for 
Go (golang)
https://bugzilla.redhat.com/show_bug.cgi?id=1430143

   What|Removed |Added

 Status|CLOSED  |ON_QA
 Resolution|ERRATA  |---



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1376412] Review Request: golang-github-mattn-go-colorable - Colorable writer for windows.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376412

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #18 from Fedora Update System  ---
golang-github-mattn-go-colorable-0-0.3.20170816gitad5389d.fc26 has been pushed
to the Fedora 26 testing repository. If problems still persist, please make
note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-ba91ff6381

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1376412] Review Request: golang-github-mattn-go-colorable - Colorable writer for windows.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376412
Bug 1376412 depends on bug 1430143, which changed state.

Bug 1430143 Summary: Review Request: golang-github-mattn-go-isatty - isatty for 
Go (golang)
https://bugzilla.redhat.com/show_bug.cgi?id=1430143

   What|Removed |Added

 Status|MODIFIED|CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1376412] Review Request: golang-github-mattn-go-colorable - Colorable writer for windows.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376412

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1376412] Review Request: golang-github-mattn-go-colorable - Colorable writer for windows.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376412



--- Comment #17 from Fedora Update System  ---
golang-github-mattn-go-colorable-0-0.3.20170816gitad5389d.fc26 has been
submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-ba91ff6381

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1376412] Review Request: golang-github-mattn-go-colorable - Colorable writer for windows.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376412



--- Comment #16 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/golang-github-mattn-go-colorable

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1376412] Review Request: golang-github-mattn-go-colorable - Colorable writer for windows.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376412



--- Comment #15 from Matthias Runge  ---
*thank you*

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1376412] Review Request: golang-github-mattn-go-colorable - Colorable writer for windows.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376412

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
  Flags|fedora-review?  |fedora-review+



--- Comment #14 from Robert-André Mauchin  ---
That's strange. Package is good and accepted.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1376412] Review Request: golang-github-mattn-go-colorable - Colorable writer for windows.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376412



--- Comment #13 from Matthias Runge  ---
Hmm, it just fails on my f26 host. However, it works in mockbuild

SPEC: http://www.matthias-runge.de/fedora/golang-github-mattn-go-colorable.spec
SRPM:
http://www.matthias-runge.de/fedora/golang-github-mattn-go-colorable-0-0.3.20170816gitad5389d.fc26.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1376412] Review Request: golang-github-mattn-go-colorable - Colorable writer for windows.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376412



--- Comment #12 from Robert-André Mauchin  ---
> removing them, results in test failures

I can't reproduce such failures, nor can I find any indication that the
examples are used for the tests.

You can see in this Koji build I've just done:
https://koji.fedoraproject.org/koji/taskinfo?taskID=21946877

No failure in the logs: 
+
GOPATH=/builddir/build/BUILDROOT/golang-github-mattn-go-colorable-0-0.2.20170816gitad5389d.fc28.x86_64//usr/share/gocode:/usr/share/gocode
+ go test -compiler gc -ldflags '' gopkg.in/mattn/go-colorable.v1
ok  gopkg.in/mattn/go-colorable.v10.003s
+ exit 0

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1376412] Review Request: golang-github-mattn-go-colorable - Colorable writer for windows.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376412



--- Comment #11 from Matthias Runge  ---
right. 

removing them, results in test failures. examples are being used during tests.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1376412] Review Request: golang-github-mattn-go-colorable - Colorable writer for windows.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376412



--- Comment #10 from Robert-André Mauchin  ---
You didn't remove _example from the devel files list, thus the files will be
listed twice.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1376412] Review Request: golang-github-mattn-go-colorable - Colorable writer for windows.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376412



--- Comment #9 from Matthias Runge  ---
SPEC: http://www.matthias-runge.de/fedora/golang-github-mattn-go-colorable.spec
SRPM:
http://www.matthias-runge.de/fedora/golang-github-mattn-go-colorable-0-0.2.20170816gitad5389d.fc26.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1376412] Review Request: golang-github-mattn-go-colorable - Colorable writer for windows.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376412



--- Comment #8 from Robert-André Mauchin  ---
I didn't have any issue with the tests despite putting _example in %doc.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1376412] Review Request: golang-github-mattn-go-colorable - Colorable writer for windows.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376412



--- Comment #7 from Matthias Runge  ---
_example is used during tests; not sure if I still should add it to docs. Tests
expect it to live under
/usr/share/gocode/src/gopkg.in/mattn/go-colorable.v1/_example/

I'll need to add
/usr/share/gocode/src/gopkg.in/mattn/go-colorable.v1/cmd/colorable (as written
in comment 4). Update will follow shortly.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1376412] Review Request: golang-github-mattn-go-colorable - Colorable writer for windows.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376412



--- Comment #6 from Matthias Runge  ---
Thank you for your review


Updated
SPEC: http://www.matthias-runge.de/fedora/golang-github-mattn-go-colorable.spec
SRPM:
http://www.matthias-runge.de/fedora/golang-github-mattn-go-colorable-0-0.1.20170816gitad5389d.fc26.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1376412] Review Request: golang-github-mattn-go-colorable - Colorable writer for windows.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376412

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review?



--- Comment #5 from Robert-André Mauchin  ---
The review itself:

 - golang-github-mattn-go-colorable.src: W: summary-ended-with-dot C Colorable
writer for windows.

  Trivial: remove the dot at the end of the summary.

 - The _example directory should go in %doc:

   First remove _example from the devel files list by modifying this line:

for file in $(find . -iname "*.go" \! -iname "*_test.go" \! -path
"./_example/*") ; do

   Then add it to doc:

%doc README.md _example


 - You must own /usr/share/gocode/src/github.com/mattn/go-colorable/cmd

%dir %{gopath}/src/%{provider}.%{provider_tld}/%{project}/go-colorable/cmd



Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "MIT/X11 (BSD like)", "Unknown or generated". 11 files have
 unknown license. Detailed output of licensecheck in
 /home/bob/packaging/review/golang-github-mattn-go-colorable/review-
 golang-github-mattn-go-colorable/licensecheck.txt
[-]: Package requires other packages for directories it uses.
 Note: No known owner of /usr/share/gocode/src/github.com/mattn/go-
 colorable/_example, /usr/share/gocode/src/github.com/mattn/go-
 colorable/cmd
[!]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/share/gocode/src,
 /usr/share/gocode/src/github.com/mattn/go-colorable/_example,
 /usr/share/gocode/src/github.com/mattn/go-colorable/cmd,
 /usr/share/gocode, /usr/share/gocode/src/github.com
[x]: Package does not own files or directories owned by other packages.
 Note: Dirs in package are owned also by:
 /usr/share/gocode/src/github.com/mattn(golang-github-mattn-go-
 runewidth-devel)
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec 

[Bug 1376412] Review Request: golang-github-mattn-go-colorable - Colorable writer for windows.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376412

Robert-André Mauchin  changed:

   What|Removed |Added

 CC||zebo...@gmail.com



--- Comment #3 from Robert-André Mauchin  ---
Hello,

I'll review yours since you are older and responsive.

 - Please bump to the latest revision:

%global commit  ad5389df28cdac544c99bd7b9161a0b5b6ca9d1b

 - Please provide a commitdate for versionning:

%global commitdate  20170816

   And:

Release:0.1.%{commitdate}git%{shortcommit}%{?dist}

   Then:

* Mon Sep 18 2017 Matthias Runge  - 0-0.1.20170816gitad5389d

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1376412] Review Request: golang-github-mattn-go-colorable - Colorable writer for windows.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376412

Robert-André Mauchin  changed:

   What|Removed |Added

 Blocks||1430146, 1430147
 CC||e...@logic.net



--- Comment #4 from Robert-André Mauchin  ---
*** Bug 1430144 has been marked as a duplicate of this bug. ***


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1430146
[Bug 1430146] Review Request: golang-github-mgutz-ansi - Small, fast
library to create ANSI colored strings and codes.
https://bugzilla.redhat.com/show_bug.cgi?id=1430147
[Bug 1430147] Review Request: golang-github-mgutz-logxi - A 12-factor app
logger built for performance and happy development
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1376412] Review Request: golang-github-mattn-go-colorable - Colorable writer for windows.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376412

Matthias Runge  changed:

   What|Removed |Added

  Flags|needinfo?(mru...@redhat.com |
   |)   |



--- Comment #2 from Matthias Runge  ---
Sure. The other way around, one could ask, why the committer of
https://bugzilla.redhat.com/show_bug.cgi?id=1430144 did not act as reviewer
here.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1376412] Review Request: golang-github-mattn-go-colorable - Colorable writer for windows.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376412

Elliott Sales de Andrade  changed:

   What|Removed |Added

 CC||mru...@redhat.com,
   ||quantum.anal...@gmail.com
  Flags||needinfo?(mru...@redhat.com
   ||)



--- Comment #1 from Elliott Sales de Andrade  ---
I would guess that as with go-isatty, you'd be okay with closing this in favour
of another review?

There is another one at bug 1430144.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1376412] Review Request: golang-github-mattn-go-colorable - Colorable writer for windows.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376412

Jan Chaloupka  changed:

   What|Removed |Added

 Depends On||1430143




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1430143
[Bug 1430143] Review Request: golang-github-mattn-go-isatty - isatty for Go
(golang)
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1376412] Review Request: golang-github-mattn-go-colorable - Colorable writer for windows.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376412
Bug 1376412 depends on bug 1376407, which changed state.

Bug 1376407 Summary: Review Request: golang-github-mattn-go-isatty - isatty for 
golang
https://bugzilla.redhat.com/show_bug.cgi?id=1376407

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |NOTABUG



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1376412] Review Request: golang-github-mattn-go-colorable - Colorable writer for windows.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376412

Matthias Runge  changed:

   What|Removed |Added

 Blocks||1377229




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1377229
[Bug 1377229] Review Request: golang-github-inconshreveable-log15 -
Structured, composable logging for Go
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1376412] Review Request: golang-github-mattn-go-colorable - Colorable writer for windows.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376412

Matthias Runge  changed:

   What|Removed |Added

 Blocks||1376437




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1376437
[Bug 1376437] Review Request: golang-github-fatih-color - Color package for
Go (golang)
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1376412] Review Request: golang-github-mattn-go-colorable - Colorable writer for windows.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376412

Matthias Runge  changed:

   What|Removed |Added

 Blocks||1376389
 Depends On||1376407




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1376389
[Bug 1376389] Tracker for grafana dependencies
https://bugzilla.redhat.com/show_bug.cgi?id=1376407
[Bug 1376407] Review Request: golang-github-mattn-go-isatty - isatty for
golang
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org