[Bug 1377227] Review Request: golang-github-go-stack-stack - Implements utilities to capture, manipulate, and format call stacks

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1377227



--- Comment #12 from Elliott Sales de Andrade  ---
Matthias, feel free to retire this package name.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1377227] Review Request: golang-github-go-stack-stack - Implements utilities to capture, manipulate, and format call stacks

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1377227

Nathan Scott  changed:

   What|Removed |Added

 Status|POST|CLOSED
 CC||nath...@redhat.com
 Resolution|--- |DUPLICATE
Last Closed|2017-07-19 22:58:07 |2019-03-16 22:00:34



--- Comment #11 from Nathan Scott  ---


*** This bug has been marked as a duplicate of bug 1689595 ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1377227] Review Request: golang-github-go-stack-stack - Implements utilities to capture, manipulate, and format call stacks

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1377227



--- Comment #10 from Mark Goodwin  ---
(In reply to Elliott Sales de Andrade from comment #9)
> Mark,
> 
> If you use the new Go macros, it will create a package with the name
> "golang-github-stack", so I recommend retiring this one and opening a new
> review with the right name.

thanks Elliot, will do - and close this as a DUP when the new BZ is ready

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1377227] Review Request: golang-github-go-stack-stack - Implements utilities to capture, manipulate, and format call stacks

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1377227



--- Comment #9 from Elliott Sales de Andrade  ---
Mark,

If you use the new Go macros, it will create a package with the name
"golang-github-stack", so I recommend retiring this one and opening a new
review with the right name.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1377227] Review Request: golang-github-go-stack-stack - Implements utilities to capture, manipulate, and format call stacks

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1377227

Elliott Sales de Andrade  changed:

   What|Removed |Added

 CC||mgood...@redhat.com
 Blocks||1670656



--- Comment #8 from Elliott Sales de Andrade  ---
Mark is interested in this for Grafana.


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1670656
[Bug 1670656] Review Request: grafana - an open source, feature rich metrics
dashboard and graph editor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1377227] Review Request: golang-github-go-stack-stack - Implements utilities to capture, manipulate, and format call stacks

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1377227



--- Comment #7 from Matthias Runge  ---
Ugh, how could I miss this.

However, I don't have any interest in this, and am happy to give this package
to someone caring better than I did, or to just retire the package.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1377227] Review Request: golang-github-go-stack-stack - Implements utilities to capture, manipulate, and format call stacks

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1377227

Elliott Sales de Andrade  changed:

   What|Removed |Added

 Status|CLOSED  |POST
 CC||quantum.anal...@gmail.com
 Resolution|ERRATA  |---
   Keywords||Reopened



--- Comment #6 from Elliott Sales de Andrade  ---
This was never built; also, it doesn't follow the naming for the new Go macros.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1377227] Review Request: golang-github-go-stack-stack - Implements utilities to capture, manipulate, and format call stacks

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1377227

Athos Ribeiro  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-07-19 18:58:07



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1377227] Review Request: golang-github-go-stack-stack - Implements utilities to capture, manipulate, and format call stacks

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1377227



--- Comment #5 from Gwyn Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/golang-github-go-stack-stack

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1377227] Review Request: golang-github-go-stack-stack - Implements utilities to capture, manipulate, and format call stacks

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1377227



--- Comment #4 from Athos Ribeiro  ---
Following up on [1], there was a license change upstream (to MIT).

[1] https://github.com/go-stack/stack/issues/7

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1377227] Review Request: golang-github-go-stack-stack - Implements utilities to capture, manipulate, and format call stacks

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1377227

Athos Ribeiro  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #3 from Athos Ribeiro  ---
Hello,

Thanks for the modifications. I opened an issue upstream asking if they could
include the full ASL2.0 text in the package [1]

Package looks good. Approved

[1] https://github.com/go-stack/stack/issues/7

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated

= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
[-]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[x]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
[?]: Package functions as described.
[x]: Latest version is packaged.
[!]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
 files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
 $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Package should compile and build 

[Bug 1377227] Review Request: golang-github-go-stack-stack - Implements utilities to capture, manipulate, and format call stacks

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1377227



--- Comment #2 from Matthias Runge  ---
Thank you for your review. I've updated the SPEC and SRPM:

SPEC: http://www.matthias-runge.de/fedora/golang-github-go-stack-stack.spec
SRPM:
http://www.matthias-runge.de/fedora/golang-github-go-stack-stack-1.5.2-1.fc25.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1377227] Review Request: golang-github-go-stack-stack - Implements utilities to capture, manipulate, and format call stacks

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1377227



--- Comment #1 from Athos Ribeiro  ---
Hello,

I am taking this one.

- As pointed in [1], packages licensed under ASL2.0 must include the license
text. Note that the provided LICENSE.md file does not include the ASL2.0 text
license, but a link to it.

- Upstream does provide version tags [2].

- If you are packaging a post release snapshot, there are new guidelines for
the Release: tag. For instance, the date the snapshot was taken must be present
(this should be updated in gofed). See [3] and [4] for reference.

- The conditionals on lines 52 and 69 could be removed, since they are not used
at all.

[1] https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text
[2] https://github.com/go-stack/stack/tree/v1.5.2
[3] https://fedoraproject.org/wiki/Packaging:Versioning
[4] https://fedoraproject.org/wiki/Package_Versioning_Examples

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1377227] Review Request: golang-github-go-stack-stack - Implements utilities to capture, manipulate, and format call stacks

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1377227

Athos Ribeiro  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||athoscribe...@gmail.com
   Assignee|nob...@fedoraproject.org|athoscribe...@gmail.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1377227] Review Request: golang-github-go-stack-stack - Implements utilities to capture, manipulate, and format call stacks

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1377227

Matthias Runge  changed:

   What|Removed |Added

 Blocks||1377229




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1377229
[Bug 1377229] Review Request: golang-github-inconshreveable-log15 -
Structured, composable logging for Go
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1377227] Review Request: golang-github-go-stack-stack - Implements utilities to capture, manipulate, and format call stacks

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1377227

Matthias Runge  changed:

   What|Removed |Added

 Blocks||1376389




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1376389
[Bug 1376389] Tracker for grafana dependencies
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org