[Bug 1378860] Review Request: jetty-setuid - SetUID support for jetty
https://bugzilla.redhat.com/show_bug.cgi?id=1378860 Michael Simacek changed: What|Removed |Added Status|ASSIGNED|CLOSED Blocks|652183 (FE-JAVASIG) |201449 (FE-DEADREVIEW) Resolution|--- |NOTABUG Flags|fedora-review? | Last Closed||2018-03-26 09:56:19 --- Comment #8 from Michael Simacek --- I'm no longer interested in packaging this component, sorry for taking your time Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=201449 [Bug 201449] FE-DEADREVIEW -- Reviews stalled due to lack of submitter response should be blocking this bug. https://bugzilla.redhat.com/show_bug.cgi?id=652183 [Bug 652183] Java SIG tracker bug -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1378860] Review Request: jetty-setuid - SetUID support for jetty
https://bugzilla.redhat.com/show_bug.cgi?id=1378860 --- Comment #7 from Mikolaj Izdebski --- Koji scratch build passed: http://koji.fedoraproject.org/koji/taskinfo?taskID=15968879 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1378860] Review Request: jetty-setuid - SetUID support for jetty
https://bugzilla.redhat.com/show_bug.cgi?id=1378860 --- Comment #6 from Mikolaj Izdebski --- Package Review == Key: - = N/A x = Check ! = Problem [x] rpmlint must be run on the source rpm and all binary rpms the build produces. The output should be posted in the review. [x] The package must be named according to the Package Naming Guidelines. [x] The spec file name must match the base package %{name}, in the format %{name}.spec unless your package has an exemption. [!] The package must meet the Packaging Guidelines. * Compilers used to build packages must honor the applicable compiler flags set in the system rpm configuration. See https://fedoraproject.org/wiki/Packaging:Guidelines#Compiler_flags * Source URLs should point to git commits, not branches (jetty-9.3.x) and not tags (%{name}-%{version}). See https://fedoraproject.org/wiki/Packaging:SourceURL#Git_Hosting_Services * JNI shared objects MUST be placed in %{_libdir}/%{name}, not under %{_jnidir}. See http://fedoraproject.org/wiki/Packaging:Java#Guideline * The javadoc subpackage MUST be declared noarch even if main package is architecture specific. See http://fedoraproject.org/wiki/Packaging:Java#Javadoc_installation [!] The package must be licensed with a Fedora approved license and meet the Licensing Guidelines. License text should be taken from "reliable and canonical sources". Branches on Github are neither reliable nor cannonical. See https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text [x] The License field in the package spec file must match the actual license. [x] If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc. [x] The spec file must be written in American English. [x] The spec file for the package MUST be legible. [x] The sources used to build the package must match the upstream source, as provided in the spec URL. Reviewers should use sha256sum for this task as it is used by the sources file once imported into git. If no upstream URL can be specified for this package, please see the Source URL Guidelines for how to deal with this. [x] The package MUST successfully compile and build into binary rpms on at least one primary architecture. [x] If the package does not successfully compile, build or work on an architecture, then those architectures should be listed in the spec in ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in bugzilla, describing the reason that the package does not compile/build/work on that architecture. The bug number MUST be placed in a comment, next to the corresponding ExcludeArch line. [x] All build dependencies must be listed in BuildRequires, except for any that are listed in the exceptions section of the Packaging Guidelines; inclusion of those as BuildRequires is optional. Apply common sense. [x] The spec file MUST handle locales properly. This is done by using the %find_lang macro. Using %{_datadir}/locale/* is strictly forbidden. [x] Every binary RPM package (or subpackage) which stores shared library files (not just symlinks) in any of the dynamic linker's default paths, must call ldconfig in %post and %postun. [x] Packages must NOT bundle copies of system libraries. [x] If the package is designed to be relocatable, the packager must state this fact in the request for review, along with the rationalization for relocation of that specific package. Without this, use of Prefix: /usr is considered a blocker. [x] A package must own all directories that it creates. If it does not create a directory that it uses, then it should require a package which does create that directory. [x] A Fedora package must not list a file more than once in the spec file's %files listings. (Notable exception: license texts in specific situations.) [x] Permissions on files must be set properly. Executables should be set with executable permissions, for example. [!] Each package must consistently use macros. xmvn-config.xml should not hardcode path to %{_libdir}, but use RPM macros. [x] The package must contain code, or permissible content. [x] Large documentation files must go in a -doc subpackage. (The definition of large is left up to the packager's best judgement, but is not restricted to size. Large can refer to either size or quantity). [x] If a package includes something as %doc, it must not affect the runtime of the application. To summarize: If it is in %doc, the program must run properly if it is not present. [x] Static libraries must be in a -static package. [x] Development files must be in a -devel package. [x] In the vast majority of cases, devel packages must require t
[Bug 1378860] Review Request: jetty-setuid - SetUID support for jetty
https://bugzilla.redhat.com/show_bug.cgi?id=1378860 --- Comment #5 from gil cattaneo --- If there aren't any objections i can take this review ... ? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1378860] Review Request: jetty-setuid - SetUID support for jetty
https://bugzilla.redhat.com/show_bug.cgi?id=1378860 --- Comment #4 from Michael Simacek --- Fixed license tag, linking flags, unstripped binary and mismatched license file content. For missing setgroups I created upstream issue [1]. Because jetty-setuid is supposed to be just a thin wrapper around the actual syscalls, I'm not sure where to fix it myself. [1] https://github.com/eclipse/jetty.toolchain/issues/6 Spec URL: https://msimacek.fedorapeople.org/jetty-setuid.spec SRPM URL: https://msimacek.fedorapeople.org/jetty-setuid-1.0.3-2.fc24.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1378860] Review Request: jetty-setuid - SetUID support for jetty
https://bugzilla.redhat.com/show_bug.cgi?id=1378860 Bug 1378860 depends on bug 1378077, which changed state. Bug 1378077 Summary: Review Request: jetty-test-helper - Jetty toolchain test helper https://bugzilla.redhat.com/show_bug.cgi?id=1378077 What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1378860] Review Request: jetty-setuid - SetUID support for jetty
https://bugzilla.redhat.com/show_bug.cgi?id=1378860 --- Comment #3 from gil cattaneo --- (In reply to gil cattaneo from comment #1) > rpmlint output: > Checking: jetty-setuid-1.0.3-1.fc26.i686.rpm > jetty-setuid-javadoc-1.0.3-1.fc26.i686.rpm > jetty-setuid-1.0.3-1.fc26.src.rpm > jetty-setuid.i686: W: unstripped-binary-or-object > /usr/lib/java/jetty-setuid/libsetuid-linux.so > jetty-setuid.i686: E: missing-call-to-setgroups-before-setuid > /usr/lib/java/jetty-setuid/libsetuid-linux.so > jetty-setuid.src: W: file-size-mismatch LICENSE-eplv10-aslv20.html = 280721, > https://raw.githubusercontent.com/eclipse/jetty.project/jetty-9.3.x/LICENSE- > eplv10-aslv20.html = 30012 > 3 packages and 0 specfiles checked; 1 errors, 2 warnings. > > libsetuid-linux have these entries: > > -shared -lc > -ldl > maybe you shoukd change with: > -Wl --as-needed -lc > -ldl > for avoid "unused-direct-shlib-dependency and undefined-non-weak-symbol" Do not work [INFO] --- native-maven-plugin:1.0-alpha-8:link (default-link) @ libsetuid-linux --- [INFO] /bin/sh -c cd '/home/gil/rpmbuild/BUILD/jetty.toolchain-jetty-setuid-1.0.3/jetty-setuid/libsetuid-linux' && 'gcc' '-Wl' '--as-needed' '-lc' '-ldl' '-o' '/home/gil/rpmbuild/BUILD/jetty.toolchain-jetty-setuid-1.0.3/jetty-setuid/libsetuid-linux/target/libsetuid-linux.so' 'target/objs/org_eclipse_jetty_setuid_SetUID.o' '-o' '/home/gil/rpmbuild/BUILD/jetty.toolchain-jetty-setuid-1.0.3/jetty-setuid/libsetuid-linux/target/libsetuid-linux.so' gcc: error: unrecognized command line option '-Wl'; did you mean '-W'? gcc: error: unrecognized command line option '--as-needed' -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1378860] Review Request: jetty-setuid - SetUID support for jetty
https://bugzilla.redhat.com/show_bug.cgi?id=1378860 --- Comment #2 from gil cattaneo --- (In reply to gil cattaneo from comment #1) > hi > sorry for the noise, some hints: > License field is wrong: > EPL-1.0 Sorry, my mistake, license field is correct -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1378860] Review Request: jetty-setuid - SetUID support for jetty
https://bugzilla.redhat.com/show_bug.cgi?id=1378860 gil cattaneo changed: What|Removed |Added CC||punto...@libero.it --- Comment #1 from gil cattaneo --- hi sorry for the noise, some hints: License field is wrong: EPL-1.0 --- jetty.toolchain-jetty-setuid-1.0.3/jetty-setuid/jetty-setuid-java/src/main/java/org/eclipse/jetty/setuid/Group.java jetty.toolchain-jetty-setuid-1.0.3/jetty-setuid/jetty-setuid-java/src/main/java/org/eclipse/jetty/setuid/Passwd.java jetty.toolchain-jetty-setuid-1.0.3/jetty-setuid/jetty-setuid-java/src/main/java/org/eclipse/jetty/setuid/RLimit.java jetty.toolchain-jetty-setuid-1.0.3/jetty-setuid/jetty-setuid-java/src/main/java/org/eclipse/jetty/setuid/SetUID.java jetty.toolchain-jetty-setuid-1.0.3/jetty-setuid/jetty-setuid-java/src/main/java/org/eclipse/jetty/setuid/SetUIDListener.java jetty.toolchain-jetty-setuid-1.0.3/jetty-setuid/jetty-setuid-java/src/main/java/org/eclipse/jetty/setuid/SetUIDServer.java jetty.toolchain-jetty-setuid-1.0.3/jetty-setuid/jetty-setuid-native/src/main/resources/org_eclipse_jetty_setuid_SetUID.c rpmlint output: Checking: jetty-setuid-1.0.3-1.fc26.i686.rpm jetty-setuid-javadoc-1.0.3-1.fc26.i686.rpm jetty-setuid-1.0.3-1.fc26.src.rpm jetty-setuid.i686: W: unstripped-binary-or-object /usr/lib/java/jetty-setuid/libsetuid-linux.so jetty-setuid.i686: E: missing-call-to-setgroups-before-setuid /usr/lib/java/jetty-setuid/libsetuid-linux.so jetty-setuid.src: W: file-size-mismatch LICENSE-eplv10-aslv20.html = 280721, https://raw.githubusercontent.com/eclipse/jetty.project/jetty-9.3.x/LICENSE-eplv10-aslv20.html = 30012 3 packages and 0 specfiles checked; 1 errors, 2 warnings. libsetuid-linux have these entries: -shared -lc -ldl maybe you shoukd change with: -Wl --as-needed -lc -ldl for avoid "unused-direct-shlib-dependency and undefined-non-weak-symbol" jetty-setuid-native artifact contains only the generated C files used for build the jni library only, maybe you could remove maven-dependency-plugin unpack generate-resources unpack org.eclipse.jetty.toolchain.setuid jetty-setuid-native ${project.version} true ${native-source-dir}/ org.codehaus.mojo native-maven-plugin ... org.eclipse.jetty.toolchain jetty-test-helper ${jetty-test-helper-version} test org.eclipse.jetty.toolchain.setuid jetty-setuid-java ${project.version} - - - org.eclipse.jetty.toolchain.setuid - jetty-setuid-native - ${project.version} -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1378860] Review Request: jetty-setuid - SetUID support for jetty
https://bugzilla.redhat.com/show_bug.cgi?id=1378860 Michael Simacek changed: What|Removed |Added Depends On||1378077 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1378077 [Bug 1378077] Review Request: jetty-test-helper - Jetty toolchain test helper -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1378860] Review Request: jetty-setuid - SetUID support for jetty
https://bugzilla.redhat.com/show_bug.cgi?id=1378860 Mikolaj Izdebski changed: What|Removed |Added Status|NEW |ASSIGNED CC||mizde...@redhat.com Assignee|nob...@fedoraproject.org|mizde...@redhat.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org