[Bug 1379174] Review Request: vmod-querystring - QueryString module for Varnish Cache
https://bugzilla.redhat.com/show_bug.cgi?id=1379174 --- Comment #11 from Fedora Update System --- vmod-querystring-1.0.1-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1379174] Review Request: vmod-querystring - QueryString module for Varnish Cache
https://bugzilla.redhat.com/show_bug.cgi?id=1379174 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2017-02-22 12:23:36 --- Comment #10 from Fedora Update System --- vmod-querystring-1.0.1-1.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1379174] Review Request: vmod-querystring - QueryString module for Varnish Cache
https://bugzilla.redhat.com/show_bug.cgi?id=1379174 --- Comment #9 from Fedora Update System --- vmod-querystring-1.0.1-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-b4b39da465 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1379174] Review Request: vmod-querystring - QueryString module for Varnish Cache
https://bugzilla.redhat.com/show_bug.cgi?id=1379174 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #8 from Fedora Update System --- vmod-querystring-1.0.1-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-75ddb4ed26 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1379174] Review Request: vmod-querystring - QueryString module for Varnish Cache
https://bugzilla.redhat.com/show_bug.cgi?id=1379174 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1379174] Review Request: vmod-querystring - QueryString module for Varnish Cache
https://bugzilla.redhat.com/show_bug.cgi?id=1379174 --- Comment #7 from Fedora Update System --- vmod-querystring-1.0.1-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-75ddb4ed26 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1379174] Review Request: vmod-querystring - QueryString module for Varnish Cache
https://bugzilla.redhat.com/show_bug.cgi?id=1379174 --- Comment #6 from Fedora Update System --- vmod-querystring-1.0.1-1.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-b4b39da465 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1379174] Review Request: vmod-querystring - QueryString module for Varnish Cache
https://bugzilla.redhat.com/show_bug.cgi?id=1379174 --- Comment #5 from Jon Ciesla --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/vmod-querystring -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1379174] Review Request: vmod-querystring - QueryString module for Varnish Cache
https://bugzilla.redhat.com/show_bug.cgi?id=1379174 Mukundan Ragavan changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #4 from Mukundan Ragavan --- Thanks for the fixes. These changes look fine. Package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1379174] Review Request: vmod-querystring - QueryString module for Varnish Cache
https://bugzilla.redhat.com/show_bug.cgi?id=1379174 --- Comment #3 from Dridi Boukelmoune --- Spec URL: https://dridi.fedorapeople.org/review/vmod-querystring.spec SRPM URL: https://dridi.fedorapeople.org/review/vmod-querystring-1.0.1-1.fc24.src.rpm I added the %license and also added the %optflags since varnish modules are supposed to be loaded by a long-running daemon. Thanks for reviewing! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1379174] Review Request: vmod-querystring - QueryString module for Varnish Cache
https://bugzilla.redhat.com/show_bug.cgi?id=1379174 --- Comment #2 from Mukundan Ragavan --- Please see detailed comments below. Package Review == Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: === - Sources used to build the package match the upstream source, as provided in the spec URL. Note: Upstream MD5sum check error, diff is in /home/mukundan/ownCloud/misc_pkgs/pkg_reviews/1379174-vmod- querystring/diff.txt See: http://fedoraproject.org/wiki/Packaging/SourceURL ---> Source tarball should be the same as upstream. Please see checksums below. - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: License file LICENSE is not marked as %license See: http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text ---> No license installed. Source tarball includes license file. Please use %license macro to install license. = MUST items = C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [!]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "MIT/X11 (BSD like)", "GPL (v3 or later)", "Unknown or generated". 14 files have unknown license. Detailed output of licensecheck in /home/mukundan/ownCloud/misc_pkgs/pkg_reviews/1379174 -vmod-querystring/licensecheck.txt GPL (v3 or later) - vmod-querystring-1.0.1/LICENSE vmod-querystring-1.0.1/debian/copyright vmod-querystring-1.0.1/src/vmod_querystring.c MIT/X11 (BSD like) -- vmod-querystring-1.0.1/build-aux/install-sh Unknown or generated vmod-querystring-1.0.1/CHANGELOG vmod-querystring-1.0.1/CONTRIBUTORS vmod-querystring-1.0.1/build-aux/ar-lib vmod-querystring-1.0.1/build-aux/compile vmod-querystring-1.0.1/build-aux/depcomp vmod-querystring-1.0.1/build-aux/ltmain.sh vmod-querystring-1.0.1/build-aux/missing vmod-querystring-1.0.1/build-aux/test-driver vmod-querystring-1.0.1/configure vmod-querystring-1.0.1/debian/changelog vmod-querystring-1.0.1/debian/compat vmod-querystring-1.0.1/debian/control vmod-querystring-1.0.1/debian/rules vmod-querystring-1.0.1/debian/source/format ---> GPLv3+ is correct license for installed binary. GPL (v3 or later) - vmod-querystring-1.0.1/LICENSE vmod-querystring-1.0.1/debian/copyright vmod-querystring-1.0.1/src/vmod_querystring.c MIT/X11 (BSD like) -- vmod-querystring-1.0.1/build-aux/install-sh Unknown or generated vmod-querystring-1.0.1/CHANGELOG vmod-querystring-1.0.1/CONTRIBUTORS vmod-querystring-1.0.1/build-aux/ar-lib vmod-querystring-1.0.1/build-aux/compile vmod-querystring-1.0.1/build-aux/depcomp vmod-querystring-1.0.1/build-aux/ltmain.sh vmod-querystring-1.0.1/build-aux/missing vmod-querystring-1.0.1/build-aux/test-driver vmod-querystring-1.0.1/configure vmod-querystring-1.0.1/debian/changelog vmod-querystring-1.0.1/debian/compat vmod-querystring-1.0.1/debian/control vmod-querystring-1.0.1/debian/rules vmod-querystring-1.0.1/debian/source/format These files can be ignored. [!]: License file installed when any subpackage combination is installed. ---> This needs to be fixed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch
[Bug 1379174] Review Request: vmod-querystring - QueryString module for Varnish Cache
https://bugzilla.redhat.com/show_bug.cgi?id=1379174 Mukundan Ragavan changed: What|Removed |Added Status|NEW |ASSIGNED CC||nonamed...@gmail.com Assignee|nob...@fedoraproject.org|nonamed...@gmail.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1379174] Review Request: vmod-querystring - QueryString module for Varnish Cache
https://bugzilla.redhat.com/show_bug.cgi?id=1379174 Dridi Boukelmoune changed: What|Removed |Added Alias||vmod-querystring -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1379174] Review Request: vmod-querystring - QueryString module for Varnish Cache
https://bugzilla.redhat.com/show_bug.cgi?id=1379174 --- Comment #1 from Dridi Boukelmoune --- This review request supersedes 953514 and builds on packaging progress made in Varnish 4.0 and later 5.0. Instead of requiring a whole Varnish source tree as it was the case when the module was building against 3.0, it now relies on packaging goodies from Varnish 5 and builds against at least Varnish 4.1.3 (f24). Scratch builds available for: - rawhide http://koji.fedoraproject.org/koji/taskinfo?taskID=15796556 - f24 http://koji.fedoraproject.org/koji/taskinfo?taskID=15796561 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
