[Bug 1383781] Review Request: sunflow - A rendering system for photo-realistic image synthesis
https://bugzilla.redhat.com/show_bug.cgi?id=1383781 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2016-11-14 16:01:35 --- Comment #22 from Fedora Update System --- sunflow-0.07.3-8097f6d.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1383781] Review Request: sunflow - A rendering system for photo-realistic image synthesis
https://bugzilla.redhat.com/show_bug.cgi?id=1383781 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #21 from Fedora Update System --- sunflow-0.07.3-8097f6d.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-e4985bc6c0 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1383781] Review Request: sunflow - A rendering system for photo-realistic image synthesis
https://bugzilla.redhat.com/show_bug.cgi?id=1383781 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1383781] Review Request: sunflow - A rendering system for photo-realistic image synthesis
https://bugzilla.redhat.com/show_bug.cgi?id=1383781 --- Comment #20 from Fedora Update System --- sunflow-0.07.3-8097f6d.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-e4985bc6c0 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1383781] Review Request: sunflow - A rendering system for photo-realistic image synthesis
https://bugzilla.redhat.com/show_bug.cgi?id=1383781 --- Comment #19 from Jon Ciesla --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/sunflow -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1383781] Review Request: sunflow - A rendering system for photo-realistic image synthesis
https://bugzilla.redhat.com/show_bug.cgi?id=1383781 jiri vanek changed: What|Removed |Added CC||jva...@redhat.com --- Comment #18 from jiri vanek --- Michal is being sponsored. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1383781] Review Request: sunflow - A rendering system for photo-realistic image synthesis
https://bugzilla.redhat.com/show_bug.cgi?id=1383781 --- Comment #17 from Michal Vala --- fixed, thanks! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1383781] Review Request: sunflow - A rendering system for photo-realistic image synthesis
https://bugzilla.redhat.com/show_bug.cgi?id=1383781 gil cattaneo changed: What|Removed |Added Blocks|652183 (FE-JAVASIG) | Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=652183 [Bug 652183] Java SIG tracker bug -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1383781] Review Request: sunflow - A rendering system for photo-realistic image synthesis
https://bugzilla.redhat.com/show_bug.cgi?id=1383781 gil cattaneo changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #16 from gil cattaneo --- NON blocking issues: [!]: Changelog in prescribed format. sunflow.noarch: W: incoherent-version-in-changelog 0.07.3.8097f6d ['0.07.3-8097f6d.fc26', '0.07.3-8097f6d'] Please, fix before import Approved -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1383781] Review Request: sunflow - A rendering system for photo-realistic image synthesis
https://bugzilla.redhat.com/show_bug.cgi?id=1383781
gil cattaneo changed:
What|Removed |Added
Status|NEW |ASSIGNED
--- Comment #15 from gil cattaneo ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "MIT/X11 (BSD like)", "*No copyright* GPL (v2 or later) (with
incorrect FSF address)", "GPL (v2 or later)", "Unknown or generated",
"BSD (3 clause)". 22 files have unknown license. Detailed output of
licensecheck in /home/gil/1383781-sunflow/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/share/icons/hicolor,
/usr/share/icons/hicolor/128x128/apps,
/usr/share/icons/hicolor/128x128
[x]: Package contains no bundled libraries without FPC exception.
[!]: Changelog in prescribed format.
[?]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: gtk-update-icon-cache is invoked in %postun and %posttrans if package
contains icons.
Note: icons in sunflow
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 40960 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
desktop-file-validate if there is such a file.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Java:
[x]: Bundled jar/class files should be removed before build
[x]: Packages have proper BuildRequires/Requires on jpackage-utils
Note: Maven packages do not need to (Build)Require jpackage-utils. It
is pulled in by maven-local
[x]: Javadoc documentation files are generated and included in -javadoc
subpackage
[x]: Javadoc subpackages should not have Requires: jpackage-utils
[x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink)
Maven:
[x]: If package contains pom.xml files install it (including metadata) even
when building with ant
[x]: POM files have correct Maven mapping
[x]: Maven packages should use new style packaging
[x]: Old add_to_ma
[Bug 1383781] Review Request: sunflow - A rendering system for photo-realistic image synthesis
https://bugzilla.redhat.com/show_bug.cgi?id=1383781 --- Comment #14 from Michal Vala --- both fixed koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=16331717 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1383781] Review Request: sunflow - A rendering system for photo-realistic image synthesis
https://bugzilla.redhat.com/show_bug.cgi?id=1383781
--- Comment #13 from gil cattaneo ---
Build fails: [ERROR] Plugin org.apache.maven.plugins:maven-source-plugin:3.0.1
or one of its dependencies could not be resolved: Cannot access central
(https://repo.maven.apache.org/maven2) in offline mode and the artifact
org.apache.maven.plugins:maven-source-plugin:jar:3.0.1 has not been downloaded
from it before. -> [Help 1]
Please, remove this useless plugin/task with:
%pom_remove_plugin :maven-source-plugin
RPMS spec file differ with the given spec file
--- /srpm-unpacked/sunflow.spec2016-10-17 13:24:18.0 +0200
+++ /srpm/sunflow.spec2016-11-03 10:05:04.418398346 +0100
@@ -11,10 +11,8 @@
Source2: sunflow.desktop
License: MIT
BuildArch: noarch
-BuildRequires: jpackage-utils
BuildRequires: desktop-file-utils
BuildRequires: dos2unix
-BuildRequires: javapackages-tools
BuildRequires: maven-local
BuildRequires: janino
@@ -29,8 +27,6 @@
%description javadoc
API documentation for sunflow.
-# TODO: blender export plugin
-
%prep
%setup -q
dos2unix -k CHANGELOG LICENSE README
@@ -40,7 +36,6 @@
%install
%mvn_install
-install -D -m 0644 target/%{name}-%{version}-javadoc.jar
$RPM_BUILD_ROOT%{_javadir}/%{name}/%{name}-javadoc.jar
%jpackage_script org.sunflow.SunflowGUI "" "" "janino:sunflow" sunflow true
@@ -77,7 +72,6 @@
%files javadoc -f .mfiles-javadoc
%license LICENSE
-%{_datadir}/java/%{name}/%{name}-javadoc.jar
%changelog
* Mon Oct 17 2016 Michal Vala
0.07.3-0.1.20140412git4f5017f
- switch to new upstream https://github.com/skrat/sunflow
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1383781] Review Request: sunflow - A rendering system for photo-realistic image synthesis
https://bugzilla.redhat.com/show_bug.cgi?id=1383781 gil cattaneo changed: What|Removed |Added Assignee|nob...@fedoraproject.org|punto...@libero.it Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1383781] Review Request: sunflow - A rendering system for photo-realistic image synthesis
https://bugzilla.redhat.com/show_bug.cgi?id=1383781 gil cattaneo changed: What|Removed |Added CC||punto...@libero.it --- Comment #12 from gil cattaneo --- have time for review this https://bugzilla.redhat.com/show_bug.cgi?id=1390156 ? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1383781] Review Request: sunflow - A rendering system for photo-realistic image synthesis
https://bugzilla.redhat.com/show_bug.cgi?id=1383781 --- Comment #11 from Michal Vala --- (In reply to gil cattaneo from comment #9) > (In reply to gil cattaneo from comment #1) > > > All source files are without license headers. > > Please, ask to upstream to confirm the licensing of code and/or content/s, > > and add license headers > > https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/ > > LicensingGuidelines#License_Clarification > > (In reply to Michal Vala from comment #2) > > > - license headers in source files > Is necessary contact the main developer/s of this project for license > clarifications @ https://sourceforge.net/p/sunflow/discussion/ Wrote an email few weeks ago but without any reaction. I wrote now to different email I found. Also post in forum https://sourceforge.net/p/sunflow/discussion/291739/thread/6c46f0ee/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1383781] Review Request: sunflow - A rendering system for photo-realistic image synthesis
https://bugzilla.redhat.com/show_bug.cgi?id=1383781 --- Comment #10 from Michal Vala --- (In reply to gil cattaneo from comment #8) > javadoc "MUST be installed ... as part of javadoc subpackage ...". > See: > https://fedoraproject.org/wiki/Packaging:Java#Javadoc_installation > https://fedora-java.github.io/howto/latest/#_javadoc_packages Sorry, misunderstood. Should be fixed. sunflow-javadoc package is back without javadoc.jar. koji task: http://koji.fedoraproject.org/koji/taskinfo?taskID=16265680 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1383781] Review Request: sunflow - A rendering system for photo-realistic image synthesis
https://bugzilla.redhat.com/show_bug.cgi?id=1383781 --- Comment #9 from gil cattaneo --- (In reply to gil cattaneo from comment #1) > All source files are without license headers. > Please, ask to upstream to confirm the licensing of code and/or content/s, > and add license headers > https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/ > LicensingGuidelines#License_Clarification (In reply to Michal Vala from comment #2) > - license headers in source files Is necessary contact the main developer/s of this project for license clarifications @ https://sourceforge.net/p/sunflow/discussion/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1383781] Review Request: sunflow - A rendering system for photo-realistic image synthesis
https://bugzilla.redhat.com/show_bug.cgi?id=1383781 gil cattaneo changed: What|Removed |Added CC||punto...@libero.it --- Comment #8 from gil cattaneo --- javadoc "MUST be installed ... as part of javadoc subpackage ...". See: https://fedoraproject.org/wiki/Packaging:Java#Javadoc_installation https://fedora-java.github.io/howto/latest/#_javadoc_packages -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1383781] Review Request: sunflow - A rendering system for photo-realistic image synthesis
https://bugzilla.redhat.com/show_bug.cgi?id=1383781 --- Comment #7 from Michal Vala --- done, links same, just replaced specfile. Spec URL: https://github.com/sparkoo/sunflow/releases/download/v0.07.3.8097f6d/sunflow.spec SRPM URL: https://github.com/sparkoo/sunflow/releases/download/v0.07.3.8097f6d/sunflow-0.07.3-8097f6d.fc24.src.rpm koji task: http://koji.fedoraproject.org/koji/taskinfo?taskID=16260250 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1383781] Review Request: sunflow - A rendering system for photo-realistic image synthesis
https://bugzilla.redhat.com/show_bug.cgi?id=1383781 --- Comment #6 from Michal Vala --- (In reply to gil cattaneo from comment #5) > With FAS Username: michalvala return "No packagers found in the database." > Please, add proper FAS Username or re-add this bug in rhbz#177841 I removed "need sponsor" because my colleague will sponsor me. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1383781] Review Request: sunflow - A rendering system for photo-realistic image synthesis
https://bugzilla.redhat.com/show_bug.cgi?id=1383781 gil cattaneo changed: What|Removed |Added CC||punto...@libero.it --- Comment #5 from gil cattaneo --- With FAS Username: michalvala return "No packagers found in the database." Please, add proper FAS Username or re-add this bug in rhbz#177841 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1383781] Review Request: sunflow - A rendering system for photo-realistic image synthesis
https://bugzilla.redhat.com/show_bug.cgi?id=1383781 --- Comment #4 from gil cattaneo --- Please, remove also: BuildRequires: jpackage-utils BuildRequires: javapackages-tools because "BuildRequires: maven-local" is enough -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1383781] Review Request: sunflow - A rendering system for photo-realistic image synthesis
https://bugzilla.redhat.com/show_bug.cgi?id=1383781 gil cattaneo changed: What|Removed |Added CC||punto...@libero.it --- Comment #3 from gil cattaneo --- Please, remove (useless) javadoc.jar -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1383781] Review Request: sunflow - A rendering system for photo-realistic image synthesis
https://bugzilla.redhat.com/show_bug.cgi?id=1383781 Michal Vala changed: What|Removed |Added Blocks|177841 (FE-NEEDSPONSOR) | Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1383781] Review Request: sunflow - A rendering system for photo-realistic image synthesis
https://bugzilla.redhat.com/show_bug.cgi?id=1383781 --- Comment #2 from Michal Vala --- Spec URL: https://github.com/sparkoo/sunflow/releases/download/v0.07.3.8097f6d/sunflow.spec SRPM URL: https://github.com/sparkoo/sunflow/releases/download/v0.07.3.8097f6d/sunflow-0.07.3-8097f6d.fc24.src.rpm koji task: http://koji.fedoraproject.org/koji/taskinfo?taskID=16105793 * Mon Oct 17 2016 Michal Vala https://github.com/sparkoo/sunflow - build with maven - license headers in source files - applied no jvm warn patch - updated janino dependency to match with fedora one -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1383781] Review Request: sunflow - A rendering system for photo-realistic image synthesis
https://bugzilla.redhat.com/show_bug.cgi?id=1383781 gil cattaneo changed: What|Removed |Added Blocks||177841 (FE-NEEDSPONSOR) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1383781] Review Request: sunflow - A rendering system for photo-realistic image synthesis
https://bugzilla.redhat.com/show_bug.cgi?id=1383781 gil cattaneo changed: What|Removed |Added CC||punto...@libero.it --- Comment #1 from gil cattaneo --- Issues: license is MIT. See https://sourceforge.net/p/sunflow/code/HEAD/tree/trunk/LICENSE Use %license macro instead of %doc LICENSE https://fedoraproject.org/wiki/How_to_create_an_RPM_package#.25files_example sunflow.jdk.level must be 6 or major, instead of 5 (necessary for JVM >= 1.8) All source files are without license headers. Please, ask to upstream to confirm the licensing of code and/or content/s, and add license headers https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/LicensingGuidelines#License_Clarification Please, add better description near the patches -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1383781] Review Request: sunflow - A rendering system for photo-realistic image synthesis
https://bugzilla.redhat.com/show_bug.cgi?id=1383781 gil cattaneo changed: What|Removed |Added Blocks||652183 (FE-JAVASIG) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=652183 [Bug 652183] Java SIG tracker bug -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
