[Bug 1390156] Review Request: jsonassert - JUnit extension to write JSON unit tests
https://bugzilla.redhat.com/show_bug.cgi?id=1390156 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2016-11-19 16:13:21 --- Comment #11 from Fedora Update System --- jsonassert-1.4.0-1.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1390156] Review Request: jsonassert - JUnit extension to write JSON unit tests
https://bugzilla.redhat.com/show_bug.cgi?id=1390156 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #10 from Fedora Update System --- jsonassert-1.4.0-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-15dbccbf42 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1390156] Review Request: jsonassert - JUnit extension to write JSON unit tests
https://bugzilla.redhat.com/show_bug.cgi?id=1390156 --- Comment #9 from Fedora Update System --- jsonassert-1.4.0-1.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-15dbccbf42 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1390156] Review Request: jsonassert - JUnit extension to write JSON unit tests
https://bugzilla.redhat.com/show_bug.cgi?id=1390156 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1390156] Review Request: jsonassert - JUnit extension to write JSON unit tests
https://bugzilla.redhat.com/show_bug.cgi?id=1390156 --- Comment #8 from Jon Ciesla --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/jsonassert -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1390156] Review Request: jsonassert - JUnit extension to write JSON unit tests
https://bugzilla.redhat.com/show_bug.cgi?id=1390156 gil cattaneo changed: What|Removed |Added Blocks|652183 (FE-JAVASIG) | Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=652183 [Bug 652183] Java SIG tracker bug -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1390156] Review Request: jsonassert - JUnit extension to write JSON unit tests
https://bugzilla.redhat.com/show_bug.cgi?id=1390156 --- Comment #7 from gil cattaneo --- create new SCM request/s: https://admin.fedoraproject.org/pkgdb/package/requests/8588 https://admin.fedoraproject.org/pkgdb/package/requests/8589 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1390156] Review Request: jsonassert - JUnit extension to write JSON unit tests
https://bugzilla.redhat.com/show_bug.cgi?id=1390156 gil cattaneo changed: What|Removed |Added Assignee|nob...@fedoraproject.org|rjo...@redhat.com -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1390156] Review Request: jsonassert - JUnit extension to write JSON unit tests
https://bugzilla.redhat.com/show_bug.cgi?id=1390156 --- Comment #6 from gil cattaneo --- Thanks for the review! create new SCM request/s: https://admin.fedoraproject.org/pkgdb/package/requests/8586 https://admin.fedoraproject.org/pkgdb/package/requests/8587 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1390156] Review Request: jsonassert - JUnit extension to write JSON unit tests
https://bugzilla.redhat.com/show_bug.cgi?id=1390156 --- Comment #5 from gil cattaneo --- Please set the "Assigned To" field -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1390156] Review Request: jsonassert - JUnit extension to write JSON unit tests
https://bugzilla.redhat.com/show_bug.cgi?id=1390156 Richard W.M. Jones changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #4 from Richard W.M. Jones --- [x]: Fully versioned dependency in subpackages if applicable. ==> Packaged APPROVED by RWMJ. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1390156] Review Request: jsonassert - JUnit extension to write JSON unit tests
https://bugzilla.redhat.com/show_bug.cgi?id=1390156
gil cattaneo changed:
What|Removed |Added
Flags|needinfo?(puntogil@libero.i |
|t) |
--- Comment #3 from gil cattaneo ---
(In reply to Richard W.M. Jones from comment #1)
> Generic:
> [x]: Package is licensed with an open-source compatible license and meets
> other legal requirements as defined in the legal section of Packaging
> Guidelines.
> There is an upstream bug about the licensing, so most files are
> "unknown". However the main license file agrees with the package
> licensing.
>
> [x]: License field in the package spec file matches the actual license.
> Note: Checking patched sources after %prep for licenses. Licenses
> found: "Unknown or generated", "*No copyright* Apache (v2.0)". 36
> files have unknown license. Detailed output of licensecheck in
> /var/tmp/1390156-jsonassert/licensecheck.txt
> See above.
Open https://github.com/skyscreamer/JSONassert/issues/70 for this problem (and
also a PR), waiting upstream response ...
(In reply to Richard W.M. Jones from comment #2)
> Everything looks fine except for:
>
> [ ]: Fully versioned dependency in subpackages if applicable.
> Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
> jsonassert-javadoc
>
> Could you check if this is a problem or not? I have no idea.
This a "noarch" package. and use the _isa notation, in this case, that not make
sense
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1390156] Review Request: jsonassert - JUnit extension to write JSON unit tests
https://bugzilla.redhat.com/show_bug.cgi?id=1390156
Richard W.M. Jones changed:
What|Removed |Added
CC||punto...@libero.it
Flags||needinfo?(puntogil@libero.i
||t)
--- Comment #2 from Richard W.M. Jones ---
Everything looks fine except for:
[ ]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
jsonassert-javadoc
Could you check if this is a problem or not? I have no idea.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1390156] Review Request: jsonassert - JUnit extension to write JSON unit tests
https://bugzilla.redhat.com/show_bug.cgi?id=1390156
--- Comment #1 from Richard W.M. Jones ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
There is an upstream bug about the licensing, so most files are
"unknown". However the main license file agrees with the package
licensing.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "*No copyright* Apache (v2.0)". 36
files have unknown license. Detailed output of licensecheck in
/var/tmp/1390156-jsonassert/licensecheck.txt
See above.
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
Sources are all java files, so looks fine.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
It's not a Java library but a "JUnit extension", and the name is the
same as upstream, so it seems legit.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[-]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 2 files.
Javadoc subpackage actually, but this is OK.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Java:
[x]: Bundled jar/class files should be removed before build
[x]: Packages have proper BuildRequires/Requires on jpackage-utils
Note: Maven packages do not need to (Build)Require jpackage-utils. It
is pulled in by maven-local
[x]: Javadoc documentation files are generated and included in -javadoc
subpackage
[x]: Javadoc subpackages should not have Requires: jpackage-utils
[x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink)
Maven:
[x]: If package contains pom.xml files install it (including metadata) even
when building with ant
It has a jsonassert.pom file which is installed. It builds using
maven not ant.
[x]: POM files have correct Maven mapping
[x]: Maven packages should use new style packaging
[x]: Old add_to_maven_depmap macro is not being used
[x]: Packages DO NOT have Requires(post) and Requires(postun) on jpackage-
utils for %update_maven_depmap macro
[x]: Package DOES NOT use %update_maven_depmap in %post/%postun
[x]: Packages use .mfiles file list instead of %{_datadir
[Bug 1390156] Review Request: jsonassert - JUnit extension to write JSON unit tests
https://bugzilla.redhat.com/show_bug.cgi?id=1390156 Richard W.M. Jones changed: What|Removed |Added Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1390156] Review Request: jsonassert - JUnit extension to write JSON unit tests
https://bugzilla.redhat.com/show_bug.cgi?id=1390156 Richard W.M. Jones changed: What|Removed |Added Status|NEW |ASSIGNED CC||rjo...@redhat.com -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1390156] Review Request: jsonassert - JUnit extension to write JSON unit tests
https://bugzilla.redhat.com/show_bug.cgi?id=1390156 gil cattaneo changed: What|Removed |Added Blocks||652183 (FE-JAVASIG) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=652183 [Bug 652183] Java SIG tracker bug -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1390156] Review Request: jsonassert - JUnit extension to write JSON unit tests
https://bugzilla.redhat.com/show_bug.cgi?id=1390156 gil cattaneo changed: What|Removed |Added Blocks||1363923 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1363923 [Bug 1363923] Review Request: springframework4 - Spring Java Application Framework -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
