[Bug 1394147] Review Request: mpg123 - mp3 audio playback library

2017-12-26 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1394147

Yaakov Selkowitz  changed:

   What|Removed |Added

 Blocks||1529207




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1529207
[Bug 1529207] Enable MP3 support in arts
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1394147] Review Request: mpg123 - mp3 audio playback library

2016-11-23 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1394147

Yaakov Selkowitz  changed:

   What|Removed |Added

 Blocks||1395711




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1395711
[Bug 1395711] wine - enable support for mp3
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1394147] Review Request: mpg123 - mp3 audio playback library

2016-11-19 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1394147

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-11-19 16:16:58



--- Comment #23 from Fedora Update System  ---
mpg123-1.23.8-3.fc25 has been pushed to the Fedora 25 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1394147] Review Request: mpg123 - mp3 audio playback library

2016-11-16 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1394147

Yaakov Selkowitz  changed:

   What|Removed |Added

 Blocks||1395861




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1395861
[Bug 1395861] Enable MPG123 plugin
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1394147] Review Request: mpg123 - mp3 audio playback library

2016-11-13 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1394147

Yaakov Selkowitz  changed:

   What|Removed |Added

 Blocks||1394148




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1394148
[Bug 1394148] Review Request: gstreamer1-plugin-mpg123 - GStreamer mp3
playback plugin
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1394147] Review Request: mpg123 - mp3 audio playback library

2016-11-13 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1394147

Yaakov Selkowitz  changed:

   What|Removed |Added

 Blocks||1394582




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1394582
[Bug 1394582] MP3 support can now be enabled
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1394147] Review Request: mpg123 - mp3 audio playback library

2016-11-13 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1394147

Nicolas Chauvet (kwizart)  changed:

   What|Removed |Added

 CC||kwiz...@gmail.com



--- Comment #22 from Nicolas Chauvet (kwizart)  ---
I don't get why Supplements is relevant here ?
You will get mpg123-plugins-pulseaudio as soon as you get pulseaudio. Even if
you don't have mpg123. Same for portaudio.

thx for moving the package here.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1394147] Review Request: mpg123 - mp3 audio playback library

2016-11-12 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1394147

Neal Gompa  changed:

   What|Removed |Added

 Blocks|182235 (FE-Legal)   |



--- Comment #21 from Neal Gompa  ---
This has already been approved by Fedora Legal.


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=182235
[Bug 182235] Fedora Legal Tracker
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1394147] Review Request: mpg123 - mp3 audio playback library

2016-11-12 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1394147

Peter Lemenkov  changed:

   What|Removed |Added

 Blocks||182235 (FE-Legal)
 CC||magnus.tuomi...@gmail.com



--- Comment #20 from Peter Lemenkov  ---
*** Bug 625481 has been marked as a duplicate of this bug. ***


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=182235
[Bug 182235] Fedora Legal Tracker
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1394147] Review Request: mpg123 - mp3 audio playback library

2016-11-12 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1394147

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #19 from Fedora Update System  ---
mpg123-1.23.8-3.fc25 has been pushed to the Fedora 25 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-dec08a99bd

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1394147] Review Request: mpg123 - mp3 audio playback library

2016-11-12 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1394147

Greg Bailey  changed:

   What|Removed |Added

 CC||gbai...@lxpro.com



--- Comment #18 from Greg Bailey  ---
Do you have any plans to build this for other branches?

I would be interested in an EPEL7 build, and am willing to help comaintain it
if you're interested.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1394147] Review Request: mpg123 - mp3 audio playback library

2016-11-12 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1394147



--- Comment #17 from Neal Gompa  ---
(In reply to Igor Gnatenko from comment #16)
> (In reply to Neal Gompa from comment #3)
> > @Wim:
> > 
> > Unless the situation has changed recently, you cannot use rich dependencies
> > in Requires, Recommends, or Conflicts until Fedora release engineering tools
> > are updated to handle this without breaking.
> In Recommends you can use it fine.

No, you cannot use them in Recommends because Yum was adapted to read them, so
now that it doesn't ignore them, everything breaks when you put rich
dependencies in them.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1394147] Review Request: mpg123 - mp3 audio playback library

2016-11-12 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1394147



--- Comment #16 from Igor Gnatenko  ---
(In reply to Neal Gompa from comment #3)
> @Wim:
> 
> Unless the situation has changed recently, you cannot use rich dependencies
> in Requires, Recommends, or Conflicts until Fedora release engineering tools
> are updated to handle this without breaking.
In Recommends you can use it fine.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1394147] Review Request: mpg123 - mp3 audio playback library

2016-11-11 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1394147



--- Comment #15 from Fedora Update System  ---
mpg123-1.23.8-3.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-dec08a99bd

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1394147] Review Request: mpg123 - mp3 audio playback library

2016-11-11 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1394147

Fedora Update System  changed:

   What|Removed |Added

 Status|NEW |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1394147] Review Request: mpg123 - mp3 audio playback library

2016-11-11 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1394147



--- Comment #14 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/mpg123

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1394147] Review Request: mpg123 - mp3 audio playback library

2016-11-11 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1394147

Matthew Miller  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #13 from Matthew Miller  ---
Looks great to me. Review accepted.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1394147] Review Request: mpg123 - mp3 audio playback library

2016-11-11 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1394147



--- Comment #12 from Wim Taymans  ---
Updated files with Obsoletes: -lib-devel

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1394147] Review Request: mpg123 - mp3 audio playback library

2016-11-11 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1394147



--- Comment #11 from Wim Taymans  ---
Updated files:

https://people.freedesktop.org/~wtay/SPECS/mpg123.spec
https://people.freedesktop.org/~wtay/SRPMS/mpg123-1.23.8-3.fc24.src.rpm

Also:

https://people.freedesktop.org/~wtay/SPECS/gstreamer1-plugin-mpg123.spec
https://people.freedesktop.org/~wtay/SRPMS/gstreamer1-plugin-mpg123-1.10.0-3.fc24.src.rpm

because -libs-devel -> -devel

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1394147] Review Request: mpg123 - mp3 audio playback library

2016-11-11 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1394147



--- Comment #10 from Matthew Miller  ---
Neal, do you think the devel package name is a hard blocker? I agree it would e
more consistent. I guess we can do taht with another provides/obsoletes on the
existing (slightly odd) name as there is for libmpg123-devel.

Wim, can you fix the "Plulseaudio" typo while we're at it?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1394147] Review Request: mpg123 - mp3 audio playback library

2016-11-11 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1394147



--- Comment #9 from Neal Gompa  ---
The Enhances is pointless, so remove them. You already have a hard Requires on
it anyway.

The Supplements look good to me.

Please don't name devel subpackages "libs-devel". That's just asking for
trouble because it's inconsistent with how we generally name development
subpackages. Please change it to "mpg123-devel".

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1394147] Review Request: mpg123 - mp3 audio playback library

2016-11-11 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1394147



--- Comment #8 from Matthew Miller  ---
Neal (or someone) can you comment on the Enhances/Supplements in the updated
package?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1394147] Review Request: mpg123 - mp3 audio playback library

2016-11-11 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1394147

Wim Taymans  changed:

   What|Removed |Added

 CC||wtaym...@redhat.com



--- Comment #7 from Wim Taymans  ---
Updated files:

https://people.freedesktop.org/~wtay/SPECS/mpg123.spec
https://people.freedesktop.org/~wtay/SRPMS/mpg123-1.23.8-2.fc24.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1394147] Review Request: mpg123 - mp3 audio playback library

2016-11-11 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1394147



--- Comment #6 from Matthew Miller  ---
Thanks Neal — good catch. Wim, can you fix that?
https://fedoraproject.org/wiki/Packaging:Guidelines#Rich.2FBoolean_dependencies

Otherwise, this looks good to me -- I ran fedora-review and the only issues it
shows are due to it being somewhat confused about the devel package being
mpg123-libs-devel instead of mpg123-devel. I don't *think* this is an actual
problem.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1394147] Review Request: mpg123 - mp3 audio playback library

2016-11-11 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1394147



--- Comment #5 from Matthew Miller  ---
Also not a blocker, but there are obsolete m4 macros used in autotools. See
https://fedorahosted.org/FedoraReview/wiki/AutoTools

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1394147] Review Request: mpg123 - mp3 audio playback library

2016-11-11 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1394147

Neal Gompa  changed:

   What|Removed |Added

   Assignee|ngomp...@gmail.com  |mat...@redhat.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1394147] Review Request: mpg123 - mp3 audio playback library

2016-11-11 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1394147

Neal Gompa  changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|ngomp...@gmail.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1394147] Review Request: mpg123 - mp3 audio playback library

2016-11-11 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1394147



--- Comment #4 from Neal Gompa  ---
If it is in fact still the case, you can just flip the relationship to
"Supplements" with rich deps in each of the plugin packages. That will work the
same way and tools like Koji, Bodhi, pungi, and mash won't choke.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1394147] Review Request: mpg123 - mp3 audio playback library

2016-11-11 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1394147

Neal Gompa  changed:

   What|Removed |Added

 CC||den...@ausil.us,
   ||ngomp...@gmail.com



--- Comment #3 from Neal Gompa  ---
@Wim:

Unless the situation has changed recently, you cannot use rich dependencies in
Requires, Recommends, or Conflicts until Fedora release engineering tools are
updated to handle this without breaking.

CC'ing Dennis Gilmore, who can confirm whether this is still true.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1394147] Review Request: mpg123 - mp3 audio playback library

2016-11-11 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1394147

Matthias Runge  changed:

   What|Removed |Added

 CC||mru...@redhat.com



--- Comment #2 from Matthias Runge  ---
nit: typo in plugins-p(l)ulseaudio subpackage.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1394147] Review Request: mpg123 - mp3 audio playback library

2016-11-11 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1394147



--- Comment #1 from Matthew Miller  ---
Not a blocker, but I'm curious about the plugin Recommends:. I have a default
Fedora Workstation setup which of course uses pulseaudio. I installed the base
rpm and libs but not the plugin, and the command-line tool plays back just fine
— what does the plugin gain me?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1394147] Review Request: mpg123 - mp3 audio playback library

2016-11-11 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1394147

Matthew Miller  changed:

   What|Removed |Added

 CC||mat...@redhat.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org