[Bug 1394952] Review Request: python-avocado - Framework with tools and libraries for Automated Testing

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394952



--- Comment #16 from Fedora Update System  ---
python-aexpect-1.2.0-3.20161110gitaca459d.fc24, python-avocado-43.0-6.fc24 has
been pushed to the Fedora 24 stable repository. If problems still persist,
please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394952] Review Request: python-avocado - Framework with tools and libraries for Automated Testing

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394952

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-12-05 16:41:18



--- Comment #15 from Fedora Update System  ---
python-aexpect-1.2.0-3.20161110gitaca459d.fc25, python-avocado-43.0-6.fc25 has
been pushed to the Fedora 25 stable repository. If problems still persist,
please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394952] Review Request: python-avocado - Framework with tools and libraries for Automated Testing

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394952



--- Comment #14 from Fedora Update System  ---
python-aexpect-1.2.0-3.20161110gitaca459d.fc25, python-avocado-43.0-6.fc25 has
been pushed to the Fedora 25 testing repository. If problems still persist,
please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-c7b80aa595

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394952] Review Request: python-avocado - Framework with tools and libraries for Automated Testing

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394952

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #13 from Fedora Update System  ---
python-aexpect-1.2.0-3.20161110gitaca459d.fc24, python-avocado-43.0-6.fc24 has
been pushed to the Fedora 24 testing repository. If problems still persist,
please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-2054c2c43c

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394952] Review Request: python-avocado - Framework with tools and libraries for Automated Testing

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394952



--- Comment #12 from Fedora Update System  ---
python-aexpect-1.2.0-3.20161110gitaca459d.fc24 python-avocado-43.0-6.fc24 has
been submitted as an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-2054c2c43c

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394952] Review Request: python-avocado - Framework with tools and libraries for Automated Testing

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394952



--- Comment #11 from Fedora Update System  ---
python-aexpect-1.2.0-3.20161110gitaca459d.fc25 python-avocado-43.0-6.fc25 has
been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-c7b80aa595

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394952] Review Request: python-avocado - Framework with tools and libraries for Automated Testing

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394952

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394952] Review Request: python-avocado - Framework with tools and libraries for Automated Testing

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394952



--- Comment #10 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/python-avocado

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394952] Review Request: python-avocado - Framework with tools and libraries for Automated Testing

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394952

Stephen Gallagher  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #9 from Stephen Gallagher  ---
OK, I think this looks good to go. Approved!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394952] Review Request: python-avocado - Framework with tools and libraries for Automated Testing

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394952

Merlin Mathesius  changed:

   What|Removed |Added

  Flags|needinfo?(mmathesi@redhat.c |
   |om) |



--- Comment #8 from Merlin Mathesius  ---
Thank you for the additional detailed feedback.

According to description of the following commit in the upstream repository, it
is intended that users can customize the %config files in
%{_sysconfdir}/avocado/sysinfo:

   
https://github.com/avocado-framework/avocado/commit/0a6dc703252cd2405b5251ecebfc545a587ef4c8

Updates have been made to address the rest of your review concerns.

Spec URL: https://merlinm.fedorapeople.org/python-avocado.spec
SRPM URL: https://merlinm.fedorapeople.org/python-avocado-43.0-6.fc24.src.rpm
COPR build URL:
https://copr.fedorainfracloud.org/coprs/merlinm/avocado/build/479732/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394952] Review Request: python-avocado - Framework with tools and libraries for Automated Testing

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394952

Stephen Gallagher  changed:

   What|Removed |Added

  Flags||needinfo?(mmathesi@redhat.c
   ||om)



--- Comment #7 from Stephen Gallagher  ---
I have just a few remaining comments at this point:

- Please put a space after %config(noreplace), for readability. It looks like
part of the path, which it is not.

- %config(noreplace)%{_sysconfdir}/avocado/conf.d/README, %config(noreplace)
{_sysconfdir}/avocado/scripts/job/pre.d/README and
%config(noreplace)%{_sysconfdir}/avocado/scripts/job/post.d/README should not
be %config(noreplace). They shouldn't be edited by the end-user and as such we
want changes to them clobbered on update.

- Are %config(noreplace)%{_sysconfdir}/avocado/sysinfo/commands,
%config(noreplace)%{_sysconfdir}/avocado/sysinfo/files and
%config(noreplace)%{_sysconfdir}/avocado/sysinfo/profilers supposed to be
editable by the end-user? If they're not *really* config files, they should not
be %config(noreplace) (also, it would be best if upstream moved them to
/usr/share if they're truly supposed to be immutable).

- Please remove the executable bit from all python files in %doc.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394952] Review Request: python-avocado - Framework with tools and libraries for Automated Testing

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394952

Merlin Mathesius  changed:

   What|Removed |Added

  Flags|needinfo?(mmathesi@redhat.c |
   |om) |



--- Comment #6 from Merlin Mathesius  ---
Updated to (hopefully) address all review concerns.

Spec URL: https://merlinm.fedorapeople.org/python-avocado.spec
SRPM URL: https://merlinm.fedorapeople.org/python-avocado-43.0-5.fc24.src.rpm
COPR build URLs:
https://copr.fedorainfracloud.org/coprs/merlinm/avocado/build/479689/ and
(because fedora-rawhide-x86_64 build mysteriously failed on the first try)
https://copr.fedorainfracloud.org/coprs/merlinm/avocado/build/479690/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394952] Review Request: python-avocado - Framework with tools and libraries for Automated Testing

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394952

Stephen Gallagher  changed:

   What|Removed |Added

 CC||mmath...@redhat.com
  Flags||needinfo?(mmathesi@redhat.c
   ||om)



--- Comment #5 from Stephen Gallagher  ---

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed

= Issues =

* License: field only describes GPLv2, but the licensecheck shows MIT
  license as well. Please also check whether GPLv2 or GPLv2+ is correct.

* Requires for the main package should be for python2-%{srcname}, not
  python-%{srcname}

* Requires for subpackages on the main package must be fully versioned. e.g.:
  Requires: python2-%{srcname} == %{version}-%{release}
  This is to ensure that if a user runs `dnf update python2-avocado`, they are
  guaranteed to get the subpackage built together with it. If there is a
  special reason this should not happen, it needs to be in a comment in the
  spec file.

* Package uses but does not own /usr/share/avocado, /usr/share/doc/avocado,
  /etc/avocado/scripts/job, /etc/avocado/scripts, /usr/libexec/avocado

* The BuildRequires should use the python2-foo variant of the Requires, since
  the package does not support python3. The unversioned python-foo Requires is
  now reserved for packages that can switch between them (so that in the future
  the %{python_provides} macro will change which version supplies the
  unversioned name.

* The python2-avocado-plugins-output-html subpackage bundles a
  font, glyphicons-halflings-regular. This does not appear to be actually
  freely licensed for use in Fedora. Glyphicons.com appears to charge for this
  font, though it is available "for free" (no license specified) if installed
  through bootstrap (which this package does not use). See
  http://getbootstrap.com/components/#glyphicons for the line "Glyphicons
  Halflings are normally not available for free, but their creator has made
them
  available for Bootstrap free of cost.

  Unfortunately, "free of cost" is not the same thing as "freely
distributable".

  This needs to be discussed with upstream urgently.

* The python-avocado-examples subpackage needs to put all of its contents into
  the %{_docdir} hierarchy rather than %{python2_sitelib}. They are not runtime
  contents.

= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[!]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "GPL", "GPL (v2 or later)", "Unknown or generated", "*No
 copyright* GPL", "MIT/X11 (BSD like)", "*No copyright* GPL (v2 or
 later)", "GPL (v2)". 253 files have unknown license. Detailed output
 of licensecheck in /home/sgallagh/1394952-python-
 avocado/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[!]: Package requires other packages for directories it uses.
 Note: No known owner of /usr/share/avocado, /usr/share/doc/avocado,
 /etc/avocado/scripts/job, /etc/avocado/scripts, /usr/libexec/avocado
[!]: Package must own all directories that it creates.
 Note: Directories without known owners: /etc/avocado/scripts/job,
 /etc/avocado/scripts, /usr/share/doc/avocado, /usr/libexec/avocado,
 /usr/share/avocado
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[!]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 40960 bytes in 3 files.
[!]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.

[Bug 1394952] Review Request: python-avocado - Framework with tools and libraries for Automated Testing

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394952



--- Comment #4 from Merlin Mathesius  ---
After looking through the avocado selftests, there appear to be many more
potential race conditions that may randomly cause build failures. Thus, the
selftests have been commented out with a note about the situation. The patches
for the selftests have also been removed, since they are no longer relevant.

An upstream issue has been raised:
https://github.com/avocado-framework/avocado/issues/1619

Spec URL: https://merlinm.fedorapeople.org/python-avocado.spec
SRPM URL: https://merlinm.fedorapeople.org/python-avocado-43.0-4.fc24.src.rpm
COPR build URL:
https://copr.fedoraproject.org/coprs/merlinm/avocado/build/477928/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394952] Review Request: python-avocado - Framework with tools and libraries for Automated Testing

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394952



--- Comment #3 from Stephen Gallagher  ---
Created attachment 1221004
  --> https://bugzilla.redhat.com/attachment.cgi?id=1221004=edit
Mock failure during fedora-review of python-avocado-43.0-3

This is still failing to build intermittently in mock. See attachment.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394952] Review Request: python-avocado - Framework with tools and libraries for Automated Testing

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394952



--- Comment #2 from Merlin Mathesius  ---
Updated with additional patch to skip buggy selftest causing builds to
occasionally fail as discussed in #fedora-modularity.

Spec URL: https://merlinm.fedorapeople.org/python-avocado.spec
SRPM URL: https://merlinm.fedorapeople.org/python-avocado-43.0-3.fc24.src.rpm
COPR build URL:
https://copr.fedoraproject.org/coprs/merlinm/avocado/build/477093/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394952] Review Request: python-avocado - Framework with tools and libraries for Automated Testing

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394952



--- Comment #1 from Merlin Mathesius  ---
Updates made based on comments and discussions in #fedora-modularity.

Spec URL: https://merlinm.fedorapeople.org/python-avocado.spec
SRPM URL: https://merlinm.fedorapeople.org/python-avocado-43.0-2.fc24.src.rpm
COPR build URL:
https://copr.fedorainfracloud.org/coprs/merlinm/avocado/build/476977/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394952] Review Request: python-avocado - Framework with tools and libraries for Automated Testing

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394952

Stephen Gallagher  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||sgall...@redhat.com
   Assignee|nob...@fedoraproject.org|sgall...@redhat.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org