[Bug 1395804] Review Request: python-batinfo - A Python module to retrieve battery information

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1395804



--- Comment #15 from Fedora Update System  ---
python-batinfo-0.4.2-2.fc25 has been pushed to the Fedora 25 stable repository.
If problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1395804] Review Request: python-batinfo - A Python module to retrieve battery information

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1395804

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-12-27 00:18:12



--- Comment #14 from Fedora Update System  ---
python-batinfo-0.4.2-2.fc25 has been pushed to the Fedora 25 stable repository.
If problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1395804] Review Request: python-batinfo - A Python module to retrieve battery information

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1395804

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #13 from Fedora Update System  ---
python-batinfo-0.4.2-2.fc25 has been pushed to the Fedora 25 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-6374c6c6ce

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1395804] Review Request: python-batinfo - A Python module to retrieve battery information

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1395804



--- Comment #12 from Fedora Update System  ---
python-batinfo-0.4.2-2.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-6374c6c6ce

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1395804] Review Request: python-batinfo - A Python module to retrieve battery information

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1395804

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1395804] Review Request: python-batinfo - A Python module to retrieve battery information

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1395804



--- Comment #11 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/python-batinfo

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1395804] Review Request: python-batinfo - A Python module to retrieve battery information

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1395804

Iryna Shcherbina  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #10 from Iryna Shcherbina  ---
(In reply to Fabian Affolter from comment #9)

> Sorry, didn't publish the new stuff.

Thank you for the update.

Package approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1395804] Review Request: python-batinfo - A Python module to retrieve battery information

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1395804

Fabian Affolter  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
  Alias||python-batinfo



--- Comment #9 from Fabian Affolter  ---
(In reply to Iryna Shcherbina from comment #7)
> Please make sure to add the %check section with the next release when the
> issue is resolved.

Upstream is pretty responsive. I guess that with the PR for the tests in place
it will not take long.

> Also the spec file [0] does not reflect the %description change yet, so
> please push the change. Other than that, I approve the package.

Sorry, didn't publish the new stuff.

Updated files:
Spec URL: https://fab.fedorapeople.org/packages/SRPMS/python-batinfo.spec
SRPM URL:
https://fab.fedorapeople.org/packages/SRPMS/python-batinfo-0.4.2-2.fc24.src.rpm

(In reply to Iryna Shcherbina from comment #8)
> I would like to add, that I have been sponsored and now I can approve
> packages.

Congratulations :-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1395804] Review Request: python-batinfo - A Python module to retrieve battery information

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1395804

Iryna Shcherbina  changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|ishch...@redhat.com
  Flags||fedora-review?



--- Comment #8 from Iryna Shcherbina  ---
I would like to add, that I have been sponsored and now I can approve packages.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1395804] Review Request: python-batinfo - A Python module to retrieve battery information

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1395804



--- Comment #7 from Iryna Shcherbina  ---
Hi Fabian,

Thank you for creating the issue and for your responses.

Please make sure to add the %check section with the next release when the issue
is resolved.

Also the spec file [0] does not reflect the %description change yet, so please
push the change. Other than that, I approve the package.

[0] https://fab.fedorapeople.org/packages/SRPMS/python-batinfo.spec

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1395804] Review Request: python-batinfo - A Python module to retrieve battery information

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1395804



--- Comment #6 from Fabian Affolter  ---
i meant: No Py3 on EPEL.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1395804] Review Request: python-batinfo - A Python module to retrieve battery information

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1395804



--- Comment #5 from Fabian Affolter  ---
(In reply to Iryna Shcherbina from comment #3)
> The spec file looks good to me, but I would suggest to do another small
> change.
> The %description is missing one sentence comparing to the one in package
> documentation and therefore seems incomplete.
> Please change it to the original one:
> 
> A simple Python module to retrieve battery information on Linux-based
> operating system. No ACPI or external software is needed. Only the Linux
> kernel and its /sys/class/power_supply folder.

Changed

> Also, could you please explain to me why you define the following:
> 
> > %if 0%{?fedora}
> > %bcond_without python3
> > %else
> > %bcond_with python3
> > %endif

Needed to build the package for EPEL as there is Py3. 

(In reply to Iryna Shcherbina from comment #4)
> Another thing is that batinfo contains tests, they are just 
> not included into the tarball:
> 
> https://github.com/nicolargo/batinfo/blob/master/test_batinfo.py
> 
> You should either get the tests from github or create an issue to include
> them, and run them in %check section.

https://github.com/nicolargo/batinfo/issues/12

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1395804] Review Request: python-batinfo - A Python module to retrieve battery information

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1395804



--- Comment #4 from Iryna Shcherbina  ---
Hi Fabian,

Another thing is that batinfo contains tests, they are just 
not included into the tarball:

https://github.com/nicolargo/batinfo/blob/master/test_batinfo.py

You should either get the tests from github or create an issue to include them,
and run them in %check section.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1395804] Review Request: python-batinfo - A Python module to retrieve battery information

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1395804

Iryna Shcherbina  changed:

   What|Removed |Added

 CC||mhron...@redhat.com



--- Comment #3 from Iryna Shcherbina  ---
Hello Fabian,

thank you for the changes.

The spec file looks good to me, but I would suggest to do another small change.
The %description is missing one sentence comparing to the one in package
documentation and therefore seems incomplete.
Please change it to the original one:

A simple Python module to retrieve battery information on Linux-based operating
system. No ACPI or external software is needed. Only the Linux kernel and its
/sys/class/power_supply folder.

Also, could you please explain to me why you define the following:

> %if 0%{?fedora}
> %bcond_without python3
> %else
> %bcond_with python3
> %endif


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated


= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[x]: Package should 

[Bug 1395804] Review Request: python-batinfo - A Python module to retrieve battery information

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1395804



--- Comment #2 from Fabian Affolter  ---
Thanks for your feedback.

(In reply to Iryna Shcherbina from comment #1)
> * there is a new version of the package 0.4.2, which was released just
> yesterday

Yes, I know. I worked with upstream to get a couple of issues sorted out.
Shebang, license, and typos.

> * with the new release the license file is included in the tar, so please
> include it in %license

That was one issue.

> * please use %{srcname} macro in the URL

No, this adds no real value and make the URL very copy-&-paste unfriendly in
the spec file. I know that this is shown in the guidelines. If the project is
renamed or the orga changed then the URL needs to be modified anyways.

Updated files:
Spec URL: https://fab.fedorapeople.org/packages/SRPMS/python-batinfo.spec
SRPM URL:
https://fab.fedorapeople.org/packages/SRPMS/python-batinfo-0.4.2-1.fc24.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1395804] Review Request: python-batinfo - A Python module to retrieve battery information

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1395804

Iryna Shcherbina  changed:

   What|Removed |Added

 CC||ishch...@redhat.com



--- Comment #1 from Iryna Shcherbina  ---
Hello Fabian,

the spec file looks good, but I have a couple of comments:

* there is a new version of the package 0.4.2, which was released just
yesterday

* with the new release the license file is included in the tar, so please
include it in %license

* please use %{srcname} macro in the URL

It is an informal review, as I'm not sponsored yet, but I can continue with the
review when I am and when the updates are available.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org