[Bug 1398433] Review Request: granite - elementary GTK+ Development Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1398433

Neal Gompa  changed:

   What|Removed |Added

 Blocks||1512217
   ||(PantheonDesktopPackageRevi
   ||ews)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1512217
[Bug 1512217] Tracking: Pantheon Desktop related package review tracker
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1398433] Review Request: granite - elementary GTK+ Development Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1398433

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-12-31 17:20:38



--- Comment #19 from Fedora Update System  ---
granite-0.4.0.1-7.fc25 has been pushed to the Fedora 25 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1398433] Review Request: granite - elementary GTK+ Development Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1398433

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #18 from Fedora Update System  ---
granite-0.4.0.1-7.fc25 has been pushed to the Fedora 25 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-63beec8fa0

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1398433] Review Request: granite - elementary GTK+ Development Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1398433



--- Comment #17 from Fedora Update System  ---
granite-0.4.0.1-7.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-63beec8fa0

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1398433] Review Request: granite - elementary GTK+ Development Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1398433

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1398433] Review Request: granite - elementary GTK+ Development Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1398433



--- Comment #16 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/granite

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1398433] Review Request: granite - elementary GTK+ Development Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1398433

Neal Gompa  changed:

   What|Removed |Added

 Blocks|177841 (FE-NEEDSPONSOR) |



--- Comment #15 from Neal Gompa  ---
Fabio is now sponsored into the packager group.


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1398433] Review Request: granite - elementary GTK+ Development Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1398433



--- Comment #14 from Neal Gompa  ---
I am also sponsoring Fabio's entry as a packager.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1398433] Review Request: granite - elementary GTK+ Development Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1398433

Neal Gompa  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #13 from Neal Gompa  ---
My only nitpick is that I prefer to see the demo program in its own subpackage,
but that doesn't matter one way or another in this case.

Everything else looks good.

PACKAGE APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1398433] Review Request: granite - elementary GTK+ Development Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1398433



--- Comment #12 from Neal Gompa  ---
Gah... Slight revision:

[x]: gtk-update-icon-cache is invoked in %postun and %posttrans if package
 contains icons.
 Note: icons in granite

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1398433] Review Request: granite - elementary GTK+ Development Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1398433



--- Comment #11 from Neal Gompa  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated



= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Unknown or generated", "LGPL (v2 or later) (with incorrect FSF
 address)", "*No copyright* BSD (3 clause)", "LGPL (v3 or later) (with
 incorrect FSF address)", "LGPL (v3 or later)", "BSD (2 clause)". 110
 files have unknown license. Detailed output of licensecheck in
 /home/makerpm/1398433-granite/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[-]: Package requires other packages for directories it uses.
 Note: No known owner of /usr/share/locale/rue, /usr/share/locale/ckb,
 /usr/share/locale/rue/LC_MESSAGES, /usr/share/locale/ckb/LC_MESSAGES
[-]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/share/locale/ckb,
 /usr/share/locale/rue/LC_MESSAGES, /usr/share/locale/rue,
 /usr/share/locale/ckb/LC_MESSAGES
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: The spec file handles locales properly.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: gtk-update-icon-cache is invoked in %postun and %posttrans if package
 contains icons.
 Note: icons in granite
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 20480 bytes in 3 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
 desktop-file-validate if there is such a file.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[x]: If the source package does not include license text(s) as a separate
 file from 

[Bug 1398433] Review Request: granite - elementary GTK+ Development Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1398433

Neal Gompa  changed:

   What|Removed |Added

  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1398433] Review Request: granite - elementary GTK+ Development Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1398433

Neal Gompa  changed:

   What|Removed |Added

   Assignee|domi...@greysector.net  |ngomp...@gmail.com
  Flags|fedora-review?  |
   |needinfo?(dominik@greysecto |
   |r.net)  |



--- Comment #10 from Neal Gompa  ---
Since there's been no response from the reviewer in almost a month, I will take
over this review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1398433] Review Request: granite - elementary GTK+ Development Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1398433

Neal Gompa  changed:

   What|Removed |Added

 CC||domi...@greysector.net,
   ||ngomp...@gmail.com
  Flags||needinfo?(dominik@greysecto
   ||r.net)



--- Comment #9 from Neal Gompa  ---
@Rathann:

Are you still working on this review?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1398433] Review Request: granite - elementary GTK+ Development Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1398433



--- Comment #8 from Fabio Valentini  ---
Pinging reviewer.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1398433] Review Request: granite - elementary GTK+ Development Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1398433

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 Blocks||1068850 (Pantheon)
 CC||whe...@redhat.com



--- Comment #7 from Zbigniew Jędrzejewski-Szmek  ---
*** Bug 1103545 has been marked as a duplicate of this bug. ***


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1068850
[Bug 1068850] Fedora 22 Change "Pantheon Desktop" tracker
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1398433] Review Request: granite - elementary GTK+ Development Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1398433



--- Comment #6 from Fabio Valentini  ---
The rpmlint messages for the translations are:

granite.x86_64: E: invalid-lc-messages-dir
/usr/share/locale/bh/LC_MESSAGES/granite.mo
granite.x86_64: E: invalid-lc-messages-dir
/usr/share/locale/mo/LC_MESSAGES/granite.mo

According to the rpmlint docs, this error message means:
Package installs localization files to /usr/share/locale/ subdirectory not
corresponding to any valid language

Maybe rpmlint is not up to snuff on all the latest language ISO code changes /
additions.

Most packages that use the launchpad.net translations system seem to have
(complete and incomplete) translations for many languages, including those two.


I fixed the remaining issues.

Spec URL:
https://raw.githubusercontent.com/decathorpe/fedora-packaging/9c815d50058135acf2e929039681bd8c0a2391c7/specs/granite.spec

SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/decathorpe/staging/fedora-rawhide-x86_64/00482632-granite/granite-0.4.0.1-7.fc26.src.rpm


Koji scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=16673377

COPR build for f25 and rawhide:
https://copr.fedorainfracloud.org/coprs/decathorpe/staging/build/482632/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1398433] Review Request: granite - elementary GTK+ Development Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1398433



--- Comment #5 from Dominik 'Rathann' Mierzejewski  ---
(In reply to Fabio Valentini from comment #4)
> 1. The icons are used by GTK+ widgets in the library, not (only) by the demo
> application, so they are in the right place (and the scriptlets and
> Requires: too).

OK. A short comment in the spec file could be useful for future or drive-by
maintainers.

> 2. rpmlint complains that those 2 languages (bh: Bihari and mo: Moldovian)
> are not recognised and looking at the languages fedora supports, they are
> not in the list. The reviewer of the old granite package review also wanted
> translations for an unsupported language to be removed, so I thought this
> was the usual practice.

rpmlint is not 100% Fedora Packaging Guidelines compliant (it's cross-distro,
after all), so its warnings are to be taken with a grain of salt. I do see both
bh and mo directories in /usr/share/locale, so I don't think there's any reason
to remove these translations. I'm not sure why rpmlint is saying they're
unsupported. Could you post the exact message?

> 3. The kentauros configuration file was included as (an unused and purely
> informational) Source1 in the older .spec file (remnant from my packaging
> scripts).

OK.

> 4. True.
> 
> 5. It seems so.
> 
> 
> My questions:
> ad 2: Should I keep translations for unsupported languages or remove them?

Please keep them.

> ad 3: Should I remove the changelog entry?

Yes, please.

> ad 4: I'll fix that
> ad 5: I'll fix that, too

Great!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1398433] Review Request: granite - elementary GTK+ Development Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1398433



--- Comment #4 from Fabio Valentini  ---
1. The icons are used by GTK+ widgets in the library, not (only) by the demo
application, so they are in the right place (and the scriptlets and Requires:
too).

2. rpmlint complains that those 2 languages (bh: Bihari and mo: Moldovian) are
not recognised and looking at the languages fedora supports, they are not in
the list. The reviewer of the old granite package review also wanted
translations for an unsupported language to be removed, so I thought this was
the usual practice.

3. The kentauros configuration file was included as (an unused and purely
informational) Source1 in the older .spec file (remnant from my packaging
scripts).

4. True.

5. It seems so.


My questions:
ad 2: Should I keep translations for unsupported languages or remove them?
ad 3: Should I remove the changelog entry?
ad 4: I'll fix that
ad 5: I'll fix that, too

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1398433] Review Request: granite - elementary GTK+ Development Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1398433



--- Comment #3 from Dominik 'Rathann' Mierzejewski  ---
1. Why the icons and Requires: hicolor-icon-theme are there in the main package
if the demo application and the desktop file are in -devel? Consequently,
gtk-update-icon-cache calls should probably be moved to %post* devel, too.

2. Why are you removing these? The changelog entry does not explain.
rm -r %{buildroot}/%{_datadir}/locale/bh
rm -r %{buildroot}/%{_datadir}/locale/mo

3. There's a changelog entry "- Remove kentauros configuration file.", but I
don't see anything apart from the two locales being removed.

4. desktop-file-validate %{buildroot}/%{_datadir}/applications/*.desktop
*.desktop could be changed to granite-demo.desktop, since you're explicit in
the %files section already.

5. License: LGPLv3, but licensecheck says:
$ licensecheck -r . | cut -d: -f2 |sort -u
 BSD (2 clause)
 LGPL (v2 or later) (with incorrect FSF address)
 LGPL (v3 or later)
 LGPL (v3 or later) (with incorrect FSF address)
 *No copyright* BSD (3 clause)
 *No copyright* GENERATED FILE
 *No copyright* UNKNOWN
 UNKNOWN
So, it should probably be License: LGPLv3+.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1398433] Review Request: granite - elementary GTK+ Development Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1398433



--- Comment #2 from Fabio Valentini  ---
I corrected some things I forgot to include in / remove from the .spec file -
additionally, I fixed some issues that rpmlint pointed out to me.

Spec URL:
https://raw.githubusercontent.com/decathorpe/fedora-packaging/f04f79b1d6f8b83e6733757f6e9cc51686c19f4e/specs/granite.spec

SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/decathorpe/staging/fedora-rawhide-x86_64/00481789-granite/granite-0.4.0.1-6.fc26.src.rpm

A COPR build is available here:
https://copr.fedorainfracloud.org/coprs/decathorpe/staging/build/481789/

A koji scratch build is available here:
http://koji.fedoraproject.org/koji/taskinfo?taskID=16647475

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1398433] Review Request: granite - elementary GTK+ Development Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1398433

Dominik 'Rathann' Mierzejewski  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|domi...@greysector.net
  Flags||fedora-review?



--- Comment #1 from Dominik 'Rathann' Mierzejewski  ---
I'll take this review and sponsor Fabio once he completes a couple of
(non-binding) reviews.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1398433] Review Request: granite - elementary GTK+ Development Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1398433

Fabio Valentini  changed:

   What|Removed |Added

 Blocks||177841 (FE-NEEDSPONSOR)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org