[Bug 1401334] Review Request: python-utils - Python Utils is a module with some convenient utilities
https://bugzilla.redhat.com/show_bug.cgi?id=1401334 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed|2016-12-19 09:45:54 |2017-01-11 02:22:49 --- Comment #13 from Fedora Update System --- python-utils-2.0.1-2.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1401334] Review Request: python-utils - Python Utils is a module with some convenient utilities
https://bugzilla.redhat.com/show_bug.cgi?id=1401334 Fedora Update System changed: What|Removed |Added Status|CLOSED |ON_QA Resolution|RAWHIDE |--- Keywords||Reopened --- Comment #12 from Fedora Update System --- python-utils-2.0.1-2.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-ed61d2c137 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1401334] Review Request: python-utils - Python Utils is a module with some convenient utilities
https://bugzilla.redhat.com/show_bug.cgi?id=1401334 --- Comment #11 from Fedora Update System --- python-utils-2.0.1-2.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-ed61d2c137 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1401334] Review Request: python-utils - Python Utils is a module with some convenient utilities
https://bugzilla.redhat.com/show_bug.cgi?id=1401334 Miro Hrončok changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE Last Closed||2016-12-19 09:45:54 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1401334] Review Request: python-utils - Python Utils is a module with some convenient utilities
https://bugzilla.redhat.com/show_bug.cgi?id=1401334 --- Comment #10 from Jon Ciesla --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/python-utils -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1401334] Review Request: python-utils - Python Utils is a module with some convenient utilities
https://bugzilla.redhat.com/show_bug.cgi?id=1401334 --- Comment #9 from Miro Hrončok --- Thank you for the review. I'll build updated version once the package is added to pkgdb. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1401334] Review Request: python-utils - Python Utils is a module with some convenient utilities
https://bugzilla.redhat.com/show_bug.cgi?id=1401334
Randy Barlow changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #8 from Randy Barlow ---
I'm going to go ahead and pass your current package. I recommend updating to
2.0.1 and including that license file, but I don't believe that is required to
pass the review since the setup.py does state that the package is BSD.
Very clean spec file, nice work!
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[-]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
randy: Upstream now has a license file that should be included in the
next release.
[x]: License field in the package spec file matches the actual license.
Note: Cannot run licensecheck: Command 'licensecheck -r /var/lib/mock
/fedora-rawhide-x86_64/root/builddir/build/BUILD/python-utils-2.0.0'
returned non-zero exit status 255
randy: The license is expressed only in the setup.py as "BSD".
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 921600 bytes in 39 files.
randy: It's close to 1 MB, but I think it's OK ☺
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build
process.
[-]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep
= SHOULD items =
Generic:
[x]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
randy: Miro got upstream to do this, so it's OK.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[!]: Latest version is packaged.
randy: There is a 2.0.1 that has the license file. It would be good
to go ahead and package that one.
[x]: Package doe
[Bug 1401334] Review Request: python-utils - Python Utils is a module with some convenient utilities
https://bugzilla.redhat.com/show_bug.cgi?id=1401334 --- Comment #7 from Randy Barlow --- Miro, it looks like upstream made a 2.0.1 release that has the license file. You might want to package that one instead. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1401334] Review Request: python-utils - Python Utils is a module with some convenient utilities
https://bugzilla.redhat.com/show_bug.cgi?id=1401334 --- Comment #6 from Randy Barlow --- Thanks Miro, upstream responded quickly! Also I hadn't noticed the BSD in the setup.py. Since that is there, I think we can proceed and you can add the license file whenever upstream makes a release with it. Igor, I had thought it was a bit of a permanent failure since we needed upstream to do something, but it turned out I was wrong! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1401334] Review Request: python-utils - Python Utils is a module with some convenient utilities
https://bugzilla.redhat.com/show_bug.cgi?id=1401334 Igor Gnatenko changed: What|Removed |Added Flags|fedora-review- |fedora-review? --- Comment #5 from Igor Gnatenko --- Randy, fedora-review- is for packages which can't be fixed. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1401334] Review Request: python-utils - Python Utils is a module with some convenient utilities
https://bugzilla.redhat.com/show_bug.cgi?id=1401334 --- Comment #4 from Miro Hrončok --- Fixed: https://github.com/WoLpH/python-utils/blob/develop/LICENSE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1401334] Review Request: python-utils - Python Utils is a module with some convenient utilities
https://bugzilla.redhat.com/show_bug.cgi?id=1401334 --- Comment #3 from Miro Hrončok --- https://github.com/WoLpH/python-utils/issues/1 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1401334] Review Request: python-utils - Python Utils is a module with some convenient utilities
https://bugzilla.redhat.com/show_bug.cgi?id=1401334 --- Comment #2 from Miro Hrončok --- The setup.py contains this information: license='BSD', classifiers=['License :: OSI Approved :: BSD License'], I will talk to upstream to include the license text, but i would say it's not a blocker. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1401334] Review Request: python-utils - Python Utils is a module with some convenient utilities
https://bugzilla.redhat.com/show_bug.cgi?id=1401334 Randy Barlow changed: What|Removed |Added Flags|fedora-review? |fedora-review- --- Comment #1 from Randy Barlow --- Please correct me if I am mistaken, but the upstream project does not seem to have any license granted in it. If there is no license, Fedora cannot distribute the package. If I am incorrect, please feel free to show me the license. In the meantime, I recommend writing upstream to ask them to put a license file in the repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1401334] Review Request: python-utils - Python Utils is a module with some convenient utilities
https://bugzilla.redhat.com/show_bug.cgi?id=1401334 Randy Barlow changed: What|Removed |Added Status|NEW |ASSIGNED CC||ra...@electronsweatshop.com Assignee|nob...@fedoraproject.org|ra...@electronsweatshop.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1401334] Review Request: python-utils - Python Utils is a module with some convenient utilities
https://bugzilla.redhat.com/show_bug.cgi?id=1401334 Miro Hrončok changed: What|Removed |Added Blocks||1401335 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1401335 [Bug 1401335] Review Request: python-numpy-stl - Library to make reading, writing and modifying STL files -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
