[Bug 1402445] Review Request: myman - text mode videogame

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1402445

Raphael Groner  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed|2017-03-02 14:59:39 |2017-05-06 02:47:33



--- Comment #20 from Raphael Groner  ---
It seems bodhi missed to closed here.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1402445] Review Request: myman - text mode videogame

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1402445



--- Comment #19 from Fedora Update System  ---
myman-0.7.0-1.fc25 has been pushed to the Fedora 25 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1402445] Review Request: myman - text mode videogame

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1402445



--- Comment #18 from Fedora Update System  ---
myman-0.7.0-1.fc24 has been pushed to the Fedora 24 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1402445] Review Request: myman - text mode videogame

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1402445



--- Comment #17 from Fedora Update System  ---
myman-0.7.0-1.fc25 has been pushed to the Fedora 25 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-997f08f238

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1402445] Review Request: myman - text mode videogame

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1402445

Fedora Update System  changed:

   What|Removed |Added

 Status|CLOSED  |ON_QA
 Resolution|RAWHIDE |---
   Keywords||Reopened



--- Comment #16 from Fedora Update System  ---
myman-0.7.0-1.fc24 has been pushed to the Fedora 24 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-d5594bf58f

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1402445] Review Request: myman - text mode videogame

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1402445



--- Comment #15 from jiri vanek  ---
Thanx!

The bad builds I encountered are no longer valid. Maybe missing updates were
confusing koji?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1402445] Review Request: myman - text mode videogame

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1402445



--- Comment #14 from Jiří Vymazal  ---
as for the builds for f26/rawhide builds can be seen here:
https://apps.fedoraproject.org/packages/myman/builds/ 

or direct links - 
f26: https://koji.fedoraproject.org/koji/buildinfo?buildID=863746
rawhide(f27): https://koji.fedoraproject.org/koji/buildinfo?buildID=863737

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1402445] Review Request: myman - text mode videogame

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1402445



--- Comment #13 from Fedora Update System  ---
myman-0.7.0-1.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-997f08f238

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1402445] Review Request: myman - text mode videogame

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1402445



--- Comment #12 from Fedora Update System  ---
myman-0.7.0-1.fc24 has been submitted as an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-d5594bf58f

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1402445] Review Request: myman - text mode videogame

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1402445



--- Comment #11 from jiri vanek  ---
(In reply to Jiří Vymazal from comment #10)
> There are both rawhide and f26 builds available.
> I have originally done it only for Rawhide (26 at that time) as release is
> soon, but sure, can do update for older ones as well. Additional branches
> requested, will update once granted.

Can you please post links to the builds(and updates)? All builds I found have
permissions denied on downloading rpms, and I found no update.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1402445] Review Request: myman - text mode videogame

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1402445

Jiří Vymazal  changed:

   What|Removed |Added

  Flags|needinfo?(jvymazal@redhat.c |
   |om) |
   |needinfo?(projects.rg@smart |
   |.ms)|



--- Comment #10 from Jiří Vymazal  ---
There are both rawhide and f26 builds available.
I have originally done it only for Rawhide (26 at that time) as release is
soon, but sure, can do update for older ones as well. Additional branches
requested, will update once granted.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1402445] Review Request: myman - text mode videogame

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1402445

jiri vanek  changed:

   What|Removed |Added

  Flags||needinfo?(projects.rg@smart
   ||.ms)



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1402445] Review Request: myman - text mode videogame

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1402445

jiri vanek  changed:

   What|Removed |Added

 CC||jva...@redhat.com
  Flags||needinfo?(jvymazal@redhat.c
   ||om)



--- Comment #9 from jiri vanek  ---
(In reply to Raphael Groner from comment #8)
> Can we close here as there are some packages available in rawhide and f26?

Are there?-(


if so,  maybe do an update? ideally also for older fedoras?
Thanx!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1402445] Review Request: myman - text mode videogame

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1402445

Raphael Groner  changed:

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2017-03-02 14:59:39



--- Comment #8 from Raphael Groner  ---
Can we close here as there are some packages available in rawhide and f26?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1402445] Review Request: myman - text mode videogame

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1402445



--- Comment #7 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/myman

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1402445] Review Request: myman - text mode videogame

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1402445

Jiří Vymazal  changed:

   What|Removed |Added

  Flags|needinfo?(jvymazal@redhat.c |
   |om) |



--- Comment #6 from Jiří Vymazal  ---
Sorry for delay, thanks for needinfo flag, branches in PkgDB requested, and
updated pagure review with removed superfluous asterisk the error with not
owning /usr/share/ dir should now go away, also added the data sub-package and
fixed few other details

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1402445] Review Request: myman - text mode videogame

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1402445

Raphael Groner  changed:

   What|Removed |Added

 CC||jvyma...@redhat.com
  Flags||needinfo?(jvymazal@redhat.c
   ||om)



--- Comment #5 from Raphael Groner  ---
Ping? Any news here? Please request needed branches in PkgDB and build
packages.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1402445] Review Request: myman - text mode videogame

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1402445

Raphael Groner  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
  Flags|fedora-review?  |fedora-review+



--- Comment #4 from Raphael Groner  ---
APPROVED

I don't see any critical blocker that prevents from to fix the minor issues
noted below while importing.

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- If (and only if) the source package includes the text of the license(s)
  in its own file, then that file, containing the text of the license(s)
  for the package is included in %license.
  Note: License file COPYRIGHT is not marked as %license
  See:
  http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text
=> Ignore and I wouldn't even include that file. Same text as in LICENSE.

= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[-]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "MIT/X11 (BSD like)", "Public domain", "FSF All Permissive",
 "Unknown or generated", "*No copyright* Public domain". 636 files have
 unknown license. Detailed output of licensecheck in /home/builder
 /fedora-review/1402445-myman/licensecheck.txt
=> README clearly states MIT as the main license.

[x]: License file installed when any subpackage combination is installed.
[!]: Package requires other packages for directories it uses.
 Note: No known owner of /usr/share/myman
[!]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/share/myman
===> Add to %files.

[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[?]: Package uses nothing in %doc for runtime.
===> Remove INSTALL LICENSE and VERSION from %doc. They're are useless.

[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 184320 bytes in 11 files.
[?]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items 

[Bug 1402445] Review Request: myman - text mode videogame

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1402445



--- Comment #3 from Jiří Vymazal  ---
Thanks Raphael :)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1402445] Review Request: myman - text mode videogame

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1402445

Raphael Groner  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|projects...@smart.ms
  Flags||fedora-review?



--- Comment #2 from Raphael Groner  ---
Taken. :)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1402445] Review Request: myman - text mode videogame

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1402445

Raphael Groner  changed:

   What|Removed |Added

 Blocks||1364745 (FE-GAMESIG)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1364745
[Bug 1364745] Games SIG tracker bug
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1402445] Review Request: myman - text mode videogame

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1402445



--- Comment #1 from Raphael Groner  ---
Are you interested in a review swap? Maybe you can take a look into bug
#1402590.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org