[Bug 1403423] Review Request: visualboyadvance-m - High compatibility Gameboy Advance Emulator combining VBA builds

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1403423



--- Comment #26 from Fedora Update System  ---
visualboyadvance-m-2.0.0-0.7.Beta3.fc24 has been pushed to the Fedora 24 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1403423] Review Request: visualboyadvance-m - High compatibility Gameboy Advance Emulator combining VBA builds

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1403423

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-01-28 19:20:28



--- Comment #25 from Fedora Update System  ---
visualboyadvance-m-2.0.0-0.7.Beta3.fc25 has been pushed to the Fedora 25 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1403423] Review Request: visualboyadvance-m - High compatibility Gameboy Advance Emulator combining VBA builds

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1403423



--- Comment #24 from Fedora Update System  ---
visualboyadvance-m-2.0.0-0.7.Beta3.fc25 has been pushed to the Fedora 25
testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-722ce2d313

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1403423] Review Request: visualboyadvance-m - High compatibility Gameboy Advance Emulator combining VBA builds

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1403423

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #23 from Fedora Update System  ---
visualboyadvance-m-2.0.0-0.7.Beta3.fc24 has been pushed to the Fedora 24
testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-fdca6348cf

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1403423] Review Request: visualboyadvance-m - High compatibility Gameboy Advance Emulator combining VBA builds

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1403423



--- Comment #21 from Fedora Update System  ---
visualboyadvance-m-2.0.0-0.7.Beta3.fc25 has been submitted as an update to
Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-722ce2d313

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1403423] Review Request: visualboyadvance-m - High compatibility Gameboy Advance Emulator combining VBA builds

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1403423



--- Comment #22 from Fedora Update System  ---
visualboyadvance-m-2.0.0-0.7.Beta3.fc24 has been submitted as an update to
Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-fdca6348cf

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1403423] Review Request: visualboyadvance-m - High compatibility Gameboy Advance Emulator combining VBA builds

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1403423



--- Comment #20 from Fedora Update System  ---
visualboyadvance-m-2.0.0-0.6.Beta3.fc24 has been submitted as an update to
Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-cdc8fdd12d

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1403423] Review Request: visualboyadvance-m - High compatibility Gameboy Advance Emulator combining VBA builds

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1403423



--- Comment #19 from Fedora Update System  ---
visualboyadvance-m-2.0.0-0.6.Beta3.fc25 has been submitted as an update to
Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-d7b37c8398

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1403423] Review Request: visualboyadvance-m - High compatibility Gameboy Advance Emulator combining VBA builds

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1403423



--- Comment #17 from Fedora Update System  ---
visualboyadvance-m-2.0.0-0.5.Beta3.fc24 has been submitted as an update to
Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-2f628aad38

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1403423] Review Request: visualboyadvance-m - High compatibility Gameboy Advance Emulator combining VBA builds

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1403423

Fedora Update System  changed:

   What|Removed |Added

 Status|NEW |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1403423] Review Request: visualboyadvance-m - High compatibility Gameboy Advance Emulator combining VBA builds

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1403423



--- Comment #18 from Fedora Update System  ---
visualboyadvance-m-2.0.0-0.5.Beta3.fc25 has been submitted as an update to
Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-b8f14daa95

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1403423] Review Request: visualboyadvance-m - High compatibility Gameboy Advance Emulator combining VBA builds

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1403423



--- Comment #16 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/visualboyadvance-m

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1403423] Review Request: visualboyadvance-m - High compatibility Gameboy Advance Emulator combining VBA builds

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1403423



--- Comment #15 from Jeremy Newton  ---
Thanks!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1403423] Review Request: visualboyadvance-m - High compatibility Gameboy Advance Emulator combining VBA builds

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1403423

Neal Gompa  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #14 from Neal Gompa  ---
Looks good to me.

PACKAGE APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1403423] Review Request: visualboyadvance-m - High compatibility Gameboy Advance Emulator combining VBA builds

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1403423



--- Comment #13 from Neal Gompa  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated


= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "GPL", "GPL (v2) (with incorrect FSF address)", "GPL (v3 or
 later)", "Unknown or generated", "GPL (v2 or later)", "BSL (v1.0)",
 "zlib/libpng", "BSD (3 clause)", "MIT/X11 (BSD like)", "GPL (v2 or
 later) (with incorrect FSF address)", "BSD (2 clause)", "LGPL (v2.1 or
 later)". 571 files have unknown license. Detailed output of
 licensecheck in
 /home/makerpm/1403423-visualboyadvance-m/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package does not own files or directories owned by other packages.
 Note: Dirs in package are owned also by: /usr/share/vbam(vbam-gtk)
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: The spec file handles locales properly.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: gtk-update-icon-cache is invoked in %postun and %posttrans if package
 contains icons.
 Note: icons in visualboyadvance-m
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 40960 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: %config files are marked noreplace or the reason is justified.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
 desktop-file-validate if there is such a file.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: No %config files under /usr.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[x]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if 

[Bug 1403423] Review Request: visualboyadvance-m - High compatibility Gameboy Advance Emulator combining VBA builds

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1403423



--- Comment #12 from Jeremy Newton  ---
(In reply to Neal Gompa from comment #11)
> I am, and I will look over it shortly.

Thanks!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1403423] Review Request: visualboyadvance-m - High compatibility Gameboy Advance Emulator combining VBA builds

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1403423



--- Comment #11 from Neal Gompa  ---
I am, and I will look over it shortly.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1403423] Review Request: visualboyadvance-m - High compatibility Gameboy Advance Emulator combining VBA builds

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1403423

Jeremy Newton  changed:

   What|Removed |Added

 Blocks||1364745 (FE-GAMESIG)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1364745
[Bug 1364745] Games SIG tracker bug
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1403423] Review Request: visualboyadvance-m - High compatibility Gameboy Advance Emulator combining VBA builds

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1403423



--- Comment #10 from Jeremy Newton  ---
Neal, are you still able to review this?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1403423] Review Request: visualboyadvance-m - High compatibility Gameboy Advance Emulator combining VBA builds

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1403423



--- Comment #9 from Jeremy Newton  ---
(In reply to Neal Gompa from comment #8)
> (In reply to Jeremy Newton from comment #7)
> > (In reply to Neal Gompa from comment #6)
> > > (In reply to Jeremy Newton from comment #5)
> > > > (In reply to Neal Gompa from comment #4)
> > > > > [!]: Package must own all directories that it creates.
> > > > >  Note: Directories without known owners:
> > > > >  /usr/share/icons/hicolor/96x96/apps,
> > > > >  /usr/share/icons/hicolor/64x64/apps, 
> > > > > /usr/share/icons/hicolor/22x22,
> > > > >  /usr/share/icons/hicolor/48x48/apps,
> > > > >  /usr/share/icons/hicolor/22x22/apps,
> > > > >  /usr/share/icons/hicolor/32x32/apps, 
> > > > > /usr/share/icons/hicolor/96x96,
> > > > >  /usr/share/icons/hicolor/16x16/apps,
> > > > >  /usr/share/icons/hicolor/scalable/apps,
> > > > >  /usr/share/icons/hicolor/16x16, 
> > > > > /usr/share/icons/hicolor/128x128/apps,
> > > > >  /usr/share/icons/hicolor/128x128, /usr/share/icons/hicolor/64x64,
> > > > >  /usr/share/icons/hicolor/48x48, /usr/share/icons/hicolor/32x32,
> > > > >  /usr/share/icons/hicolor, /usr/share/icons/hicolor/scalable
> > > > > 
> > > > > - Note that this issue can be solved by adding "BuildRequires:
> > > > > hicolor-icon-theme" to the spec and "Requires: hicolor-icon-theme" to 
> > > > > the
> > > > > main package.
> > > > 
> > > > Nice catch, although only the build require is necessary, as the
> > > > auto-dependencies should pick this up.
> > > > 
> > > 
> > > Unfortunately, no, it will not automatically pick it up, since we don't 
> > > have
> > > a dependency generator for checking for the mere existence of the 
> > > directory
> > > paths and setting that up.
> > 
> > Really? I guess I'm mistaken, I thought it picks up on some key directories.
> > I assume all packages that install hicolor icons need this? If so, I need to
> > fix up a few of my own.
> > 
> 
> Yes.

Thanks

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1403423] Review Request: visualboyadvance-m - High compatibility Gameboy Advance Emulator combining VBA builds

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1403423



--- Comment #8 from Neal Gompa  ---
(In reply to Jeremy Newton from comment #7)
> (In reply to Neal Gompa from comment #6)
> > (In reply to Jeremy Newton from comment #5)
> > > (In reply to Neal Gompa from comment #4)
> > > > [!]: Package must own all directories that it creates.
> > > >  Note: Directories without known owners:
> > > >  /usr/share/icons/hicolor/96x96/apps,
> > > >  /usr/share/icons/hicolor/64x64/apps, 
> > > > /usr/share/icons/hicolor/22x22,
> > > >  /usr/share/icons/hicolor/48x48/apps,
> > > >  /usr/share/icons/hicolor/22x22/apps,
> > > >  /usr/share/icons/hicolor/32x32/apps, 
> > > > /usr/share/icons/hicolor/96x96,
> > > >  /usr/share/icons/hicolor/16x16/apps,
> > > >  /usr/share/icons/hicolor/scalable/apps,
> > > >  /usr/share/icons/hicolor/16x16, 
> > > > /usr/share/icons/hicolor/128x128/apps,
> > > >  /usr/share/icons/hicolor/128x128, /usr/share/icons/hicolor/64x64,
> > > >  /usr/share/icons/hicolor/48x48, /usr/share/icons/hicolor/32x32,
> > > >  /usr/share/icons/hicolor, /usr/share/icons/hicolor/scalable
> > > > 
> > > > - Note that this issue can be solved by adding "BuildRequires:
> > > > hicolor-icon-theme" to the spec and "Requires: hicolor-icon-theme" to 
> > > > the
> > > > main package.
> > > 
> > > Nice catch, although only the build require is necessary, as the
> > > auto-dependencies should pick this up.
> > > 
> > 
> > Unfortunately, no, it will not automatically pick it up, since we don't have
> > a dependency generator for checking for the mere existence of the directory
> > paths and setting that up.
> 
> Really? I guess I'm mistaken, I thought it picks up on some key directories.
> I assume all packages that install hicolor icons need this? If so, I need to
> fix up a few of my own.
> 

Yes.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1403423] Review Request: visualboyadvance-m - High compatibility Gameboy Advance Emulator combining VBA builds

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1403423



--- Comment #7 from Jeremy Newton  ---
(In reply to Neal Gompa from comment #6)
> (In reply to Jeremy Newton from comment #5)
> > (In reply to Neal Gompa from comment #4)
> > > [!]: Package must own all directories that it creates.
> > >  Note: Directories without known owners:
> > >  /usr/share/icons/hicolor/96x96/apps,
> > >  /usr/share/icons/hicolor/64x64/apps, /usr/share/icons/hicolor/22x22,
> > >  /usr/share/icons/hicolor/48x48/apps,
> > >  /usr/share/icons/hicolor/22x22/apps,
> > >  /usr/share/icons/hicolor/32x32/apps, /usr/share/icons/hicolor/96x96,
> > >  /usr/share/icons/hicolor/16x16/apps,
> > >  /usr/share/icons/hicolor/scalable/apps,
> > >  /usr/share/icons/hicolor/16x16, 
> > > /usr/share/icons/hicolor/128x128/apps,
> > >  /usr/share/icons/hicolor/128x128, /usr/share/icons/hicolor/64x64,
> > >  /usr/share/icons/hicolor/48x48, /usr/share/icons/hicolor/32x32,
> > >  /usr/share/icons/hicolor, /usr/share/icons/hicolor/scalable
> > > 
> > > - Note that this issue can be solved by adding "BuildRequires:
> > > hicolor-icon-theme" to the spec and "Requires: hicolor-icon-theme" to the
> > > main package.
> > 
> > Nice catch, although only the build require is necessary, as the
> > auto-dependencies should pick this up.
> > 
> 
> Unfortunately, no, it will not automatically pick it up, since we don't have
> a dependency generator for checking for the mere existence of the directory
> paths and setting that up.

Really? I guess I'm mistaken, I thought it picks up on some key directories. I
assume all packages that install hicolor icons need this? If so, I need to fix
up a few of my own.

> 
> > %config(noreplace) /etc/%{shortname}.cfg
> 
> Please replace usage of "/etc" with "%{_sysconfdir}"

Done.

Note that I didn't bump the release:

Spec URL: https://dl.dropboxusercontent.com/u/42480493/visualboyadvance-m.spec
SRPM URL:
https://dl.dropboxusercontent.com/u/42480493/visualboyadvance-m-2.0.0-0.4.Beta3.fc25.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1403423] Review Request: visualboyadvance-m - High compatibility Gameboy Advance Emulator combining VBA builds

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1403423



--- Comment #6 from Neal Gompa  ---
(In reply to Jeremy Newton from comment #5)
> (In reply to Neal Gompa from comment #4)
> > [!]: Package must own all directories that it creates.
> >  Note: Directories without known owners:
> >  /usr/share/icons/hicolor/96x96/apps,
> >  /usr/share/icons/hicolor/64x64/apps, /usr/share/icons/hicolor/22x22,
> >  /usr/share/icons/hicolor/48x48/apps,
> >  /usr/share/icons/hicolor/22x22/apps,
> >  /usr/share/icons/hicolor/32x32/apps, /usr/share/icons/hicolor/96x96,
> >  /usr/share/icons/hicolor/16x16/apps,
> >  /usr/share/icons/hicolor/scalable/apps,
> >  /usr/share/icons/hicolor/16x16, /usr/share/icons/hicolor/128x128/apps,
> >  /usr/share/icons/hicolor/128x128, /usr/share/icons/hicolor/64x64,
> >  /usr/share/icons/hicolor/48x48, /usr/share/icons/hicolor/32x32,
> >  /usr/share/icons/hicolor, /usr/share/icons/hicolor/scalable
> > 
> > - Note that this issue can be solved by adding "BuildRequires:
> > hicolor-icon-theme" to the spec and "Requires: hicolor-icon-theme" to the
> > main package.
> 
> Nice catch, although only the build require is necessary, as the
> auto-dependencies should pick this up.
> 

Unfortunately, no, it will not automatically pick it up, since we don't have a
dependency generator for checking for the mere existence of the directory paths
and setting that up.


> %config(noreplace) /etc/%{shortname}.cfg

Please replace usage of "/etc" with "%{_sysconfdir}"

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1403423] Review Request: visualboyadvance-m - High compatibility Gameboy Advance Emulator combining VBA builds

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1403423



--- Comment #5 from Jeremy Newton  ---
(In reply to Neal Gompa from comment #4)
> A fedora-review run indicates that there are a couple of issues:
> 
> - update-desktop-database is invoked in %post and %postun if package
>   contains desktop file(s) with a MimeType: entry.
>   Note: desktop file(s) with MimeType entry in visualboyadvance-m
>   See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#desktop-
>   database

According to the wiki: "This scriptlet SHOULD NOT be used in Fedora 25 or
later."
So I'll wrap it in an %if.

> [!]: Package must own all directories that it creates.
>  Note: Directories without known owners:
>  /usr/share/icons/hicolor/96x96/apps,
>  /usr/share/icons/hicolor/64x64/apps, /usr/share/icons/hicolor/22x22,
>  /usr/share/icons/hicolor/48x48/apps,
>  /usr/share/icons/hicolor/22x22/apps,
>  /usr/share/icons/hicolor/32x32/apps, /usr/share/icons/hicolor/96x96,
>  /usr/share/icons/hicolor/16x16/apps,
>  /usr/share/icons/hicolor/scalable/apps,
>  /usr/share/icons/hicolor/16x16, /usr/share/icons/hicolor/128x128/apps,
>  /usr/share/icons/hicolor/128x128, /usr/share/icons/hicolor/64x64,
>  /usr/share/icons/hicolor/48x48, /usr/share/icons/hicolor/32x32,
>  /usr/share/icons/hicolor, /usr/share/icons/hicolor/scalable
> 
> - Note that this issue can be solved by adding "BuildRequires:
> hicolor-icon-theme" to the spec and "Requires: hicolor-icon-theme" to the
> main package.

Nice catch, although only the build require is necessary, as the
auto-dependencies should pick this up.

> [!]: Package does not own files or directories owned by other packages.
>  Note: Dirs in package are owned also by: /usr/share/vbam(vbam-gtk)
> 
> - If this is intentional, please put a comment in the spec for why it is
> this way. I can imagine why it might be this way (the two programs are
> independent and not necessarily both installed as they are not
> interdependent).

This is the old package name for visualboyadvance-m in rpmfusion. It's already
provided and obsoleted, see lines 41-43 of the spec. Note that I also maintain
this package in RPMFusion, so it will be retired once this is accepted.


New files:

Spec URL: https://dl.dropboxusercontent.com/u/42480493/visualboyadvance-m.spec
SRPM URL:
https://dl.dropboxusercontent.com/u/42480493/visualboyadvance-m-2.0.0-0.4.Beta3.fc25.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1403423] Review Request: visualboyadvance-m - High compatibility Gameboy Advance Emulator combining VBA builds

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1403423



--- Comment #4 from Neal Gompa  ---
A fedora-review run indicates that there are a couple of issues:

- update-desktop-database is invoked in %post and %postun if package
  contains desktop file(s) with a MimeType: entry.
  Note: desktop file(s) with MimeType entry in visualboyadvance-m
  See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#desktop-
  database

[!]: Package must own all directories that it creates.
 Note: Directories without known owners:
 /usr/share/icons/hicolor/96x96/apps,
 /usr/share/icons/hicolor/64x64/apps, /usr/share/icons/hicolor/22x22,
 /usr/share/icons/hicolor/48x48/apps,
 /usr/share/icons/hicolor/22x22/apps,
 /usr/share/icons/hicolor/32x32/apps, /usr/share/icons/hicolor/96x96,
 /usr/share/icons/hicolor/16x16/apps,
 /usr/share/icons/hicolor/scalable/apps,
 /usr/share/icons/hicolor/16x16, /usr/share/icons/hicolor/128x128/apps,
 /usr/share/icons/hicolor/128x128, /usr/share/icons/hicolor/64x64,
 /usr/share/icons/hicolor/48x48, /usr/share/icons/hicolor/32x32,
 /usr/share/icons/hicolor, /usr/share/icons/hicolor/scalable

- Note that this issue can be solved by adding "BuildRequires:
hicolor-icon-theme" to the spec and "Requires: hicolor-icon-theme" to the main
package.

[!]: Package does not own files or directories owned by other packages.
 Note: Dirs in package are owned also by: /usr/share/vbam(vbam-gtk)

- If this is intentional, please put a comment in the spec for why it is this
way. I can imagine why it might be this way (the two programs are independent
and not necessarily both installed as they are not interdependent).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1403423] Review Request: visualboyadvance-m - High compatibility Gameboy Advance Emulator combining VBA builds

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1403423

Neal Gompa  changed:

   What|Removed |Added

 CC||ngomp...@gmail.com
   Assignee|nob...@fedoraproject.org|ngomp...@gmail.com
  Flags||fedora-review?



--- Comment #3 from Neal Gompa  ---
Taking this review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1403423] Review Request: visualboyadvance-m - High compatibility Gameboy Advance Emulator combining VBA builds

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1403423

Jeremy Newton  changed:

   What|Removed |Added

Summary|Review Request: vbam - High |Review Request:
   |compatibility Gameboy   |visualboyadvance-m - High
   |Advance Emulator combining  |compatibility Gameboy
   |VBA builds  |Advance Emulator combining
   ||VBA builds



--- Comment #2 from Jeremy Newton  ---
Update to beta 3, also renaming of the package to the new upstream name:

Spec URL: https://dl.dropboxusercontent.com/u/42480493/visualboyadvance-m.spec
SRPM URL:
https://dl.dropboxusercontent.com/u/42480493/visualboyadvance-m-2.0.0-0.3.Beta3.fc25.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org