[Bug 1411239] Review Request: python-sphinx-issues - Sphinx extension for linking to your project' s issue tracker

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1411239

Igor Gnatenko  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |WONTFIX
  Flags|needinfo?(ignatenko@redhat. |
   |com)|
Last Closed||2018-08-22 03:31:32



--- Comment #2 from Igor Gnatenko  ---
Unfortunately I don't have time to work on these review requests anymore,
sorry.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/RCXP7NZS2A5RBTRB6P5JTN7MZSFEHB3W/

[Bug 1411239] Review Request: python-sphinx-issues - Sphinx extension for linking to your project' s issue tracker

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1411239

Pavel Cahyna  changed:

   What|Removed |Added

  Flags||fedora-review?
   ||needinfo?(ignatenko@redhat.
   ||com)



--- Comment #1 from Pavel Cahyna  ---
List of issues
==
Minor issues only.

- According to
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Multiple_Licensing_Scenarios
:
"In addition, the package must contain a comment explaining the
multiple licensing breakdown. The actual implementation of this is
left to the maintainer. (...)"

NOTICE says "sphinx-issues includes code adapted from other
libraries. Their licenses are included here." but does not say
to which code it applies. Please document it.

- There is already a 0.3.1 release available.

- In my understanding, the %{py2_dist} and %{py3_dist} macros could be
optionally used for dependencies, see
https://fedoraproject.org/wiki/Packaging:Python#Requires_and_BuildRequires_with_standardized_names



Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "MIT/X11 (BSD like)", "BSD (2 clause)", "Unknown or generated".
 10 files have unknown license. Detailed output of licensecheck in
 /home/pcahyna/fedora-packaging/reviews/1411239-python-sphinx-
 issues/licensecheck.txt
[-]: License file installed when any subpackage combination is installed.
[!]: If the package is under multiple licenses, the licensing breakdown
 must be documented in the spec.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[-]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 20480 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[x]: A 

[Bug 1411239] Review Request: python-sphinx-issues - Sphinx extension for linking to your project' s issue tracker

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1411239

Pavel Cahyna  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||pcah...@redhat.com
   Assignee|nob...@fedoraproject.org|pcah...@redhat.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1411239] Review Request: python-sphinx-issues - Sphinx extension for linking to your project' s issue tracker

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1411239

Igor Gnatenko  changed:

   What|Removed |Added

 Blocks||1411181




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1411181
[Bug 1411181] python-marshmallow-2.11.1 is available
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org