[Bug 1412068] Review Request: ufw-kde - UFW control module for KDE

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1412068

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-02-17 11:21:13



--- Comment #15 from Fedora Update System  ---
ufw-kde-0.5.0-0.5.20161006git.fc25 has been pushed to the Fedora 25 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1412068] Review Request: ufw-kde - UFW control module for KDE

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1412068



--- Comment #14 from Fedora Update System  ---
ufw-kde-0.5.0-0.5.20161006git.fc24 has been pushed to the Fedora 24 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1412068] Review Request: ufw-kde - UFW control module for KDE

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1412068



--- Comment #13 from Fedora Update System  ---
ufw-kde-0.5.0-0.5.20161006git.fc25 has been pushed to the Fedora 25 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-2a3ec4299a

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1412068] Review Request: ufw-kde - UFW control module for KDE

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1412068

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #12 from Fedora Update System  ---
ufw-kde-0.5.0-0.5.20161006git.fc24 has been pushed to the Fedora 24 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-7f4305beb2

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1412068] Review Request: ufw-kde - UFW control module for KDE

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1412068

Fedora Update System  changed:

   What|Removed |Added

 Status|NEW |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1412068] Review Request: ufw-kde - UFW control module for KDE

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1412068



--- Comment #10 from Fedora Update System  ---
ufw-kde-0.5.0-0.5.20161006git.fc25 has been submitted as an update to Fedora
25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-2a3ec4299a

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1412068] Review Request: ufw-kde - UFW control module for KDE

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1412068



--- Comment #11 from Fedora Update System  ---
ufw-kde-0.5.0-0.5.20161006git.fc24 has been submitted as an update to Fedora
24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-7f4305beb2

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1412068] Review Request: ufw-kde - UFW control module for KDE

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1412068



--- Comment #9 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/ufw-kde

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1412068] Review Request: ufw-kde - UFW control module for KDE

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1412068



--- Comment #8 from Kevin Kofler  ---
Thanks, package requested in pkgdb.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1412068] Review Request: ufw-kde - UFW control module for KDE

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1412068



--- Comment #6 from Kevin Kofler  ---
Spec URL:
https://svn.calcforge.org/viewvc/*checkout*/kannolo/trunk/packages/ufw-kde/ufw-kde.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/kkofler/kannolo/fedora-26-x86_64/00507752-ufw-kde/ufw-kde-0.5.0-0.4.20161006git.fc26.src.rpm

* Sun Feb 05 2017 Kevin Kofler  - 0.5.0-0.4.20161006git
- Do not use #!/usr/bin/env for the Python helper

I used this patch:
https://svn.calcforge.org/viewvc/kannolo/trunk/packages/ufw-kde/ufw-kde-0.5.0-no-env.patch?revision=263=markup

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1412068] Review Request: ufw-kde - UFW control module for KDE

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1412068

Neal Gompa  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #7 from Neal Gompa  ---
Excellent, looks good to me.

PACKAGE APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1412068] Review Request: ufw-kde - UFW control module for KDE

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1412068



--- Comment #5 from Neal Gompa  ---
(In reply to Kevin Kofler from comment #4)
> Meh, I still don't see what's so bad about using /usr/bin/env, but I can fix
> that, it should be a one-line patch.
> 
> Anything else I should fix while I am at it?

At the moment, I don't see anything else.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1412068] Review Request: ufw-kde - UFW control module for KDE

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1412068



--- Comment #4 from Kevin Kofler  ---
Meh, I still don't see what's so bad about using /usr/bin/env, but I can fix
that, it should be a one-line patch.

Anything else I should fix while I am at it?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1412068] Review Request: ufw-kde - UFW control module for KDE

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1412068



--- Comment #3 from Neal Gompa  ---
Review notes:

+ Generally complies with packaging guidelines
+ Package is named appropriately
+ Consistently uses macros
! /usr/bin/env is a requirement
! rpmlint error:
  - ufw-kde.x86_64: E: wrong-script-interpreter
/usr/libexec/kde4/kcm_ufw_helper.py /usr/bin/env python3

The wrong-script-interpreter error is also likely leading to /usr/bin/env being
a requirement when it shouldn't be.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1412068] Review Request: ufw-kde - UFW control module for KDE

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1412068



--- Comment #2 from Kevin Kofler  ---
Ping? While I'm not in a rush to get this package into Fedora proper (I have it
in my Kannolo Copr), it would still be useful to get this off my todo list at
some point.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1412068] Review Request: ufw-kde - UFW control module for KDE

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1412068

Neal Gompa  changed:

   What|Removed |Added

 CC||ngomp...@gmail.com
   Assignee|nob...@fedoraproject.org|ngomp...@gmail.com
  Flags||fedora-review?



--- Comment #1 from Neal Gompa  ---
Taking this review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1412068] Review Request: ufw-kde - UFW control module for KDE

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1412068

Kevin Kofler  changed:

   What|Removed |Added

  Alias||ufw-kde



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org