[Bug 1412794] Review Request: kf5-audiocd-kio - KF5 Audiocd kio slave

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1412794
Bug 1412794 depends on bug 1412773, which changed state.

Bug 1412773 Summary: Review Request: kf5-libkcompactdisc - A KDE compact disc 
library
https://bugzilla.redhat.com/show_bug.cgi?id=1412773

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1412794] Review Request: kf5-audiocd-kio - KF5 Audiocd kio slave

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1412794
Bug 1412794 depends on bug 1412788, which changed state.

Bug 1412788 Summary: Review Request: kf5-libkcddb - CDDB retrieval library
https://bugzilla.redhat.com/show_bug.cgi?id=1412788

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1412794] Review Request: kf5-audiocd-kio - KF5 Audiocd kio slave

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1412794

Rex Dieter  changed:

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2017-01-14 10:21:58



--- Comment #13 from Rex Dieter  ---
imported, thanks.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1412794] Review Request: kf5-audiocd-kio - KF5 Audiocd kio slave

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1412794



--- Comment #12 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/kf5-audiocd-kio

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1412794] Review Request: kf5-audiocd-kio - KF5 Audiocd kio slave

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1412794

Christian Dersch  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
  Flags|fedora-review?  |fedora-review+



--- Comment #11 from Christian Dersch  ---
Looks fine now, approved :)



Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
 Note: Unversioned so-files in private %_libdir subdirectory (see
 attachment). Verify they are not in ld path.
==> Unversioned one is a plugin => fine

[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "*No copyright* BSD (3 clause)", "LGPL (v2 or later)", "GPL (v2
 or later)", "GPL (v2 or later) (with Qt exception)", "Unknown or
 generated". 7 files have unknown license. Detailed output of
 licensecheck in /home/review/1412794-kf5-audiocd-kio/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
 Note: Directories without known owners:
 /usr/share/doc/HTML/en/kioslave5, /usr/share/doc/HTML,
 /usr/share/doc/HTML/en, /usr/share/config.kcfg
[x]: Package does not own files or directories owned by other packages.
 Note: Dirs in package are owned also by: /usr/share/konqsidebartng
 (kio-extras), /usr/share/konqsidebartng/virtual_folders(kio-extras)
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under 

[Bug 1412794] Review Request: kf5-audiocd-kio - KF5 Audiocd kio slave

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1412794



--- Comment #10 from Rex Dieter  ---
Spec URL: https://rdieter.fedorapeople.org/rpms/kde-apps/kf5-audiocd-kio.spec
SRPM URL:
https://rdieter.fedorapeople.org/rpms/kde-apps/kf5-audiocd-kio-16.12.1-5.fc25.src.rpm

%changelog
* Fri Jan 13 2017 Rex Dieter  - 16.12.1-5
- BR: alsa

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1412794] Review Request: kf5-audiocd-kio - KF5 Audiocd kio slave

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1412794



--- Comment #9 from Rex Dieter  ---
Spec URL: https://rdieter.fedorapeople.org/rpms/kde-apps/kf5-audiocd-kio.spec
SRPM URL:
https://rdieter.fedorapeople.org/rpms/kde-apps/kf5-audiocd-kio-16.12.1-4.fc25.src.rpm

%changelog
* Fri Jan 13 2017 Rex Dieter  - 16.12.1-4
- fix typo

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1412794] Review Request: kf5-audiocd-kio - KF5 Audiocd kio slave

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1412794



--- Comment #8 from Christian Dersch  ---
I get the error: No matching package to install: 'cmake(KDELibs4Support)'

In spec it should be BuildRequires: cmake(KF5KDELibs4Support) instead

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1412794] Review Request: kf5-audiocd-kio - KF5 Audiocd kio slave

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1412794



--- Comment #7 from Rex Dieter  ---
Spec URL: https://rdieter.fedorapeople.org/rpms/kde-apps/kf5-audiocd-kio.spec
SRPM URL:
https://rdieter.fedorapeople.org/rpms/kde-apps/kf5-audiocd-kio-16.12.1-3.fc25.src.rpm

%changelog
* Fri Jan 13 2017 Rex Dieter  - 16.12.1-3
- update build deps

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1412794] Review Request: kf5-audiocd-kio - KF5 Audiocd kio slave

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1412794



--- Comment #6 from Rex Dieter  ---
, yeah, hard to test fully without the deps first (the other 2 dependant
reviews)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1412794] Review Request: kf5-audiocd-kio - KF5 Audiocd kio slave

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1412794



--- Comment #5 from Christian Dersch  ---
You're missing some BuildRequires, see cmake output I attached.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1412794] Review Request: kf5-audiocd-kio - KF5 Audiocd kio slave

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1412794



--- Comment #4 from Christian Dersch  ---
Created attachment 1240380
  --> https://bugzilla.redhat.com/attachment.cgi?id=1240380=edit
cmake output with missing dependencies

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1412794] Review Request: kf5-audiocd-kio - KF5 Audiocd kio slave

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1412794



--- Comment #2 from Christian Dersch  ---
There is no subpackage libs, so the scriptlets

%post libs -p /sbin/ldconfig
%postun libs -p /sbin/ldconfig

are not valid, please modify them to run on the main package providing the
libs.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1412794] Review Request: kf5-audiocd-kio - KF5 Audiocd kio slave

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1412794



--- Comment #3 from Rex Dieter  ---
Ah, yes, the previous audiocd-kio had a -libs subpkg that I started from, but I
decided to simplify it at the last minute.

%changelog
* Fri Jan 13 2017 Rex Dieter  - 16.12.1-2
- remove -libs reference from scriptlets

Spec URL: https://rdieter.fedorapeople.org/rpms/kde-apps/kf5-audiocd-kio.spec
SRPM URL:
https://rdieter.fedorapeople.org/rpms/kde-apps/kf5-audiocd-kio-16.12.1-2.fc25.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1412794] Review Request: kf5-audiocd-kio - KF5 Audiocd kio slave

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1412794

Christian Dersch  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||lupi...@mailbox.org
   Assignee|nob...@fedoraproject.org|lupi...@mailbox.org
  Flags||fedora-review?



--- Comment #1 from Christian Dersch  ---
Taken, will review now

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1412794] Review Request: kf5-audiocd-kio - KF5 Audiocd kio slave

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1412794

Rex Dieter  changed:

   What|Removed |Added

 Blocks||656997 (kde-reviews)
 Depends On||1412773
   ||(kf5-libkcompactdisc),
   ||1412788 (kf5-libkcddb)
  Alias||kf5-audiocd-kio




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=656997
[Bug 656997] kde-related package review tracker
https://bugzilla.redhat.com/show_bug.cgi?id=1412773
[Bug 1412773] Review Request: kf5-libkcompactdisc - A KDE compact disc
library
https://bugzilla.redhat.com/show_bug.cgi?id=1412788
[Bug 1412788] Review Request: kf5-libkcddb - CDDB retrieval library
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org