[Bug 1413978] Review Request: php-sabre-vobject4 - Library to parse and manipulate iCalendar and vCard objects

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1413978



--- Comment #14 from Fedora Update System  ---
php-sabre-vobject4-4.1.2-1.fc25 has been pushed to the Fedora 25 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1413978] Review Request: php-sabre-vobject4 - Library to parse and manipulate iCalendar and vCard objects

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1413978

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-03-01 19:49:45



--- Comment #13 from Fedora Update System  ---
php-sabre-vobject4-4.1.2-1.fc24 has been pushed to the Fedora 24 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1413978] Review Request: php-sabre-vobject4 - Library to parse and manipulate iCalendar and vCard objects

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1413978



--- Comment #12 from Fedora Update System  ---
php-sabre-vobject4-4.1.2-1.fc25 has been pushed to the Fedora 25 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-1ed5917b02

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1413978] Review Request: php-sabre-vobject4 - Library to parse and manipulate iCalendar and vCard objects

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1413978

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #11 from Fedora Update System  ---
php-sabre-vobject4-4.1.2-1.fc24 has been pushed to the Fedora 24 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-9637bc13e0

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1413978] Review Request: php-sabre-vobject4 - Library to parse and manipulate iCalendar and vCard objects

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1413978

Fedora Update System  changed:

   What|Removed |Added

 Status|NEW |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1413978] Review Request: php-sabre-vobject4 - Library to parse and manipulate iCalendar and vCard objects

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1413978



--- Comment #10 from Fedora Update System  ---
php-sabre-vobject4-4.1.2-1.fc24 has been submitted as an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-9637bc13e0

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1413978] Review Request: php-sabre-vobject4 - Library to parse and manipulate iCalendar and vCard objects

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1413978



--- Comment #9 from Fedora Update System  ---
php-sabre-vobject4-4.1.2-1.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-1ed5917b02

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1413978] Review Request: php-sabre-vobject4 - Library to parse and manipulate iCalendar and vCard objects

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1413978



--- Comment #8 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/php-sabre-vobject4

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1413978] Review Request: php-sabre-vobject4 - Library to parse and manipulate iCalendar and vCard objects

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1413978



--- Comment #7 from Remi Collet  ---
Thanks for the review.

New package requested on pkgdb.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1413978] Review Request: php-sabre-vobject4 - Library to parse and manipulate iCalendar and vCard objects

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1413978

James Hogarth  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #6 from James Hogarth  ---
= Issues =

  * defattr in %files
- since el5 is dropped this should be removed
  * Buildroot present
- since el5 is dropped this should be removed
  * package functions as described
- assuming this is good as tests pass

= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "BSD (3 clause)", "Unknown or generated". 191 files have
 unknown license. Detailed output of licensecheck in
 /home/james/workspace/fedora-scm/1413978-php-sabre-
 vobject4/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[!]: Each %files section contains %defattr if rpm < 4.4
 Note: %defattr present but not needed
[x]: Macros in Summary, %description expandable at SRPM build time.
 Note: Macros in: php-sabre-vobject4 (description)
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[-]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 40960 bytes in 3 files.
[!]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[!]: Buildroot is not present
 Note: Buildroot: present but not needed
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
 justified.
[-]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
 architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
 files.
[x]: Reviewer 

[Bug 1413978] Review Request: php-sabre-vobject4 - Library to parse and manipulate iCalendar and vCard objects

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1413978

James Hogarth  changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|james.hoga...@gmail.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1413978] Review Request: php-sabre-vobject4 - Library to parse and manipulate iCalendar and vCard objects

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1413978



--- Comment #5 from Didier  ---
Thanks for the explanation !

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1413978] Review Request: php-sabre-vobject4 - Library to parse and manipulate iCalendar and vCard objects

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1413978



--- Comment #4 from Remi Collet  ---
The conditional is there to ensure only 1 package provides the commands.
It just need to be the opposite condition in php-sabre-vobject4 than in
php-sabre-vobject. I don't think owncloud use the command (only the library).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1413978] Review Request: php-sabre-vobject4 - Library to parse and manipulate iCalendar and vCard objects

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1413978

Didier  changed:

   What|Removed |Added

 CC||d-bugzi...@moens.cc



--- Comment #3 from Didier  ---
Having recompiled php-sabre-vobject 3.5.3-4 for EL7
(https://copr.fedorainfracloud.org/coprs/ifas/nextcloud11/builds/) pending a
Nextcloud 11 (bug #1360482) EL7 compilation, I wondered whether the conditional
from comment #2 is applicable to EL7 too ?
Or does it suffice to have an  php-sabre-vobject4.el7 ?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1413978] Review Request: php-sabre-vobject4 - Library to parse and manipulate iCalendar and vCard objects

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1413978



--- Comment #2 from Remi Collet  ---
Fix for php-sabre-vobject (command removed)

http://pkgs.fedoraproject.org/cgit/php-sabre-vobject.git/commit/?h=master=3ad2ba1e456c41ab867006e2f31c7bb7f419fe5f

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1413978] Review Request: php-sabre-vobject4 - Library to parse and manipulate iCalendar and vCard objects

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1413978

Remi Collet  changed:

   What|Removed |Added

 CC||james.hoga...@gmail.com



--- Comment #1 from Remi Collet  ---
@James, from IRC

> nextcloud 11.0.1 has bumped the sabre-dav req in composer.json to 3.2.0

sabre/dav requires sabre/vobject 4.1 which have BC break.

glpi requires (for now) sabre/vobject 3.5

So yet another candidate for multi-versions.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org