needinfo canceled: [Bug 1415612] Review Request: sqlrelay - Database proxy
Product: Fedora Version: rawhide Component: Package Review Package Review has canceled Package Review 's request for David Muse 's needinfo: Bug 1415612: Review Request: sqlrelay - Database proxy https://bugzilla.redhat.com/show_bug.cgi?id=1415612 --- Comment #16 from Package Review --- This is an automatic action taken by review-stats script. The ticket submitter failed to clear the NEEDINFO flag in a month. As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews we consider this ticket as DEADREVIEW and proceed to close it. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1415612] Review Request: sqlrelay - Database proxy
https://bugzilla.redhat.com/show_bug.cgi?id=1415612 --- Comment #14 from Robert-André Mauchin --- If this is supposed to be a Python 2 package, name it python2-%{name}. In that case also take into account rhel 8 which supports Python3 by default. %if 0%{?fedora} || 0%{?rhel} > 7 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1415612] Review Request: sqlrelay - Database proxy
https://bugzilla.redhat.com/show_bug.cgi?id=1415612 --- Comment #13 from Robert-André Mauchin --- - make → %make_build - make install DESTDIR=%{buildroot} → %make_install - Not sure I get the Python stuff: %if 0%{?fedora} %package -n python3-%{name} %else %package -n python-%{name} Why not name the package python3-%{name} for EPEL too? We try to go away from python-X naming. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1415612] Review Request: sqlrelay - Database proxy
https://bugzilla.redhat.com/show_bug.cgi?id=1415612 --- Comment #12 from David Muse --- updated SPEC and SRPM: SPEC: http://www.firstworks.com/sqlrelay.spec SRPM: http://www.firstworks.com/sqlrelay-1.5.0-1.fc29.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1415612] Review Request: sqlrelay - Database proxy
https://bugzilla.redhat.com/show_bug.cgi?id=1415612 --- Comment #11 from David Muse --- I'll be making an upstream release (1.5.0) in a few days, and I'll update the package as part of the release process. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1415612] Review Request: sqlrelay - Database proxy
https://bugzilla.redhat.com/show_bug.cgi?id=1415612 --- Comment #10 from Robert-André Mauchin --- No update here? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1415612] Review Request: sqlrelay - Database proxy
https://bugzilla.redhat.com/show_bug.cgi?id=1415612 --- Comment #9 from David Muse --- Got it. All of this is fixed upstream now. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1415612] Review Request: sqlrelay - Database proxy
https://bugzilla.redhat.com/show_bug.cgi?id=1415612 --- Comment #8 from Robert-André Mauchin --- Both, the dirs will thus be removed when the last package owning them is removed. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1415612] Review Request: sqlrelay - Database proxy
https://bugzilla.redhat.com/show_bug.cgi?id=1415612 --- Comment #7 from David Muse --- /sbin/ldconfig calls have been removed upstream will fix library globbing too If multiple independent packages (sqlrelay-server-devel and sqlrelay-c++-devel) install into the same directories: %dir %{_includedir}/%{name} %dir %{_includedir}/%{name}/private Which should own the directories? Both? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1415612] Review Request: sqlrelay - Database proxy
https://bugzilla.redhat.com/show_bug.cgi?id=1415612 Raphael Groner changed: What|Removed |Added CC|projects...@smart.ms| Flags|needinfo?(david.muse@firstw | |orks.com) | -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1415612] Review Request: sqlrelay - Database proxy
https://bugzilla.redhat.com/show_bug.cgi?id=1415612 Robert-André Mauchin changed: What|Removed |Added CC||zebo...@gmail.com --- Comment #6 from Robert-André Mauchin --- - make → %make_build - make install DESTDIR=%{buildroot} → %make_install - Not sure what you're doing here %postun server-devel rmdir %{_includedir}/%{name} 2> /dev/null || : rmdir %{_includedir}/%{name}/private 2> /dev/null || : instead you should own the dir: %dir %{_includedir}/%{name} %dir %{_includedir}/%{name}/private - Same %postun c++-devel rmdir %{_includedir}/%{name} 2> /dev/null || : rmdir %{_includedir}/%{name}/private 2> /dev/null || : %postun c-devel rmdir %{_includedir}/%{name} 2> /dev/null || : rmdir %{_includedir}/%{name}/private 2> /dev/null || : %postun -n python3-%{name} rmdir %{python3_sitearch}/SQLRelay/__pycache__ 2> /dev/null || : rmdir %{python3_sitearch}/SQLRelay 2> /dev/null || : and so on - You should not glob the major soname version to avoid accidentally bumping the soname: %{_libdir}/libsqlrserver.so.* %{_libdir}/libsqlrutil.so.* - /sbin/ldconfig is not needed anymore, remove them all - -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1415612] Review Request: sqlrelay - Database proxy
https://bugzilla.redhat.com/show_bug.cgi?id=1415612 Raphael Groner changed: What|Removed |Added CC||david.m...@firstworks.com Flags||needinfo?(david.muse@firstw ||orks.com) --- Comment #5 from Raphael Groner --- Your FAS name seems to be davidleemuse, is this correct? Are you still interested in this package and looking for a reviewer? If yes, please answer the licenses issue mentioned in comment #3. Maybe we can do a review swap with bug #1469767? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1415612] Review Request: sqlrelay - Database proxy
https://bugzilla.redhat.com/show_bug.cgi?id=1415612 --- Comment #4 from Raphael Groner --- For a review swap, can you maybe take a look into bug #1428202? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1415612] Review Request: sqlrelay - Database proxy
https://bugzilla.redhat.com/show_bug.cgi?id=1415612 --- Comment #3 from Raphael Groner --- Okay, let's give it a try. Alternatively, you could look (or also) into bug #1402590. Are you sure not every license used in the parts of sqlrelay need a valid license text for its own each? If yes, please use %license inside each subpackage. http://sqlrelay.sourceforge.net/license.html https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1415612] Review Request: sqlrelay - Database proxy
https://bugzilla.redhat.com/show_bug.cgi?id=1415612 --- Comment #2 from David Muse --- (In reply to Raphael Groner from comment #1) > Are you interested in a review swap, maybe with bug #1385856? Sure, though I'm not sure I'm really qualified. This is only my second package. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1415612] Review Request: sqlrelay - Database proxy
https://bugzilla.redhat.com/show_bug.cgi?id=1415612 Raphael Groner changed: What|Removed |Added CC||projects...@smart.ms --- Comment #1 from Raphael Groner --- Are you interested in a review swap, maybe with bug #1385856? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org