[Bug 1417495] Review Request: prelude-manager
https://bugzilla.redhat.com/show_bug.cgi?id=1417495 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2017-02-22 09:49:55 --- Comment #17 from Fedora Update System --- prelude-manager-3.1.0-2.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1417495] Review Request: prelude-manager
https://bugzilla.redhat.com/show_bug.cgi?id=1417495 --- Comment #16 from Fedora Update System --- prelude-manager-3.1.0-2.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1417495] Review Request: prelude-manager
https://bugzilla.redhat.com/show_bug.cgi?id=1417495 --- Comment #15 from Fedora Update System --- prelude-manager-3.1.0-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1417495] Review Request: prelude-manager
https://bugzilla.redhat.com/show_bug.cgi?id=1417495 --- Comment #14 from Fedora Update System --- prelude-manager-3.1.0-2.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-139dd58faa -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1417495] Review Request: prelude-manager
https://bugzilla.redhat.com/show_bug.cgi?id=1417495 --- Comment #13 from Fedora Update System --- prelude-manager-3.1.0-2.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-409ef6f707 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1417495] Review Request: prelude-manager
https://bugzilla.redhat.com/show_bug.cgi?id=1417495 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #12 from Fedora Update System --- prelude-manager-3.1.0-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-935389ae93 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1417495] Review Request: prelude-manager
https://bugzilla.redhat.com/show_bug.cgi?id=1417495 Fedora Update System changed: What|Removed |Added Status|ON_QA |MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1417495] Review Request: prelude-manager
https://bugzilla.redhat.com/show_bug.cgi?id=1417495 --- Comment #10 from Fedora Update System --- prelude-manager-3.1.0-2.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-139dd58faa -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1417495] Review Request: prelude-manager
https://bugzilla.redhat.com/show_bug.cgi?id=1417495 --- Comment #11 from Fedora Update System --- prelude-manager-3.1.0-2.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-409ef6f707 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1417495] Review Request: prelude-manager
https://bugzilla.redhat.com/show_bug.cgi?id=1417495 --- Comment #9 from Fedora Update System --- prelude-manager-3.1.0-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-935389ae93 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1417495] Review Request: prelude-manager
https://bugzilla.redhat.com/show_bug.cgi?id=1417495 --- Comment #8 from Fedora Update System --- prelude-manager-3.1.0-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-139dd58faa -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1417495] Review Request: prelude-manager
https://bugzilla.redhat.com/show_bug.cgi?id=1417495 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #7 from Fedora Update System --- prelude-manager-3.1.0-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-935389ae93 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1417495] Review Request: prelude-manager
https://bugzilla.redhat.com/show_bug.cgi?id=1417495 --- Comment #6 from Fedora Update System --- prelude-manager-3.1.0-1.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-139dd58faa -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1417495] Review Request: prelude-manager
https://bugzilla.redhat.com/show_bug.cgi?id=1417495 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1417495] Review Request: prelude-manager
https://bugzilla.redhat.com/show_bug.cgi?id=1417495 --- Comment #5 from Fedora Update System --- prelude-manager-3.1.0-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-935389ae93 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1417495] Review Request: prelude-manager
https://bugzilla.redhat.com/show_bug.cgi?id=1417495 --- Comment #4 from Zbigniew Jędrzejewski-Szmek --- Yep, look good. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1417495] Review Request: prelude-manager
https://bugzilla.redhat.com/show_bug.cgi?id=1417495 --- Comment #3 from Thomas Andrejak --- Thanks for the review Here are the new files : SPEC : https://fedorapeople.org/~totol/prelude-manager.spec SRPM : https://fedorapeople.org/~totol/prelude-manager-3.1.0-1.fc26.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1417495] Review Request: prelude-manager
https://bugzilla.redhat.com/show_bug.cgi?id=1417495 --- Comment #2 from Zbigniew Jędrzejewski-Szmek --- In the service file, also add Documentation=man:prelude-manager(1) . -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1417495] Review Request: prelude-manager
https://bugzilla.redhat.com/show_bug.cgi?id=1417495
Zbigniew Jędrzejewski-Szmek changed:
What|Removed |Added
Status|NEW |POST
CC||zbys...@in.waw.pl
See Also||https://bugzilla.redhat.com
||/show_bug.cgi?id=209224
Assignee|nob...@fedoraproject.org|zbys...@in.waw.pl
Flags||fedora-review+
--- Comment #1 from Zbigniew Jędrzejewski-Szmek ---
This one also hangs in test-lock :(
Can you move %{?systemd_requires} next to the other "Requires:"? It's confusing
to have it with "BuildRequires:".
Grammaro:
"This plugin authorize prelude-manager to log into XML files."
→ "This plugin allows prelude-manager to log into XML files."?
Really, logging into XML files, bleh ;)
I'd also drop the rest of the description in db-plugin, xml-plugin, devel, that
just repeats the general description of prelude-manager.
In the service file:
> Description=Run prelude-manager
This will result in messages like "Starting Run prelude-manager" and "Stopping
Run prelude-manager". Description should be something that fits in that
template, e.g. Description=Prelude bus communicator.
OK, the daemon listens of 127.0.0.1 by default, seems reasonable.
+ package name is OK
+ license is acceptable (GPLv2+)
+ license is specified correctly
+ builds and installs OK
+ scriptlets are sane
+ R/BR/P look correct
+ fedora-review detects no issues
+ %check is present, and tests pass, except for one test
Package is APPROVED.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
