[Bug 1418208] Review Request: perl-Class-Std-Fast - Faster but less secure replacement for Class::Std

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1418208



--- Comment #17 from Fedora Update System  ---
perl-Class-Std-Fast-0.0.8-2.el7 has been pushed to the Fedora EPEL 7 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1418208] Review Request: perl-Class-Std-Fast - Faster but less secure replacement for Class::Std

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1418208



--- Comment #16 from Fedora Update System  ---
perl-Class-Std-Fast-0.0.8-2.el6 has been pushed to the Fedora EPEL 6 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1418208] Review Request: perl-Class-Std-Fast - Faster but less secure replacement for Class::Std

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1418208



--- Comment #15 from Fedora Update System  ---
perl-Class-Std-Fast-0.0.8-2.fc25 has been pushed to the Fedora 25 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1418208] Review Request: perl-Class-Std-Fast - Faster but less secure replacement for Class::Std

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1418208

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-02-17 15:49:38



--- Comment #14 from Fedora Update System  ---
perl-Class-Std-Fast-0.0.8-2.fc24 has been pushed to the Fedora 24 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1418208] Review Request: perl-Class-Std-Fast - Faster but less secure replacement for Class::Std

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1418208

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #13 from Fedora Update System  ---
perl-Class-Std-Fast-0.0.8-2.el7 has been pushed to the Fedora EPEL 7 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-963e4ee3c5

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1418208] Review Request: perl-Class-Std-Fast - Faster but less secure replacement for Class::Std

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1418208



--- Comment #12 from Fedora Update System  ---
perl-Class-Std-Fast-0.0.8-2.el7 has been submitted as an update to Fedora EPEL
7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-963e4ee3c5

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1418208] Review Request: perl-Class-Std-Fast - Faster but less secure replacement for Class::Std

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1418208

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1418208] Review Request: perl-Class-Std-Fast - Faster but less secure replacement for Class::Std

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1418208



--- Comment #11 from Fedora Update System  ---
perl-Class-Std-Fast-0.0.8-2.el6 has been pushed to the Fedora EPEL 6 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-2a000e33e1

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1418208] Review Request: perl-Class-Std-Fast - Faster but less secure replacement for Class::Std

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1418208



--- Comment #10 from Fedora Update System  ---
perl-Class-Std-Fast-0.0.8-2.fc25 has been pushed to the Fedora 25 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-907c53be46

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1418208] Review Request: perl-Class-Std-Fast - Faster but less secure replacement for Class::Std

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1418208

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #9 from Fedora Update System  ---
perl-Class-Std-Fast-0.0.8-2.fc24 has been pushed to the Fedora 24 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-c20e7d1d4c

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1418208] Review Request: perl-Class-Std-Fast - Faster but less secure replacement for Class::Std

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1418208



--- Comment #8 from Fedora Update System  ---
perl-Class-Std-Fast-0.0.8-2.el6 has been submitted as an update to Fedora EPEL
6. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-2a000e33e1

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1418208] Review Request: perl-Class-Std-Fast - Faster but less secure replacement for Class::Std

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1418208



--- Comment #7 from Fedora Update System  ---
perl-Class-Std-Fast-0.0.8-2.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-907c53be46

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1418208] Review Request: perl-Class-Std-Fast - Faster but less secure replacement for Class::Std

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1418208

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1418208] Review Request: perl-Class-Std-Fast - Faster but less secure replacement for Class::Std

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1418208



--- Comment #6 from Fedora Update System  ---
perl-Class-Std-Fast-0.0.8-2.fc24 has been submitted as an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-c20e7d1d4c

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1418208] Review Request: perl-Class-Std-Fast - Faster but less secure replacement for Class::Std

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1418208



--- Comment #5 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/perl-Class-Std-Fast

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1418208] Review Request: perl-Class-Std-Fast - Faster but less secure replacement for Class::Std

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1418208

Andrew Bauer  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #4 from Andrew Bauer  ---
Latest srpm builds in rawhide:
https://koji.fedoraproject.org/koji/taskinfo?taskID=17550405

This package has been approved.

I am interested in co-maintaining this package with you.
I'll request access to it as soon as it shows in the package database.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1418208] Review Request: perl-Class-Std-Fast - Faster but less secure replacement for Class::Std

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1418208



--- Comment #3 from Damian Wrobel  ---
(In reply to Andrew Bauer from comment #1)
> Package builds in rawhide, package owns the files & folders it creates w/
> proper permissions. 
> 
> https://koji.fedoraproject.org/koji/taskinfo?taskID=17545923
> 
> 
> - I like how you handled the license, but I'm wondering if we ought to
> instead reference the actual Perl license text, rather than gpl 3, since
> that is what is referred to on the class:std::fast cpan site. 
> 
> See "The Perl 5 License (Artistic 1 & GPL 1)" ->
> http://dev.perl.org/licenses/
> 
> Doing that would then bring the license text in alignment with what is
> stated in the License: field in the rpm specfile. 
> 
> This is just my opinion and I am not a lawyer, so feel free to respond as
> you see fit.

I found a similar case in a bug 1394267, comment 2 and in the end the package
didn't include any file in %license tag, which IMHO is not in line with
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text, so I
added a text from http://dev.perl.org/licenses/ as you suggested.

I've also sent an e-mail to bug-Class-Std-Fast [at] rt.cpan.org asking authors
to include license's text into distribution.

> 
> - perl-generators is listed twice as a buildrequires
Removed.

> - rpmlint spotted trivial issues with the wording in the description as
> shown below.
I took the original description from
https://metacpan.org/pod/Class::Std::Fast#DESCRIPTION

> 
> $ rpmlint perl-Class-Std-Fast-0.0.8-1.fc25.noarch.rpm
> perl-Class-Std-Fast.noarch: W: spelling-error %description -l en_US ident ->
> dent, indent, i dent
> perl-Class-Std-Fast.noarch: W: spelling-error %description -l en_US
> scalarifiyng -> scarification
> perl-Class-Std-Fast.noarch: W: spelling-error %description -l en_US
> scalarify -> scarify, clarify
> 1 packages and 0 specfiles checked; 0 errors, 3 warnings.
> 
> $ rpmlint perl-Class-Std-Fast-0.0.8-1.fc25.src.rpm
> perl-Class-Std-Fast.src: W: spelling-error %description -l en_US ident ->
> dent, indent, i dent
> perl-Class-Std-Fast.src: W: spelling-error %description -l en_US
> scalarifiyng -> scarification
> perl-Class-Std-Fast.src: W: spelling-error %description -l en_US scalarify
> -> scarify, clarify
> 1 packages and 0 specfiles checked; 0 errors, 3 warnings.
> 
> In my opinion, this is what I would do:
> "You can get the object's identity via scalar-ifying your object. Getting
> the objects identity is still possible via the ident method"
Thank you for providing the correction - applied.

> 
> rpmlint will still complain about that last "ident" but in that case the
> actual name of the method is being referred to.

Updated spec & srpm:
Spec URL:
https://dwrobel.fedorapeople.org/projects/rpmbuild/SPECS/perl-Class-Std-Fast.spec
SRPM URL:
https://dwrobel.fedorapeople.org/projects/rpmbuild/SRPMS/perl-Class-Std-Fast-0.0.8-2.fc25.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1418208] Review Request: perl-Class-Std-Fast - Faster but less secure replacement for Class::Std

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1418208



--- Comment #2 from Andrew Bauer  ---
Unrelated to the review process, this module will not build on epel7 until
perl-Class-Std reaches stable:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-ca783a19ca

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1418208] Review Request: perl-Class-Std-Fast - Faster but less secure replacement for Class::Std

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1418208



--- Comment #1 from Andrew Bauer  ---
Package builds in rawhide, package owns the files & folders it creates w/
proper permissions. 

https://koji.fedoraproject.org/koji/taskinfo?taskID=17545923


- I like how you handled the license, but I'm wondering if we ought to instead
reference the actual Perl license text, rather than gpl 3, since that is what
is referred to on the class:std::fast cpan site. 

See "The Perl 5 License (Artistic 1 & GPL 1)" -> http://dev.perl.org/licenses/

Doing that would then bring the license text in alignment with what is stated
in the License: field in the rpm specfile. 

This is just my opinion and I am not a lawyer, so feel free to respond as you
see fit.

- perl-generators is listed twice as a buildrequires

- rpmlint spotted trivial issues with the wording in the description as shown
below.

$ rpmlint perl-Class-Std-Fast-0.0.8-1.fc25.noarch.rpm
perl-Class-Std-Fast.noarch: W: spelling-error %description -l en_US ident ->
dent, indent, i dent
perl-Class-Std-Fast.noarch: W: spelling-error %description -l en_US
scalarifiyng -> scarification
perl-Class-Std-Fast.noarch: W: spelling-error %description -l en_US scalarify
-> scarify, clarify
1 packages and 0 specfiles checked; 0 errors, 3 warnings.

$ rpmlint perl-Class-Std-Fast-0.0.8-1.fc25.src.rpm
perl-Class-Std-Fast.src: W: spelling-error %description -l en_US ident -> dent,
indent, i dent
perl-Class-Std-Fast.src: W: spelling-error %description -l en_US scalarifiyng
-> scarification
perl-Class-Std-Fast.src: W: spelling-error %description -l en_US scalarify ->
scarify, clarify
1 packages and 0 specfiles checked; 0 errors, 3 warnings.

In my opinion, this is what I would do:
"You can get the object's identity via scalar-ifying your object. Getting the
objects identity is still possible via the ident method"

rpmlint will still complain about that last "ident" but in that case the actual
name of the method is being referred to.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1418208] Review Request: perl-Class-Std-Fast - Faster but less secure replacement for Class::Std

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1418208

Andrew Bauer  changed:

   What|Removed |Added

  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1418208] Review Request: perl-Class-Std-Fast - Faster but less secure replacement for Class::Std

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1418208

Andrew Bauer  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1418208] Review Request: perl-Class-Std-Fast - Faster but less secure replacement for Class::Std

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1418208

Damian Wrobel  changed:

   What|Removed |Added

 Blocks||1418310




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1418310
[Bug 1418310] Review Request: perl-SOAP-WSDL - Perl module for SOAP with
WSDL support
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1418208] Review Request: perl-Class-Std-Fast - Faster but less secure replacement for Class::Std

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1418208

Andrew Bauer  changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|zonexpertconsulting@outlook
   ||.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org