[Bug 1420329] Review Request: python-django-cors-headers - A Django application for handling the CORS headers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1420329

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-03-22 15:21:01



--- Comment #11 from Fedora Update System  ---
python-django-cors-headers-2.0.2-2.fc25 has been pushed to the Fedora 25 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1420329] Review Request: python-django-cors-headers - A Django application for handling the CORS headers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1420329

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #10 from Fedora Update System  ---
python-django-cors-headers-2.0.2-2.fc25 has been pushed to the Fedora 25
testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-b15eded975

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1420329] Review Request: python-django-cors-headers - A Django application for handling the CORS headers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1420329

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1420329] Review Request: python-django-cors-headers - A Django application for handling the CORS headers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1420329



--- Comment #9 from Fedora Update System  ---
python-django-cors-headers-2.0.2-2.fc25 has been submitted as an update to
Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-b15eded975

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1420329] Review Request: python-django-cors-headers - A Django application for handling the CORS headers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1420329



--- Comment #8 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/python-django-cors-headers

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1420329] Review Request: python-django-cors-headers - A Django application for handling the CORS headers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1420329

Dan Callaghan  changed:

   What|Removed |Added

  Flags||fedora-review+



--- Comment #7 from Dan Callaghan  ---
rpmlint has some complaints about LICENSE.txt being executable and having CRLF
line endings. It seems to be this way in the upstream tarball so up to you if
you want to chmod and dos2unix it in %prep or keep it as upstream ships it.

There is also no Requires onto python-django. It's probably not necessary (if
someone wants this package, they must already be requiring Django as well) but
I guess this imports a bunch of Django modules so from that PoV it should
require python-django. On the other hand, if we have multiple Django versions
in compat packages (as in EPEL currently, for example) hard requiring one
version doesn't make sense. So up to you.

APPROVED


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 40960 bytes in 4 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license 

[Bug 1420329] Review Request: python-django-cors-headers - A Django application for handling the CORS headers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1420329



--- Comment #6 from Dan Callaghan  ---
(In reply to Ralph Bean from comment #5)
> I'd rather not get into the EPEL7 python3 stack since I don't directly need
> it.  Missing py3 deps can become a rathole.

Fair enough... although the reason they are missing is because nobody wants to
add them I guess. :-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1420329] Review Request: python-django-cors-headers - A Django application for handling the CORS headers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1420329



--- Comment #5 from Ralph Bean  ---
Thanks!  Here's a new release with fixed summary and fixed license and doc
declarations.

I'd rather not get into the EPEL7 python3 stack since I don't directly need it.
 Missing py3 deps can become a rathole.

Spec URL: http://threebean.org/rpm/SPECS/python-django-cors-headers.spec
SRPM URL:
http://threebean.org/rpm/SRPMS/python-django-cors-headers-2.0.2-2.fc25.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1420329] Review Request: python-django-cors-headers - A Django application for handling the CORS headers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1420329



--- Comment #4 from Dan Callaghan  ---
Looks like you are missing

%license LICENSE.txt

in both subpackages, maybe consider also

%doc README.rst HISTORY.rst

Also note that EPEL7 has a functional Python 3 stack, you could consider
changing the conditionals to enable Python 3 subpackage on EPEL7.

rpmlint has some complaints about the Summary:

python2-django-cors-headers.noarch: W: summary-not-capitalized C
django-cors-headers is a Django application for handling the server headers
required for Cross-Origin Resource Sharing (CORS).
python2-django-cors-headers.noarch: W: summary-ended-with-dot C
django-cors-headers is a Django application for handling the server headers
required for Cross-Origin Resource Sharing (CORS).
python2-django-cors-headers.noarch: E: summary-too-long C django-cors-headers
is a Django application for handling the server headers required for
Cross-Origin Resource Sharing (CORS).

How about this instead:

Summary: Django application for handling Cross-Origin Resource Sharing (CORS)
headers

Everything else looks good.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1420329] Review Request: python-django-cors-headers - A Django application for handling the CORS headers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1420329



--- Comment #3 from Ralph Bean  ---
Yes, good catch.

Here's the latest:

Spec URL: http://threebean.org/rpm/SPECS/python-django-cors-headers.spec
SRPM URL:
http://threebean.org/rpm/SRPMS/python-django-cors-headers-2.0.2-1.fc25.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1420329] Review Request: python-django-cors-headers - A Django application for handling the CORS headers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1420329



--- Comment #2 from Dan Callaghan  ---
It looks like the latest upstream version is 2.0.2:

https://pypi.python.org/pypi/django-cors-headers/2.0.2

Did you want to package that instead?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1420329] Review Request: python-django-cors-headers - A Django application for handling the CORS headers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1420329

Dan Callaghan  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||dcall...@redhat.com
   Assignee|nob...@fedoraproject.org|dcall...@redhat.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1420329] Review Request: python-django-cors-headers - A Django application for handling the CORS headers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1420329



--- Comment #1 from Ralph Bean  ---
This package built on koji: 
https://koji.fedoraproject.org/koji/taskinfo?taskID=17674411

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org