[Bug 1421055] Review Request: deepin-cogl - An object oriented GL/ GLES Utility Layer for Deepin
https://bugzilla.redhat.com/show_bug.cgi?id=1421055 Zamir SUN changed: What|Removed |Added Alias||deepin-cogl -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1421055] Review Request: deepin-cogl - An object oriented GL/ GLES Utility Layer for Deepin
https://bugzilla.redhat.com/show_bug.cgi?id=1421055 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2017-10-09 15:58:53 --- Comment #23 from Fedora Update System --- cogl-1.22.2-7.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1421055] Review Request: deepin-cogl - An object oriented GL/ GLES Utility Layer for Deepin
https://bugzilla.redhat.com/show_bug.cgi?id=1421055 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #22 from Fedora Update System --- cogl-1.22.2-7.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-1bad42b7b7 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1421055] Review Request: deepin-cogl - An object oriented GL/ GLES Utility Layer for Deepin
https://bugzilla.redhat.com/show_bug.cgi?id=1421055 Fedora Update System changed: What|Removed |Added Status|NEW |MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1421055] Review Request: deepin-cogl - An object oriented GL/ GLES Utility Layer for Deepin
https://bugzilla.redhat.com/show_bug.cgi?id=1421055 --- Comment #21 from Fedora Update System --- cogl-1.22.2-7.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2017-1bad42b7b7 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1421055] Review Request: deepin-cogl - An object oriented GL/ GLES Utility Layer for Deepin
https://bugzilla.redhat.com/show_bug.cgi?id=1421055 --- Comment #20 from sensor@gmail.com --- Added the pkgconfig(egl) BReq. Build passed. @Peter PR: https://src.fedoraproject.org/rpms/cogl/pull-request/2 Test: https://koji.fedoraproject.org/koji/taskinfo?taskID=22219077 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1421055] Review Request: deepin-cogl - An object oriented GL/ GLES Utility Layer for Deepin
https://bugzilla.redhat.com/show_bug.cgi?id=1421055 --- Comment #19 from Peter Robinson --- It's FBTFS, looks like there's a new dependency. https://koji.fedoraproject.org/koji/taskinfo?taskID=22126976 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1421055] Review Request: deepin-cogl - An object oriented GL/ GLES Utility Layer for Deepin
https://bugzilla.redhat.com/show_bug.cgi?id=1421055 --- Comment #18 from sensor@gmail.com --- I submitted a new Pull Request for cogl. It looks good. @Peter https://src.fedoraproject.org/rpms/cogl/pull-request/1 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1421055] Review Request: deepin-cogl - An object oriented GL/ GLES Utility Layer for Deepin
https://bugzilla.redhat.com/show_bug.cgi?id=1421055 --- Comment #17 from Peter Robinson --- > Cogl patches are approved on the upstream, but new versions are not > available. May be we need to attach them to cogl package. Saw that, I'm traveling and in meetings all week so I won't have time to look closely for a bit but if you could give me a PR [1] I can merge/push a build this week. [1] https://src.fedoraproject.org/rpms/cogl -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1421055] Review Request: deepin-cogl - An object oriented GL/ GLES Utility Layer for Deepin
https://bugzilla.redhat.com/show_bug.cgi?id=1421055 --- Comment #16 from Zamir SUN --- (In reply to sensor.wen from comment #15) > Hi, @Peter > > Cogl patches are approved on the upstream, but new versions are not > available. May be we need to attach them to cogl package. > > https://bugzilla.gnome.org/show_bug.cgi?id=787443#c8 Bowen, See comment 11. I suggest file a bug asking the cogl maintainers to add them after the patches landed in cogl git repo. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1421055] Review Request: deepin-cogl - An object oriented GL/ GLES Utility Layer for Deepin
https://bugzilla.redhat.com/show_bug.cgi?id=1421055 --- Comment #15 from sensor@gmail.com --- Hi, @Peter Cogl patches are approved on the upstream, but new versions are not available. May be we need to attach them to cogl package. https://bugzilla.gnome.org/show_bug.cgi?id=787443#c8 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1421055] Review Request: deepin-cogl - An object oriented GL/ GLES Utility Layer for Deepin
https://bugzilla.redhat.com/show_bug.cgi?id=1421055 Zamir SUN changed: What|Removed |Added External Bug ID||GNOME Desktop 787443 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1421055] Review Request: deepin-cogl - An object oriented GL/ GLES Utility Layer for Deepin
https://bugzilla.redhat.com/show_bug.cgi?id=1421055 --- Comment #14 from sensor@gmail.com --- (In reply to Peter Robinson from comment #13) > > Thanks @Peter Robinson. > > I try to create new upstream bugs for both on Github. > > I suspect you'll need bugzilla.gnome.org rather than github https://bugzilla.gnome.org/show_bug.cgi?id=787443 I submitted new upstream bug for this. But I can't provide much information about patches. If you find out some problem, i will tell the developer. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1421055] Review Request: deepin-cogl - An object oriented GL/ GLES Utility Layer for Deepin
https://bugzilla.redhat.com/show_bug.cgi?id=1421055 --- Comment #13 from Peter Robinson --- > Thanks @Peter Robinson. > I try to create new upstream bugs for both on Github. I suspect you'll need bugzilla.gnome.org rather than github -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1421055] Review Request: deepin-cogl - An object oriented GL/ GLES Utility Layer for Deepin
https://bugzilla.redhat.com/show_bug.cgi?id=1421055 --- Comment #12 from sensor@gmail.com --- (In reply to Peter Robinson from comment #11) > (In reply to sensor.wen from comment #10) > > Only the following two patches are required for Cogl. > > > > https://github.com/linuxdeepin/deepin-cogl/commit/ > > 78636289b073d67209a20145ef0dc003f2d77db6Add GL_ARB_shader_texture_lod > > support > > https://github.com/linuxdeepin/deepin-cogl/commit/ > > d8b34ab0604d80d0be22b8b78e9aa6bf4fac7db0texture: Support copy_sub_image > > > > and then the `clutter` needs following patch. > > > > https://github.com/sonald/clutter/commit/ > > 0e6e542a05e071791ca625d08f8efa8111a347db Support actors(blur) to be > > always redrawn > > We need upstream bugs for both (cogl/clutter) and then link those to > downstream bugs against the appropriate Fedora components, close off this > request as it's not the place to deal with it. > > > I asked the developer of Deepin why didn't submit these patches to upstream, > > and he said: "upstream does not merge the patches they doesn't need use". > > @Peter Robinson could you help me? > > I don't believe that to be true, and it's certainly not been my experience. Thanks @Peter Robinson. I try to create new upstream bugs for both on Github. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1421055] Review Request: deepin-cogl - An object oriented GL/ GLES Utility Layer for Deepin
https://bugzilla.redhat.com/show_bug.cgi?id=1421055 --- Comment #11 from Peter Robinson --- (In reply to sensor.wen from comment #10) > Only the following two patches are required for Cogl. > > https://github.com/linuxdeepin/deepin-cogl/commit/ > 78636289b073d67209a20145ef0dc003f2d77db6Add GL_ARB_shader_texture_lod > support > https://github.com/linuxdeepin/deepin-cogl/commit/ > d8b34ab0604d80d0be22b8b78e9aa6bf4fac7db0texture: Support copy_sub_image > > and then the `clutter` needs following patch. > > https://github.com/sonald/clutter/commit/ > 0e6e542a05e071791ca625d08f8efa8111a347db Support actors(blur) to be > always redrawn We need upstream bugs for both (cogl/clutter) and then link those to downstream bugs against the appropriate Fedora components, close off this request as it's not the place to deal with it. > I asked the developer of Deepin why didn't submit these patches to upstream, > and he said: "upstream does not merge the patches they doesn't need use". > @Peter Robinson could you help me? I don't believe that to be true, and it's certainly not been my experience. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1421055] Review Request: deepin-cogl - An object oriented GL/ GLES Utility Layer for Deepin
https://bugzilla.redhat.com/show_bug.cgi?id=1421055 sensor@gmail.com changed: What|Removed |Added Flags|needinfo?(sensor.wen@gmail. | |com)| --- Comment #10 from sensor@gmail.com --- Only the following two patches are required for Cogl. https://github.com/linuxdeepin/deepin-cogl/commit/78636289b073d67209a20145ef0dc003f2d77db6 Add GL_ARB_shader_texture_lod support https://github.com/linuxdeepin/deepin-cogl/commit/d8b34ab0604d80d0be22b8b78e9aa6bf4fac7db0 texture: Support copy_sub_image and then the `clutter` needs following patch. https://github.com/sonald/clutter/commit/0e6e542a05e071791ca625d08f8efa8111a347db Support actors(blur) to be always redrawn I asked the developer of Deepin why didn't submit these patches to upstream, and he said: "upstream does not merge the patches they doesn't need use". @Peter Robinson could you help me? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1421055] Review Request: deepin-cogl - An object oriented GL/ GLES Utility Layer for Deepin
https://bugzilla.redhat.com/show_bug.cgi?id=1421055 --- Comment #9 from Peter Robinson --- (In reply to Zbigniew Jędrzejewski-Szmek from comment #7) > Is this package really needed? The diff between gnome's cogl 1.22 and this > fork is just a few commits. Wouldn't it be possible to cooperate with Fedora > cogl maintainers and cogl upstream to upstream those patches and dispose of > the fork: > > Only in deepin-cogl cogl-1.22 branch: > * 1e1e1b8a97 winsys: Disable sync_control > * f28fe60db1 Add LICENSE > * 9ee8ef2d2d (tag: 1.22.3) Change debian dir > * a34f7835c0 Debian dir migration > * 9e113c10da Add debian dir > * d8b34ab060 texture: Support copy_sub_image > * 78636289b0 Add GL_ARB_shader_texture_lod support > > Only in upstream cogl cogl-1.22 branch: > * cbdde65b7e (upstream/cogl-1.22) Add Nepali translation > * 84d9ed33ef Update Malayalam translation > * 811f285a8e Update po/Makevars > * 3baa2d7a65 Updated Norwegian bokmål translation. > * 0bc94d13df Update Friulian translation > * cdb3229f54 Update Friulian translation > * df29d85990 Add Friulian translation > * b583e21d86 Fix an incorrect preprocessor conditional > > @pbrobinson, what do you think? Yes, absolutely, having overlapping libraries is ridiculous. Also looking at the 7 patches in deepin-cogl listed above there's probably only two that actually would affect Fedora, the top 5 listed commits are debian/windows/licence related, it's likely only the bottom two of real effect to Fedora and those should go for review upstream (well they all should). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1421055] Review Request: deepin-cogl - An object oriented GL/ GLES Utility Layer for Deepin
https://bugzilla.redhat.com/show_bug.cgi?id=1421055 Zamir SUN changed: What|Removed |Added CC||pbrobin...@gmail.com, ||sensor@gmail.com Flags||needinfo?(sensor.wen@gmail. ||com) --- Comment #8 from Zamir SUN --- (In reply to Zbigniew Jędrzejewski-Szmek from comment #7) > * 9ee8ef2d2d (tag: 1.22.3) Change debian dir > * a34f7835c0 Debian dir migration > * 9e113c10da Add debian dir @mosquito, can you try how this works if we manually create the dir as the commit above? > @pbrobinson, what do you think? I see Peter is not copied into the bug, so adding him to cc. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1421055] Review Request: deepin-cogl - An object oriented GL/ GLES Utility Layer for Deepin
https://bugzilla.redhat.com/show_bug.cgi?id=1421055 --- Comment #7 from Zbigniew Jędrzejewski-Szmek --- Is this package really needed? The diff between gnome's cogl 1.22 and this fork is just a few commits. Wouldn't it be possible to cooperate with Fedora cogl maintainers and cogl upstream to upstream those patches and dispose of the fork: Only in deepin-cogl cogl-1.22 branch: * 1e1e1b8a97 winsys: Disable sync_control * f28fe60db1 Add LICENSE * 9ee8ef2d2d (tag: 1.22.3) Change debian dir * a34f7835c0 Debian dir migration * 9e113c10da Add debian dir * d8b34ab060 texture: Support copy_sub_image * 78636289b0 Add GL_ARB_shader_texture_lod support Only in upstream cogl cogl-1.22 branch: * cbdde65b7e (upstream/cogl-1.22) Add Nepali translation * 84d9ed33ef Update Malayalam translation * 811f285a8e Update po/Makevars * 3baa2d7a65 Updated Norwegian bokmål translation. * 0bc94d13df Update Friulian translation * cdb3229f54 Update Friulian translation * df29d85990 Add Friulian translation * b583e21d86 Fix an incorrect preprocessor conditional @pbrobinson, what do you think? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1421055] Review Request: deepin-cogl - An object oriented GL/ GLES Utility Layer for Deepin
https://bugzilla.redhat.com/show_bug.cgi?id=1421055 --- Comment #6 from sensor@gmail.com --- Upstream has not free time for this. I think the best way is use another path to save libraries and header files. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1421055] Review Request: deepin-cogl - An object oriented GL/ GLES Utility Layer for Deepin
https://bugzilla.redhat.com/show_bug.cgi?id=1421055 --- Comment #5 from Robert-André Mauchin --- @mosquito: I've discussed this with other packagers on IRC and the conclusion was it's best to rename it in order to avoid any conflict with the original cogl. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1421055] Review Request: deepin-cogl - An object oriented GL/ GLES Utility Layer for Deepin
https://bugzilla.redhat.com/show_bug.cgi?id=1421055 --- Comment #4 from Robin Lee --- Since version of deepin-cogl is greater than cogl, anybody runs 'dnf install cogl' will actually install deepin-cogl. Also applies to pungi. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1421055] Review Request: deepin-cogl - An object oriented GL/ GLES Utility Layer for Deepin
https://bugzilla.redhat.com/show_bug.cgi?id=1421055 --- Comment #3 from sensor@gmail.com --- SPEC: https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-26-x86_64/00596540-deepin-cogl/deepin-cogl.spec SRPM: https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-26-x86_64/00596540-deepin-cogl/deepin-cogl-1.22.5-2.fc26.src.rpm - remove the 'conflicts' and 'obsoletes' tag It's mostly the same as the original cogl. I don't want anyone who doesn't use deepin to update it. So what should i do with it? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1421055] Review Request: deepin-cogl - An object oriented GL/ GLES Utility Layer for Deepin
https://bugzilla.redhat.com/show_bug.cgi?id=1421055 Robert-André Mauchin changed: What|Removed |Added CC||zebo...@gmail.com --- Comment #2 from Robert-André Mauchin --- Is it that bad if it conflicts with the original cogl? It provides the same functions, with two additions for deepin. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1421055] Review Request: deepin-cogl - An object oriented GL/ GLES Utility Layer for Deepin
https://bugzilla.redhat.com/show_bug.cgi?id=1421055 Robin Lee changed: What|Removed |Added CC||robinlee.s...@gmail.com Blocks||1476573 Assignee|nob...@fedoraproject.org|robinlee.s...@gmail.com Whiteboard||NotReady Flags||fedora-review? --- Comment #1 from Robin Lee --- This package should not conflict with the original cogl. Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1476573 [Bug 1476573] Review Request: deepin-mutter - Base window manager for deepin, fork of gnome mutter -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1421055] Review Request: deepin-cogl - An object oriented GL/ GLES Utility Layer for Deepin
https://bugzilla.redhat.com/show_bug.cgi?id=1421055 Zbigniew Jędrzejewski-Szmek changed: What|Removed |Added Blocks|177841 (FE-NEEDSPONSOR) | Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1421055] Review Request: deepin-cogl - An object oriented GL/ GLES Utility Layer for Deepin
https://bugzilla.redhat.com/show_bug.cgi?id=1421055 Zamir SUN changed: What|Removed |Added Blocks||1465889 ||(DeepinDEPackageReview) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1465889 [Bug 1465889] Tracking: Deepin Desktop related package review tracker -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1421055] Review Request: deepin-cogl - An object oriented GL/ GLES Utility Layer for Deepin
https://bugzilla.redhat.com/show_bug.cgi?id=1421055 sensor@gmail.com changed: What|Removed |Added Blocks||177841 (FE-NEEDSPONSOR) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
