[Bug 1421081] Review Request: perl-Code-TidyAll-Plugin-Test-Vars - Provides Test::Vars plugin for Code: :TidyAll

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1421081

Jitka Plesnikova  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
   Fixed In Version||perl-Code-TidyAll-Plugin-Te
   ||st-Vars-0.04-2.fc26
 Resolution|--- |RAWHIDE
Last Closed||2017-02-24 03:57:36



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1421081] Review Request: perl-Code-TidyAll-Plugin-Test-Vars - Provides Test::Vars plugin for Code: :TidyAll

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1421081



--- Comment #2 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/perl-Code-TidyAll-Plugin-Test-Vars

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1421081] Review Request: perl-Code-TidyAll-Plugin-Test-Vars - Provides Test::Vars plugin for Code: :TidyAll

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1421081

Jitka Plesnikova  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #1 from Jitka Plesnikova  ---
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed

$ rpm -qp --provides perl-Code-TidyAll-Plugin-Test-Vars-0.04-1.fc26.noarch.rpm
| sort | uniq -c
  1 perl(Code::TidyAll::Plugin::Test::Vars) = 0.04
  1 perl-Code-TidyAll-Plugin-Test-Vars = 0.04-1.fc26
Binary provides are Ok.

$ rpmlint ./perl-Code-TidyAll-Plugin-Test-Vars*
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
Rpmlint is ok

$ rpm -qp --requires perl-Code-TidyAll-Plugin-Test-Vars-0.04-1.fc26.noarch.rpm
| sort | uniq -c
  1 perl(:MODULE_COMPAT_5.24.1)
  1 perl(Code::TidyAll) >= 0.50
  1 perl(Moo)
  1 perl(PPI::Document)
  1 perl(Path::Tiny)
  1 perl(Test::Vars) >= 0.008
  1 perl(autodie)
  1 perl(strict)
  1 perl(warnings)
  1 rpmlib(CompressedFileNames) <= 3.0.4-1
  1 rpmlib(FileDigests) <= 4.6.0-1
  1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
  1 rpmlib(PayloadIsXz) <= 5.2-1
FIX: Please add missing run-require perl(Code::TidyAll::Plugin)
 
Code-TidyAll-Plugin-Test-Vars-0.04/lib/Code/TidyAll/Plugin/Test/Vars.pm:17

 Moo 'extends' keyword is not recognize by perl-generators (similar to
BZ#742478)

BuildRequires:
FIX: Please remove duplicity 'perl(strict)' from build-requires.
FIX: Please add the version restriction for perl(ExtUtils::MakeMaker) to
 6.76 or higher, because NO_PACKLIST option was added in this version.


Please correct all 'FIX' issues before commit.

Otherwise the package is good.
Approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1421081] Review Request: perl-Code-TidyAll-Plugin-Test-Vars - Provides Test::Vars plugin for Code: :TidyAll

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1421081

Jitka Plesnikova  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||jples...@redhat.com
   Assignee|nob...@fedoraproject.org|jples...@redhat.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org