[Bug 1421346] Review Request: extracturl - perl script for url extraction
https://bugzilla.redhat.com/show_bug.cgi?id=1421346 Mattia Verga changed: What|Removed |Added Status|POST|NEW Assignee|zebo...@gmail.com |nob...@fedoraproject.org Flags|fedora-review+ |needinfo?(klaatu@fedoraproj ||ect.org) --- Comment #16 from Mattia Verga --- Package never imported, resetting ticket status. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1421346] Review Request: extracturl - perl script for url extraction
https://bugzilla.redhat.com/show_bug.cgi?id=1421346 --- Comment #15 from Mike Oliver --- If you're not already in the packager group you'll need to seek sponsorship: https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1421346] Review Request: extracturl - perl script for url extraction
https://bugzilla.redhat.com/show_bug.cgi?id=1421346 notklaatu changed: What|Removed |Added CC||c...@straightedgelinux.com --- Comment #14 from notklaatu --- I would still like to maintain this package, although I don't know what the next step in that process is. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1421346] Review Request: extracturl - perl script for url extraction
https://bugzilla.redhat.com/show_bug.cgi?id=1421346 Robert-André Mauchin changed: What|Removed |Added Status|NEW |POST Assignee|nob...@fedoraproject.org|zebo...@gmail.com Flags||fedora-review+ --- Comment #13 from Robert-André Mauchin --- Looks good, package approved. Not sure that the repo request will go through as you're not the reporter… if it doesn't work, make a new Review Request and mark this oni as duplicate. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1421346] Review Request: extracturl - perl script for url extraction
https://bugzilla.redhat.com/show_bug.cgi?id=1421346 --- Comment #12 from Mike Oliver --- Spec URL: https://mklvr.fedorapeople.org/extracturl/extracturl.spec SRPM URL: https://mklvr.fedorapeople.org/extracturl/extracturl-1.6.2-1.fc28.src.rpm Requested changes have been made. Thanks for the feedback. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1421346] Review Request: extracturl - perl script for url extraction
https://bugzilla.redhat.com/show_bug.cgi?id=1421346
--- Comment #11 from Robert-André Mauchin ---
- You should use macros in %files:
%{_bindir}/extract_url
%{_mandir}/man1/extract_url.1*
- Use a more meaningful archive name with:
Source0:
https://github.com/m3m0ryh0l3/%{name}/archive/v%{version}/%{name}-%{version}.tar.gz
- Fix the dependencies:
BuildRequires: perl-generators
BuildRequires: perl-interpreter
BuildRequires: perl(Env)
BuildRequires: perl(Getopt::Std)
BuildRequires: perl(HTML::Parser)
BuildRequires: perl(MIME::Parser)
BuildRequires: perl(Pod::Checker)
BuildRequires: perl(Pod::Usage)
BuildRequires: perl(POSIX)
BuildRequires: perl(strict)
BuildRequires: perl(warnings)
BuildRequires: perl-podlators
Requires: perl(Curses::UI)
Requires: perl(Getopt::Long)
Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo
$version))
Recommends: perl(MIME::QuotedPrint)
Recommends: perl(URI::Find)
- Split the description to stay below 80 characters per line:
extracturl.noarch: E: description-line-too-long C A Perl script that extracts
URLs from correctly-encoded MIME email messages or plain text.
- Capitalize the summary:
extracturl.noarch: W: summary-not-capitalized C url extractor commonly used for
mutt
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "BSD (2 clause)", "Unknown or generated". 4 files have unknown
license. Detailed output of licensecheck in
/home/bob/packaging/review/extracturl/review-
extracturl/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 4 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: Uses parallel make %{?_smp_mflags} macro.
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and
[Bug 1421346] Review Request: extracturl - perl script for url extraction
https://bugzilla.redhat.com/show_bug.cgi?id=1421346 --- Comment #10 from Mike Oliver --- Also, I can take over this package is klaatu is no longer interested in it. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1421346] Review Request: extracturl - perl script for url extraction
https://bugzilla.redhat.com/show_bug.cgi?id=1421346 Mike Oliver changed: What|Removed |Added CC||m...@mklvr.io --- Comment #9 from Mike Oliver --- I've bumped the package version for klaatu and made the suggested changes. SPEC: https://mklvr.fedorapeople.org/extracturl/extracturl.spec SRPM: https://mklvr.fedorapeople.org/extracturl/extracturl-1.6.2-1.fc28.src.rpm KOJI: https://koji.fedoraproject.org/koji/taskinfo?taskID=29780055 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1421346] Review Request: extracturl - perl script for url extraction
https://bugzilla.redhat.com/show_bug.cgi?id=1421346
Robert-André Mauchin changed:
What|Removed |Added
CC||zebo...@gmail.com
--- Comment #8 from Robert-André Mauchin ---
- Use the %make_install macro to preserve timestamps:
make install DESTDIR=%{buildroot} → %make_install
- Bump the package to the latest version and I'll review it
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1421346] Review Request: extracturl - perl script for url extraction
https://bugzilla.redhat.com/show_bug.cgi?id=1421346 --- Comment #7 from klaatu --- Solved the koji error with $ kinit $u...@fedoraproject.org $ klist -A -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1421346] Review Request: extracturl - perl script for url extraction
https://bugzilla.redhat.com/show_bug.cgi?id=1421346 --- Comment #6 from klaatu --- I've modified my spec file to include some of the suggestions here. Spec file and latest RPM builds on f27: https://klaatu.fedorapeople.org/extracturl/ Koji is giving me this error: $ koji build --scratch rawhide SRPMS/extracturl-1.6.1-3.fc27.src.rpm AuthError: unable to obtain a session I've renewed my certs with `fedora-cert -n` but when I attempt to verify, I get Python errors. I assume I'll file a bug against fedora-cert about that, separately (unless it's an easy fix). $ fedora-cert -v Traceback (most recent call last): File "/usr/bin/fedora-cert", line 85, in main(opts) File "/usr/bin/fedora-cert", line 52, in main if fedora_cert.certificate_expired(): File "/usr/lib/python2.7/site-packages/fedora_cert/__init__.py", line 83, in certificate_expired if my_cert.has_expired(): AttributeError: 'NoneType' object has no attribute 'has_expired' -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1421346] Review Request: extracturl - perl script for url extraction
https://bugzilla.redhat.com/show_bug.cgi?id=1421346 Filip Szymański changed: What|Removed |Added CC||filip.szyman...@zoho.eu --- Comment #5 from Filip Szymański --- My old spec file: https://fszymanski.fedorapeople.org/extracturl/extracturl.spec -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1421346] Review Request: extracturl - perl script for url extraction
https://bugzilla.redhat.com/show_bug.cgi?id=1421346 --- Comment #4 from klaatu --- Clarification: locally, 'BuildRequires: perl-generators' builds. It fails when building via Koji, and I don't know how to fix that. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1421346] Review Request: extracturl - perl script for url extraction
https://bugzilla.redhat.com/show_bug.cgi?id=1421346 --- Comment #3 from klaatu --- With this as the BuildRequires line: BuildRequires: perl-generators the build fails. https://koji.fedoraproject.org/koji/taskinfo?taskID=18983146 So I changed it back to a manual list for BuildRequires. All other changes you suggested, I have made, and that build works: https://koji.fedoraproject.org/koji/taskinfo?taskID=18983461 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1421346] Review Request: extracturl - perl script for url extraction
https://bugzilla.redhat.com/show_bug.cgi?id=1421346
--- Comment #2 from Michael Schwendt ---
If added "BuildRequires: perl-generators", you would get automatic dependencies
for Perl modules. Take a look at your built binary package:
rpm -qpR extracturl-1.6.1-1.fc25.noarch.rpm
> cp -pr extract_urlview.sample %{buildroot}%{_docdir}/%{name}
> /usr/share/doc/extracturl/extract_urlview.sample
Much too complicated and would be missing the directory if no other %doc files
were present. Why don't you simply include that file like the other %doc files?
%files
%doc NEWS README AUTHORS extract_urlview.sample
> /usr/share/man/man1/extract_url.1.gz
More convenient in the long term would be
/usr/share/man/man1/extract_url.1*
because it would not require a change of the spec file, if building in an
environment where rpmbuild's compression of manuals is disabled or changed to a
different compression program.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1421346] Review Request: extracturl - perl script for url extraction
https://bugzilla.redhat.com/show_bug.cgi?id=1421346 klaatu changed: What|Removed |Added Blocks||177841 (FE-NEEDSPONSOR) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1421346] Review Request: extracturl - perl script for url extraction
https://bugzilla.redhat.com/show_bug.cgi?id=1421346 --- Comment #1 from klaatu --- Spec URL: https://klaatu.fedorapeople.org/extracturl/extracturl.spec -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
