[Bug 1421406] Review Request: python-libtmux - Scripting library for tmux

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1421406

Randy Barlow  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |CURRENTRELEASE
Last Closed||2020-02-14 14:26:45



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1421406] Review Request: python-libtmux - Scripting library for tmux

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1421406

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #7 from Fedora Update System  ---
python-libtmux-0.6.0-1.fc25 has been pushed to the Fedora 25 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-b8db93ec64

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1421406] Review Request: python-libtmux - Scripting library for tmux

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1421406



--- Comment #6 from Fedora Update System  ---
python-libtmux-0.6.0-1.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-b8db93ec64

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1421406] Review Request: python-libtmux - Scripting library for tmux

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1421406

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1421406] Review Request: python-libtmux - Scripting library for tmux

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1421406



--- Comment #5 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/python-libtmux

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1421406] Review Request: python-libtmux - Scripting library for tmux

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1421406



--- Comment #4 from David Roble  ---
I uploaded a new spec and srpm with the spelling fix.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1421406] Review Request: python-libtmux - Scripting library for tmux

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1421406

Randy Barlow  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #3 from Randy Barlow  ---
Only one more thing I recommend you to fix - the word "sessions" is misspelled
in the description.

APPROVED!


Package Review
==

Legend: 
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated   
[ ] = Manual review needed  



= MUST items =  

Generic:
[x]: Package is licensed with an open-source compatible license and meets   
 other legal requirements as defined in the legal section of Packaging  
 Guidelines.
[x]: License field in the package spec file matches the actual license. 
 Note: Checking patched sources after %prep for licenses. Licenses  
 found: "BSD (3 clause)", "BSD (unspecified)", "Unknown or generated".  
 49 files have unknown license. Detailed output of licensecheck in  
 /home/rbarlow/reviews/1421406-python-libtmux/licensecheck.txt  
[x]: License file installed when any subpackage combination is installed.   
[x]: Package contains no bundled libraries without FPC exception.   
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.  
[-]: Package contains desktop file if it is a GUI application.  
[-]: Development files must be in a -devel package  
[x]: Package uses nothing in %doc for runtime.  
[x]: Package consistently uses macros (instead of hard-coded directory  
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 20480 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

[Bug 1421406] Review Request: python-libtmux - Scripting library for tmux

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1421406

David Roble  changed:

   What|Removed |Added

  Flags|needinfo?(robled@electronsw |
   |eatshop.com)|



--- Comment #2 from David Roble  ---
Linked specfile and srpm has been updated per change requests.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1421406] Review Request: python-libtmux - Scripting library for tmux

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1421406

Randy Barlow  changed:

   What|Removed |Added

 CC||rob...@electronsweatshop.co
   ||m
  Flags||needinfo?(robled@electronsw
   ||eatshop.com)



--- Comment #1 from Randy Barlow  ---
Here are things we must fix before this can be approved:

* You can't use macros in the changelog because they will change over time.
i.e.,
  you have the %{version} in there, but the next time you make a release your
  changelog for this release will change. You should instead hardcode 0.6.0-1
  there.

* Your python2- and python3- subpackages do not Require tmux like they should.
  The Require line applies to a non-existing python-tmux subpackage. I suggest
  deleting that line and copying it into the two %package -n sections so they
  each Require tmux.


These things are suggestions, and are at your option:

* The quotes in your desc global are literally going into the RPM descriptions.
  They aren't needed, so I suggest dropping them.

* Should the ' character be followed by an s after in "tmux' target…" in the
  description?

* You have a misleading comment in your install section about doing the py2
  install first due to scripts in /usr/bin - there are no scripts in /usr/bin.
I
  suggest dropping this comment.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1421406] Review Request: python-libtmux - Scripting library for tmux

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1421406

Randy Barlow  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||ra...@electronsweatshop.com
   Assignee|nob...@fedoraproject.org|ra...@electronsweatshop.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org