[Bug 1421858] Review Request: flannel-container - system container for flannel
https://bugzilla.redhat.com/show_bug.cgi?id=1421858 Yu Qi Zhang changed: What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |NEXTRELEASE Last Closed||2017-02-24 12:08:18 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1421858] Review Request: flannel-container - system container for flannel
https://bugzilla.redhat.com/show_bug.cgi?id=1421858 --- Comment #5 from Jon Ciesla --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/docker/flannel -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1421858] Review Request: flannel-container - system container for flannel
https://bugzilla.redhat.com/show_bug.cgi?id=1421858 container-rev...@lists.fedoraproject.org changed: What|Removed |Added CC||container-rev...@lists.fedo ||raproject.org --- Comment #4 from container-rev...@lists.fedoraproject.org --- Sponsored. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1421858] Review Request: flannel-container - system container for flannel
https://bugzilla.redhat.com/show_bug.cgi?id=1421858 Tomas Tomecek changed: What|Removed |Added Status|ASSIGNED|MODIFIED Flags|fedora-review? |fedora-review+ --- Comment #3 from Tomas Tomecek --- LGTM -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1421858] Review Request: flannel-container - system container for flannel
https://bugzilla.redhat.com/show_bug.cgi?id=1421858 --- Comment #2 from Yu Qi Zhang --- Thanks! The fixes to the above highlighted issues have been merged. PTAL. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1421858] Review Request: flannel-container - system container for flannel
https://bugzilla.redhat.com/show_bug.cgi?id=1421858 --- Comment #1 from Tomas Tomecek --- https://github.com/projectatomic/atomic-system-containers/blob/master/flannel/Dockerfile#L1 > FROM fedora Please pin to a specific fedora version, as described in guidelines. https://fedoraproject.org/wiki/Container:Guidelines#CMD_.2F_ENTRYPOINT https://github.com/projectatomic/atomic-system-containers/blob/master/flannel/Dockerfile#L5 > ENV container=docker > ENV FLANNELD_ETCD_ENDPOINTS="http://127.0.0.1:2379"; > ... Chain these, so they are within a single instruction. LABEL on line 10 does it right. It would also be great to have some documentation inside container how should one use it. Anyway, well done. I haven't found any serious issues. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1421858] Review Request: flannel-container - system container for flannel
https://bugzilla.redhat.com/show_bug.cgi?id=1421858 Tomas Tomecek changed: What|Removed |Added Status|NEW |ASSIGNED CC||ttome...@redhat.com Assignee|nob...@fedoraproject.org|ttome...@redhat.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1421858] Review Request: flannel-container - system container for flannel
https://bugzilla.redhat.com/show_bug.cgi?id=1421858 Yu Qi Zhang changed: What|Removed |Added Blocks||177841 (FE-NEEDSPONSOR) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
