[Bug 1424798] Review Request: xed - X-Apps [Text] Editor (Cross-DE, backward-compatible, GTK3, traditional UI)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1424798



--- Comment #16 from Fedora Update System  ---
xed-1.2.2-1.fc25 has been pushed to the Fedora 25 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1424798] Review Request: xed - X-Apps [Text] Editor (Cross-DE, backward-compatible, GTK3, traditional UI)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1424798

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-03-02 22:49:51



--- Comment #15 from Fedora Update System  ---
xed-1.2.2-1.fc24 has been pushed to the Fedora 24 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1424798] Review Request: xed - X-Apps [Text] Editor (Cross-DE, backward-compatible, GTK3, traditional UI)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1424798



--- Comment #14 from Fedora Update System  ---
xed-1.2.2-1.fc25 has been pushed to the Fedora 25 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-3149a3b8d0

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1424798] Review Request: xed - X-Apps [Text] Editor (Cross-DE, backward-compatible, GTK3, traditional UI)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1424798

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #13 from Fedora Update System  ---
xed-1.2.2-1.fc24 has been pushed to the Fedora 24 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-72f325ca2a

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1424798] Review Request: xed - X-Apps [Text] Editor (Cross-DE, backward-compatible, GTK3, traditional UI)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1424798

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1424798] Review Request: xed - X-Apps [Text] Editor (Cross-DE, backward-compatible, GTK3, traditional UI)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1424798



--- Comment #11 from Fedora Update System  ---
xed-1.2.2-1.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-3149a3b8d0

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1424798] Review Request: xed - X-Apps [Text] Editor (Cross-DE, backward-compatible, GTK3, traditional UI)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1424798



--- Comment #12 from Fedora Update System  ---
xed-1.2.2-1.fc24 has been submitted as an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-72f325ca2a

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1424798] Review Request: xed - X-Apps [Text] Editor (Cross-DE, backward-compatible, GTK3, traditional UI)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1424798



--- Comment #10 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/xed

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1424798] Review Request: xed - X-Apps [Text] Editor (Cross-DE, backward-compatible, GTK3, traditional UI)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1424798



--- Comment #9 from Björn "besser82" Esser  ---
(In reply to Mario Blättermann from comment #7)
> Release:  0.3%{?dist}
> 
> What's the reason to use such a construction for the release number? I can't
> found anything in the guidelines [1] which applies to that.
> 
> [1] https://fedoraproject.org/wiki/Packaging:DistTag

I usually use 0.XY releases during review and bump to regular release-schema on
scm-import.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1424798] Review Request: xed - X-Apps [Text] Editor (Cross-DE, backward-compatible, GTK3, traditional UI)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1424798

Björn "besser82" Esser  changed:

   What|Removed |Added

 Status|NEW |POST



--- Comment #8 from Björn "besser82" Esser  ---
Thank you for the review!  =)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1424798] Review Request: xed - X-Apps [Text] Editor (Cross-DE, backward-compatible, GTK3, traditional UI)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1424798



--- Comment #7 from Mario Blättermann  ---
Release:0.3%{?dist}

What's the reason to use such a construction for the release number? I can't
found anything in the guidelines [1] which applies to that.

[1] https://fedoraproject.org/wiki/Packaging:DistTag

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1424798] Review Request: xed - X-Apps [Text] Editor (Cross-DE, backward-compatible, GTK3, traditional UI)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1424798

leigh scott  changed:

   What|Removed |Added

  Flags||fedora-review+



--- Comment #6 from leigh scott  ---
Approved

Please fix the ownership issue on

%doc %{_datadir}/gtk-doc

change it to 

%doc %{_datadir}/gtk-doc/html/%{name}

when you import it


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- glib-compile-schemas is run in %postun and %posttrans if package has
  *.gschema.xml files.
  Note: gschema file(s) in xed
  See:
  http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#GSettings_Schema
- update-desktop-database is invoked in %post and %postun if package
  contains desktop file(s) with a MimeType: entry.
  Note: desktop file(s) with MimeType entry in xed
  See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#desktop-
  database


= MUST items =

C/C++:
[-]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[-]: Development (unversioned) .so files in -devel subpackage, if present.
 Note: Unversioned so-files in private %_libdir subdirectory (see
 attachment). Verify they are not in ld path.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "*No copyright* GPL (v2 or later) (with incorrect FSF
 address)", "LGPL (v2 or later)", "GPL (v2 or later)", "*No copyright*
 GPL (v2)", "Unknown or generated", "*No copyright* GPL (v2 or later)".
 264 files have unknown license. Detailed output of licensecheck in
 /home/leigh/Desktop/1424798-xed/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package requires other packages for directories it uses.
 Note: No known owner of /usr/share/help/ar, /usr/share/help/th
[x]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/share/help/fi,
 /usr/share/help/uk, /usr/share/help/de, /usr/share/help/da,
 /usr/share/help/sv, /usr/share/help/hu, /usr/share/help/fr,
 /usr/share/help/C, /usr/share/help/zh_HK, /usr/share/help/ja,
 /usr/share/help/es, /usr/share/help/cs, /usr/share/help/ar,
 /usr/share/help/ca, /usr/share/help/el, /usr/share/help/zh_CN,
 /usr/share/help/pt_BR, /usr/share/help/oc, /usr/share/help/it,
 /usr/share/help/th, /usr/share/help/zh_TW, /usr/share/help/ko,
 /usr/share/help/bg, /usr/share/help/ru
[!]: Package does not own files or directories owned by other packages.
 Note: Dirs in package are owned also by: /usr/share/gtk-doc(gnome-
 desktop3-devel, libgnome-keyring-devel, libsecret-devel, gcr-devel,
 polkit-docs, p11-kit-devel, libpeas-devel, harfbuzz-devel,
 libcanberra-devel, json-glib-devel, clutter-gst3-devel, libgdata-
 devel, gnome-bluetooth-libs-devel, gtk-doc), /usr/share/gtk-doc/html
 (gnome-desktop3-devel, libgnome-keyring-devel, libsecret-devel, gcr-
 devel, polkit-docs, p11-kit-devel, libpeas-devel, harfbuzz-devel,
 libcanberra-devel, json-glib-devel, clutter-gst3-devel, libgdata-
 devel, gnome-bluetooth-libs-devel, gtk-doc)
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: The spec file handles locales properly.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[?]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 3 files.
[x]: Package complies to the 

[Bug 1424798] Review Request: xed - X-Apps [Text] Editor (Cross-DE, backward-compatible, GTK3, traditional UI)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1424798



--- Comment #5 from Björn "besser82" Esser  ---
(In reply to leigh scott from comment #4)
> You can remove  these as gnome-common requires them
> 
> BuildRequires:autoconf
> BuildRequires:automake
> BuildRequires:gettext
> 
> The package requires gschema scriptlets
> 
> %{_datadir}/glib-2.0/schemas/org.x.editor.*gschema.xml
> 
> 
> You also have a directory ownership issue on
> 
> %{_datadir}/help
> 
> change it to 
> 
> 
> %{_datadir}/help/*/%{name}/
> 
> 
> Do we really need the debian bits?
> 
> %license AUTHORS COPYING debian/copyright
> %doc ChangeLog README debian/changelog

See:  https://bugzilla.redhat.com/show_bug.cgi?id=1424825#c5

***

Updated package:

Urls:

  Spec URL:  https://pagure.io/besser82/package-review/raw/master/f/xed.spec
  SRPM URL: 
https://pagure.io/besser82/package-review/raw/master/f/xed-1.2.2-0.3.fc26.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1424798] Review Request: xed - X-Apps [Text] Editor (Cross-DE, backward-compatible, GTK3, traditional UI)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1424798

leigh scott  changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|leigh123li...@googlemail.co
   ||m



--- Comment #4 from leigh scott  ---
You can remove  these as gnome-common requires them

BuildRequires:autoconf
BuildRequires:automake
BuildRequires:gettext

The package requires gschema scriptlets

%{_datadir}/glib-2.0/schemas/org.x.editor.*gschema.xml


You also have a directory ownership issue on

%{_datadir}/help

change it to 


%{_datadir}/help/*/%{name}/


Do we really need the debian bits?

%license AUTHORS COPYING debian/copyright
%doc ChangeLog README debian/changelog

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1424798] Review Request: xed - X-Apps [Text] Editor (Cross-DE, backward-compatible, GTK3, traditional UI)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1424798



--- Comment #3 from Björn "besser82" Esser  ---
Updated package:

Urls:

  Spec URL:  https://pagure.io/besser82/package-review/raw/master/f/xed.spec
  SRPM URL: 
https://pagure.io/besser82/package-review/raw/master/f/xed-1.2.2-0.2.fc26.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1424798] Review Request: xed - X-Apps [Text] Editor (Cross-DE, backward-compatible, GTK3, traditional UI)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1424798

Björn "besser82" Esser  changed:

   What|Removed |Added

 CC||mario.blaetterm...@gmail.co
   ||m



--- Comment #2 from Björn "besser82" Esser  ---
*** Bug 1358699 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1424798] Review Request: xed - X-Apps [Text] Editor (Cross-DE, backward-compatible, GTK3, traditional UI)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1424798

Björn "besser82" Esser  changed:

   What|Removed |Added

 Blocks||1359390




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1359390
[Bug 1359390] Cinnamon X-apps
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1424798] Review Request: xed - X-Apps [Text] Editor (Cross-DE, backward-compatible, GTK3, traditional UI)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1424798

Björn "besser82" Esser  changed:

   What|Removed |Added

  Alias||xed



--- Comment #1 from Björn "besser82" Esser  ---
Moved files to pagure-repo:

Urls:

  Spec URL:  https://pagure.io/besser82/package-review/raw/master/f/xed.spec
  SRPM URL: 
https://pagure.io/besser82/package-review/raw/master/f/xed-1.2.2-0.1.fc26.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org