[Bug 1424963] Review Request: gnome-shell-extension-ibus-font - use to change ibus font style.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1424963

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-09-30 02:27:00



--- Comment #13 from Fedora Update System  ---
gnome-shell-extension-ibus-font-0.20170217-2.fc27 has been pushed to the Fedora
27 stable repository. If problems still persist, please make note of it in this
bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1424963] Review Request: gnome-shell-extension-ibus-font - use to change ibus font style.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1424963

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #12 from Fedora Update System  ---
gnome-shell-extension-ibus-font-0.20170217-2.fc27 has been pushed to the Fedora
27 testing repository. If problems still persist, please make note of it in
this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-ddfc7765a6

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1424963] Review Request: gnome-shell-extension-ibus-font - use to change ibus font style.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1424963

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1424963] Review Request: gnome-shell-extension-ibus-font - use to change ibus font style.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1424963



--- Comment #11 from Fedora Update System  ---
gnome-shell-extension-ibus-font-0.20170217-2.fc27 has been submitted as an
update to Fedora 27.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-ddfc7765a6

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1424963] Review Request: gnome-shell-extension-ibus-font - use to change ibus font style.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1424963



--- Comment #10 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/gnome-shell-extension-ibus-font. You may
commit to the branch "f27" in about 10 minutes.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1424963] Review Request: gnome-shell-extension-ibus-font - use to change ibus font style.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1424963

Parag AN(पराग)  changed:

   What|Removed |Added

 Blocks|177841 (FE-NEEDSPONSOR) |
  Flags|fedora-review?  |fedora-review+
   |needinfo?(kaiw...@redhat.co |
   |m)  |



--- Comment #9 from Parag AN(पराग)  ---
Okay. I am approving the SRPM submitted by Kaiwang in comment#3


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1424963] Review Request: gnome-shell-extension-ibus-font - use to change ibus font style.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1424963



--- Comment #8 from Peng Wu  ---
I want to own this package.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1424963] Review Request: gnome-shell-extension-ibus-font - use to change ibus font style.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1424963

Parag AN(पराग)  changed:

   What|Removed |Added

 CC||kaiw...@redhat.com
  Flags||needinfo?(kaiw...@redhat.co
   ||m)



--- Comment #7 from Parag AN(पराग)  ---
Any updates here?
If not in next 2 weeks then I will close this review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1424963] Review Request: gnome-shell-extension-ibus-font - use to change ibus font style.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1424963



--- Comment #6 from Parag AN(पराग)  ---
Please do few more full package reviews where you can find some issues and
provide fixes for that. I know this can be much work for a new contributors but
that is how they can get familiar with the Fedora packaging. So keep reviewing
packages. You can also check this to suggest any rpmlint issue fixes ->
https://fedoraproject.org/wiki/Packaging_tricks

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1424963] Review Request: gnome-shell-extension-ibus-font - use to change ibus font style.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1424963



--- Comment #5 from kaiwang  ---
Here are some packages I reviewed:

https://bugzilla.redhat.com/show_bug.cgi?id=1411053
https://bugzilla.redhat.com/show_bug.cgi?id=1328248

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1424963] Review Request: gnome-shell-extension-ibus-font - use to change ibus font style.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1424963



--- Comment #4 from Parag AN(पराग)  ---
To get sponsor for your package in packager group, please follow these things.

We have this process, 
http://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group to 
get sponsored into the packager group. Can you either submit few more packages 
and/or some full detailed package reviews? This is needed to make sure package 
submitter understands the rpm packaging well and follows the fedora packaging 
guidelines.

Please go through the following links
1) http://fedoraproject.org/wiki/Package_Review_Process

2) https://fedoraproject.org/wiki/PackagingGuidelines

3) To find the packages already submitted for review,
   check http://fedoraproject.org/PackageReviewStatus/

4) http://fedoraproject.org/wiki/Packaging:ReviewGuidelines and
   http://fedoraproject.org/wiki/Package_Review_Process#Reviewer is useful 
   while doing package reviews.

5) https://fedorahosted.org/FedoraReview/ this is fedora-review tool to help
   review packages in fedora. You need to use this and do un-official package 
   reviews of packages submitted by other contributors. While doing so mention 
   "This is un-official review of the package." at top of your review comment.

Good to review packages listed in
http://fedoraproject.org/PackageReviewStatus/NEW.html

When you do full package review of some packages, provide that review comment 
link here so that I can look how you have reviewed those packages. An example
command to run fedora-review on any package review bugzilla is
fedora-review -b  -m fedora-rawhide-x86_64

If you got any questions please ask here or on Freenode IRC join #fedora-devel
:)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1424963] Review Request: gnome-shell-extension-ibus-font - use to change ibus font style.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1424963



--- Comment #3 from kaiwang  ---
Spec URL:
https://raw.githubusercontent.com/kermitwk/rpm-packaging/master/gnome-shell-extension-ibus-font.spec
SRPM URL:
https://raw.githubusercontent.com/kermitwk/rpm-packaging/master/gnome-shell-extension-ibus-font-0.20170217-1.fc25.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1424963] Review Request: gnome-shell-extension-ibus-font - use to change ibus font style.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1424963

Parag AN(पराग)  changed:

   What|Removed |Added

 Blocks||177841 (FE-NEEDSPONSOR)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1424963] Review Request: gnome-shell-extension-ibus-font - use to change ibus font style.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1424963



--- Comment #2 from Parag AN(पराग)  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed

Issues to Fix:
1) "rpmlint -iv *.rpm" gives
gnome-shell-extension-ibus-font.src: W: summary-not-capitalized C use ibus font
setting of ibus setup dialog to enhance the user experience

gnome-shell-extension-ibus-font.noarch: W: summary-not-capitalized C use ibus
font setting of ibus setup dialog to enhance the user experience
=> This can be fixed as explained above. Also, Good to keep short Summary say
"A GNOME Shell extension for ibus-setup custom font settings" 

Fix this and provide new updated package links. No need to bump the release
tag.


= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Unknown or generated". 5 files have unknown license. Detailed
 output of licensecheck in /home/parag/1424963-gnome-shell-extension-
 ibus-font/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
 architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
 files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
 

[Bug 1424963] Review Request: gnome-shell-extension-ibus-font - use to change ibus font style.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1424963



--- Comment #1 from kaiwang  ---
Spec URL:
https://raw.githubusercontent.com/kermitwk/rpm-packaging/master/gnome-shell-extension-ibus-font.spec
SRPM URL:
https://raw.githubusercontent.com/kermitwk/rpm-packaging/master/gnome-shell-extension-ibus-font-0.20170217-1.fc25.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1424963] Review Request: gnome-shell-extension-ibus-font - use to change ibus font style.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1424963

Parag AN(पराग)  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1424963] Review Request: gnome-shell-extension-ibus-font - use to change ibus font style.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1424963

Peng Wu  changed:

   What|Removed |Added

 CC||p...@redhat.com
   Assignee|nob...@fedoraproject.org|panem...@gmail.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org