[Bug 1428562] Review Request: golang-github-d4l3k-messagediff - Generate diffs of arbitrary structs in Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1428562



--- Comment #9 from Fedora Update System  ---
golang-github-d4l3k-messagediff-1.1.0-0.1.git2fe2a1d.fc24 has been pushed to
the Fedora 24 stable repository. If problems still persist, please make note of
it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1428562] Review Request: golang-github-d4l3k-messagediff - Generate diffs of arbitrary structs in Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1428562

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-03-14 13:22:07



--- Comment #8 from Fedora Update System  ---
golang-github-d4l3k-messagediff-1.1.0-0.1.git2fe2a1d.fc25 has been pushed to
the Fedora 25 stable repository. If problems still persist, please make note of
it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1428562] Review Request: golang-github-d4l3k-messagediff - Generate diffs of arbitrary structs in Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1428562



--- Comment #7 from Fedora Update System  ---
golang-github-d4l3k-messagediff-1.1.0-0.1.git2fe2a1d.fc24 has been pushed to
the Fedora 24 testing repository. If problems still persist, please make note
of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-9f928a0434

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1428562] Review Request: golang-github-d4l3k-messagediff - Generate diffs of arbitrary structs in Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1428562

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #6 from Fedora Update System  ---
golang-github-d4l3k-messagediff-1.1.0-0.1.git2fe2a1d.fc25 has been pushed to
the Fedora 25 testing repository. If problems still persist, please make note
of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-01bf8d8c10

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1428562] Review Request: golang-github-d4l3k-messagediff - Generate diffs of arbitrary structs in Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1428562



--- Comment #4 from Fedora Update System  ---
golang-github-d4l3k-messagediff-1.1.0-0.1.git2fe2a1d.fc25 has been submitted as
an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-01bf8d8c10

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1428562] Review Request: golang-github-d4l3k-messagediff - Generate diffs of arbitrary structs in Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1428562

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1428562] Review Request: golang-github-d4l3k-messagediff - Generate diffs of arbitrary structs in Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1428562



--- Comment #5 from Fedora Update System  ---
golang-github-d4l3k-messagediff-1.1.0-0.1.git2fe2a1d.fc24 has been submitted as
an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-9f928a0434

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1428562] Review Request: golang-github-d4l3k-messagediff - Generate diffs of arbitrary structs in Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1428562



--- Comment #3 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/golang-github-d4l3k-messagediff

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1428562] Review Request: golang-github-d4l3k-messagediff - Generate diffs of arbitrary structs in Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1428562

Fabio Valentini  changed:

   What|Removed |Added

  Flags|needinfo?(decathorpe@gmail. |
   |com)|



--- Comment #2 from Fabio Valentini  ---
I removed the unnecessary Provides and the "example" folder from the package.
Same links.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1428562] Review Request: golang-github-d4l3k-messagediff - Generate diffs of arbitrary structs in Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1428562

Jan Chaloupka  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||decatho...@gmail.com,
   ||jchal...@redhat.com
   Assignee|nob...@fedoraproject.org|jchal...@redhat.com
  Flags||fedora-review+
   ||needinfo?(decathorpe@gmail.
   ||com)



--- Comment #1 from Jan Chaloupka  ---
I guess you can remove:
Provides:   golang(%{import_path}/example) = %{version}-%{release}
%gotest %{import_path}/example

Plus upgrade the installation scripts to skip the example directory.

The package is an example. Nothing that makes sense to import in other
projects. Unless proven otherwise.

Otherwise LGTM. Again, the nit is not a blocker.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1428562] Review Request: golang-github-d4l3k-messagediff - Generate diffs of arbitrary structs in Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1428562

Fabio Valentini  changed:

   What|Removed |Added

 Blocks||1427634




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1427634
[Bug 1427634] Review Request: syncthing - Continuous File Synchronization
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org