[Bug 1431298] Review Request: php-symfony3 - Symfony PHP framework ( version 3)
https://bugzilla.redhat.com/show_bug.cgi?id=1431298 Zbigniew Jędrzejewski-Szmek changed: What|Removed |Added Status|ASSIGNED|CLOSED CC||zbys...@in.waw.pl Fixed In Version||php-symfony3-3.2.11-1.fc27 Resolution|--- |RAWHIDE Last Closed||2017-07-28 04:38:58 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1431298] Review Request: php-symfony3 - Symfony PHP framework ( version 3)
https://bugzilla.redhat.com/show_bug.cgi?id=1431298 Shawn Iwinski changed: What|Removed |Added CC||fed...@famillecollet.com Alias||php-symfony3 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1431298] Review Request: php-symfony3 - Symfony PHP framework ( version 3)
https://bugzilla.redhat.com/show_bug.cgi?id=1431298 James Hogarth changed: What|Removed |Added CC||james.hoga...@gmail.com Assignee|nob...@fedoraproject.org|james.hoga...@gmail.com -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1431298] Review Request: php-symfony3 - Symfony PHP framework ( version 3)
https://bugzilla.redhat.com/show_bug.cgi?id=1431298 James Hogarth changed: What|Removed |Added Status|NEW |ASSIGNED Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1431298] Review Request: php-symfony3 - Symfony PHP framework ( version 3)
https://bugzilla.redhat.com/show_bug.cgi?id=1431298 --- Comment #1 from Shawn Iwinski --- Updated: * Allow Twig v1 and v2 Spec URL: https://raw.githubusercontent.com/siwinski/rpms/4a8f29b39f3e3cb1594279945e77f622a57fdc96/php-symfony3/php-symfony3.spec SRPM URL: https://siwinski.fedorapeople.org/SRPMS/php-symfony3-3.2.6-2.fc25.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1431298] Review Request: php-symfony3 - Symfony PHP framework ( version 3)
https://bugzilla.redhat.com/show_bug.cgi?id=1431298
James Hogarth changed:
What|Removed |Added
Flags|fedora-review? |fedora-review-
--- Comment #2 from James Hogarth ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
Issues:
===
- Package fails to install
* There is a requirement on php-symfony3-phpunit-bridge but this subpackage
is commented out and not built
- License in header missing CC-BY-SA for ICONS_LICENSE
* Need to update license field in spec to include this
- Directory ownership flag is false negative due to global var usage.
* No issue
- Description in packages has wrong auto loader location as it refers to the
existing php symfony location and doesn't use %{symfony3_dir}
* This needs to point to the correct autoloader
- Requires on web-profiler-bundle has wrong ver on polyfill-php70
* Specifies %{version} and not the min/max polyfill version so it cannot be
installed
- Assuming package works as check tests pass
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[!]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "MIT/X11 (BSD like)", "BSD (2 clause)", "*No copyright* CC by-
sa (v3.0)", "Unknown or generated". 5484 files have unknown license.
Detailed output of licensecheck in /home/james/workspace/fedora-
scm/1431298-php-symfony3/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/share/php/Symfony3,
/usr/share/php, /usr/share/php/Symfony3/Bridge,
/usr/share/php/Symfony3/Bundle, /usr/share/php/Symfony3/Component
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[!]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[?]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 808960 bytes in 134 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[!]: Final provides and requires are sane (see at
[Bug 1431298] Review Request: php-symfony3 - Symfony PHP framework ( version 3)
https://bugzilla.redhat.com/show_bug.cgi?id=1431298 James Hogarth changed: What|Removed |Added Blocks||1433919 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1433919 [Bug 1433919] Version 11.0.2 is avaliable -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1431298] Review Request: php-symfony3 - Symfony PHP framework ( version 3)
https://bugzilla.redhat.com/show_bug.cgi?id=1431298 --- Comment #3 from Shawn Iwinski --- Updated: - Modified main package and web-profiler-bundle sub-package licenses from "MIT" to "MIT and CC-BY-SA" - Removed phpunit-bridge dependency from main package - Fixed web-profiler-bundle sub-package's polyfill-php70 dependency versions - Fixed autoloader locations in descriptions Diff: https://github.com/siwinski/rpms/commit/d5126fdddf6f003587f6a507aa6f847fc1225b0a Spec URL: https://raw.githubusercontent.com/siwinski/rpms/d5126fdddf6f003587f6a507aa6f847fc1225b0a/php-symfony3/php-symfony3.spec SRPM URL: https://siwinski.fedorapeople.org/SRPMS/php-symfony3-3.2.6-3.fc25.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1431298] Review Request: php-symfony3 - Symfony PHP framework ( version 3)
https://bugzilla.redhat.com/show_bug.cgi?id=1431298 James Hogarth changed: What|Removed |Added Flags|fedora-review- |fedora-review+ --- Comment #4 from James Hogarth --- Thanks for the changes, tested parallel install with symfony fine as well. On the basis of that this package is now APPROVED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1431298] Review Request: php-symfony3 - Symfony PHP framework ( version 3)
https://bugzilla.redhat.com/show_bug.cgi?id=1431298 --- Comment #5 from Gwyn Ciesla --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/php-symfony3 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
