[Bug 1431426] Review Request: python-dbfread - Read DBF Files with Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431426



--- Comment #15 from Fedora Update System  ---
python-dbfread-2.0.7-3.git300b2d7.fc25 has been pushed to the Fedora 25 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431426] Review Request: python-dbfread - Read DBF Files with Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431426

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-04-09 12:42:22



--- Comment #14 from Fedora Update System  ---
python-dbfread-2.0.7-3.git300b2d7.fc26 has been pushed to the Fedora 26 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431426] Review Request: python-dbfread - Read DBF Files with Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431426



--- Comment #13 from Fedora Update System  ---
python-dbfread-2.0.7-3.git300b2d7.fc26 has been pushed to the Fedora 26 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-26e7b2980b

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431426] Review Request: python-dbfread - Read DBF Files with Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431426

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #12 from Fedora Update System  ---
python-dbfread-2.0.7-3.git300b2d7.fc25 has been pushed to the Fedora 25 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-9996b7466a

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431426] Review Request: python-dbfread - Read DBF Files with Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431426



--- Comment #11 from Fedora Update System  ---
python-dbfread-2.0.7-3.git300b2d7.fc25 has been submitted as an update to
Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-9996b7466a

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431426] Review Request: python-dbfread - Read DBF Files with Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431426

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431426] Review Request: python-dbfread - Read DBF Files with Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431426



--- Comment #10 from Fedora Update System  ---
python-dbfread-2.0.7-3.git300b2d7.fc26 has been submitted as an update to
Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-26e7b2980b

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431426] Review Request: python-dbfread - Read DBF Files with Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431426



--- Comment #9 from Gwyn Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/python-dbfread

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431426] Review Request: python-dbfread - Read DBF Files with Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431426



--- Comment #8 from Julien Enselme  ---
> Please fix the shebangs before submitting the package.

Will do.

Thanks for the review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431426] Review Request: python-dbfread - Read DBF Files with Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431426

Dhanesh B. Sabane  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431426] Review Request: python-dbfread - Read DBF Files with Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431426

Dhanesh B. Sabane  changed:

   What|Removed |Added

 Status|NEW |POST



--- Comment #7 from Dhanesh B. Sabane  ---
(In reply to Julien Enselme from comment #2)
> > The mock build fails.
> 
> I missed a build requires, sorry. This should be fixed:
> 
> Spec URL: http://dl.jujens.eu/SPECS/python-dbfread.spec
> SRPM URL:
> http://dl.jujens.eu/SRPMS/python-dbfread-2.0.7-2.git300b2d7.fc25.src.rpm

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[-]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 20480 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[ ]: Python eggs must not download any dependencies during the build
 process.
[ ]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

= SHOULD items =

Generic:
[!]: Uses parallel make %{?_smp_mflags} macro.
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[ ]: Fully versioned dependency in subpackages if applicable.
 Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
 python2-dbfread , python3-dbfread , python-dbfread-doc
[ ]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
 architectures.
[x]: %check is present and all tests pass.
[ ]: Packages should try to preserve timestamps of original installed
 files.
[x]: Reviewer should test that the package builds in mock.
[x]: 

[Bug 1431426] Review Request: python-dbfread - Read DBF Files with Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431426

Dhanesh B. Sabane  changed:

   What|Removed |Added

  Flags||fedora-review?



--- Comment #6 from Dhanesh B. Sabane  ---
(In reply to Julien Enselme from comment #2)
> I missed a build requires, sorry. This should be fixed:
> 
> Spec URL: http://dl.jujens.eu/SPECS/python-dbfread.spec
> SRPM URL:
> http://dl.jujens.eu/SRPMS/python-dbfread-2.0.7-2.git300b2d7.fc25.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431426] Review Request: python-dbfread - Read DBF Files with Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431426

Dhanesh B. Sabane  changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|dhanes...@disroot.org



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431426] Review Request: python-dbfread - Read DBF Files with Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431426



--- Comment #5 from Julien Enselme  ---
> If the packager is fine with waiting for a couple of weeks, I can take it up

I don't mind waiting. My conclusion of this is: Whoever wants to review this
package can ;-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431426] Review Request: python-dbfread - Read DBF Files with Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431426



--- Comment #4 from Dhanesh B. Sabane  ---
(In reply to Zbigniew Jędrzejewski-Szmek from comment #3)
> Dhanesh, do you plan to take this review?

No. You can go ahead with it. I'm currently busy with academics.

P.S: If the packager is fine with waiting for a couple of weeks, I can take it
up. :P

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431426] Review Request: python-dbfread - Read DBF Files with Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431426

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 CC||zbys...@in.waw.pl



--- Comment #3 from Zbigniew Jędrzejewski-Szmek  ---
Dhanesh, do you plan to take this review?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431426] Review Request: python-dbfread - Read DBF Files with Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431426



--- Comment #2 from Julien Enselme  ---
> The mock build fails.

I missed a build requires, sorry. This should be fixed:

Spec URL: http://dl.jujens.eu/SPECS/python-dbfread.spec
SRPM URL:
http://dl.jujens.eu/SRPMS/python-dbfread-2.0.7-2.git300b2d7.fc25.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431426] Review Request: python-dbfread - Read DBF Files with Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431426

Dhanesh B. Sabane  changed:

   What|Removed |Added

 CC||dhanes...@disroot.org



--- Comment #1 from Dhanesh B. Sabane  ---
Disclaimer : I'm not a packager yet. So this is an unofficial review.

The mock build fails. Here's an excerpt from the build.log :

+ pushd docs
~/build/BUILD/dbfread-300b2d7d907388cc3578d3fa4472e0419ccd34b9/docs
~/build/BUILD/dbfread-300b2d7d907388cc3578d3fa4472e0419ccd34b9
+ make html
sphinx-build -b html -d _build/doctrees   . _build/html
make: sphinx-build: Command not found
Makefile:45: recipe for target 'html' failed
make: *** [html] Error 127

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431426] Review Request: python-dbfread - Read DBF Files with Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431426

Julien Enselme  changed:

   What|Removed |Added

 Blocks||1431427




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1431427
[Bug 1431427] Review Request: python-agate-dbf - Adds read support for DBF
files to agate
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org