[Bug 1431735] Review Request: golang-github-cznic-sortutil - Supplemental utilities for Go' s sort package
https://bugzilla.redhat.com/show_bug.cgi?id=1431735 --- Comment #13 from Fedora Update System--- golang-github-cznic-sortutil-0-0.1.git4c73428.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1431735] Review Request: golang-github-cznic-sortutil - Supplemental utilities for Go' s sort package
https://bugzilla.redhat.com/show_bug.cgi?id=1431735 --- Comment #12 from Fedora Update System--- golang-github-cznic-sortutil-0-0.1.git4c73428.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1431735] Review Request: golang-github-cznic-sortutil - Supplemental utilities for Go' s sort package
https://bugzilla.redhat.com/show_bug.cgi?id=1431735 Fedora Update Systemchanged: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2017-04-09 12:42:08 --- Comment #11 from Fedora Update System --- golang-github-cznic-sortutil-0-0.1.git4c73428.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1431735] Review Request: golang-github-cznic-sortutil - Supplemental utilities for Go' s sort package
https://bugzilla.redhat.com/show_bug.cgi?id=1431735 --- Comment #10 from Fedora Update System--- golang-github-cznic-sortutil-0-0.1.git4c73428.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-759be82f1b -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1431735] Review Request: golang-github-cznic-sortutil - Supplemental utilities for Go' s sort package
https://bugzilla.redhat.com/show_bug.cgi?id=1431735 --- Comment #9 from Fedora Update System--- golang-github-cznic-sortutil-0-0.1.git4c73428.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-b7696240e0 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1431735] Review Request: golang-github-cznic-sortutil - Supplemental utilities for Go' s sort package
https://bugzilla.redhat.com/show_bug.cgi?id=1431735 Fedora Update Systemchanged: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #8 from Fedora Update System --- golang-github-cznic-sortutil-0-0.1.git4c73428.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-ee335a33cd -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1431735] Review Request: golang-github-cznic-sortutil - Supplemental utilities for Go' s sort package
https://bugzilla.redhat.com/show_bug.cgi?id=1431735 --- Comment #7 from Fedora Update System--- golang-github-cznic-sortutil-0-0.1.git4c73428.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-b7696240e0 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1431735] Review Request: golang-github-cznic-sortutil - Supplemental utilities for Go' s sort package
https://bugzilla.redhat.com/show_bug.cgi?id=1431735 Bug 1431735 depends on bug 1431587, which changed state. Bug 1431587 Summary: Review Request: golang-github-cznic-mathutil - Supplemental utilities for Go's rand and math packages https://bugzilla.redhat.com/show_bug.cgi?id=1431587 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1431735] Review Request: golang-github-cznic-sortutil - Supplemental utilities for Go' s sort package
https://bugzilla.redhat.com/show_bug.cgi?id=1431735 --- Comment #6 from Fedora Update System--- golang-github-cznic-sortutil-0-0.1.git4c73428.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-ee335a33cd -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1431735] Review Request: golang-github-cznic-sortutil - Supplemental utilities for Go' s sort package
https://bugzilla.redhat.com/show_bug.cgi?id=1431735 --- Comment #5 from Fedora Update System--- golang-github-cznic-sortutil-0-0.1.git4c73428.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-759be82f1b -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1431735] Review Request: golang-github-cznic-sortutil - Supplemental utilities for Go' s sort package
https://bugzilla.redhat.com/show_bug.cgi?id=1431735 Fedora Update Systemchanged: What|Removed |Added Status|NEW |MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1431735] Review Request: golang-github-cznic-sortutil - Supplemental utilities for Go' s sort package
https://bugzilla.redhat.com/show_bug.cgi?id=1431735 --- Comment #4 from Gwyn Ciesla--- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/golang-github-cznic-sortutil -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1431735] Review Request: golang-github-cznic-sortutil - Supplemental utilities for Go' s sort package
https://bugzilla.redhat.com/show_bug.cgi?id=1431735 --- Comment #3 from Fabio Valentini--- Thanks for the review! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1431735] Review Request: golang-github-cznic-sortutil - Supplemental utilities for Go' s sort package
https://bugzilla.redhat.com/show_bug.cgi?id=1431735 Ben Rosserchanged: What|Removed |Added Flags||fedora-review+ --- Comment #2 from Ben Rosser --- Apologies; I meant to review these last week, but didn't have the time. Package is APPROVED, everything looks fine. This is a review *template*. Besides handling the [ ]-marked tests you are also supposed to fix the template before pasting into bugzilla: - Add issues you find to the list of issues on top. If there isn't such a list, create one. - Add your own remarks to the template checks. - Add new lines marked [!] or [?] when you discover new things not listed by fedora-review. - Change or remove any text in the template which is plain wrong. In this case you could also file a bug against fedora-review - Remove the "[ ] Manual check required", you will not have any such lines in what you paste. - Remove attachments which you deem not really useful (the rpmlint ones are mandatory, though) - Remove this text Package Review == Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed = MUST items = Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "BSD (2 clause)", "Unknown or generated". 6 files have unknown license. Detailed output of licensecheck in /home/bjr/Programming/fedora/reviews/1431735-golang-github-cznic- sortutil/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/gocode/src, /usr/share/gocode, /usr/share/gocode/src/github.com [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 6 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local = SHOULD items = Generic: [-]:
[Bug 1431735] Review Request: golang-github-cznic-sortutil - Supplemental utilities for Go' s sort package
https://bugzilla.redhat.com/show_bug.cgi?id=1431735 --- Comment #1 from Fabio Valentini--- Pinging reviewer. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1431735] Review Request: golang-github-cznic-sortutil - Supplemental utilities for Go' s sort package
https://bugzilla.redhat.com/show_bug.cgi?id=1431735 Ben Rosserchanged: What|Removed |Added CC||rosser@gmail.com Assignee|nob...@fedoraproject.org|rosser@gmail.com -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1431735] Review Request: golang-github-cznic-sortutil - Supplemental utilities for Go' s sort package
https://bugzilla.redhat.com/show_bug.cgi?id=1431735 Bug 1431735 depends on bug 1246526, which changed state. Bug 1246526 Summary: Review Request: golang-github-cznic-mathutil - Utilities supplemental to the Go standard "rand" and "math" packages https://bugzilla.redhat.com/show_bug.cgi?id=1246526 What|Removed |Added Status|NEW |CLOSED Resolution|--- |NOTABUG -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1431735] Review Request: golang-github-cznic-sortutil - Supplemental utilities for Go' s sort package
https://bugzilla.redhat.com/show_bug.cgi?id=1431735 Bug 1431735 depends on bug 1431587, which changed state. Bug 1431587 Summary: Review Request: golang-github-cznic-mathutil - Supplemental utilities for Go's rand and math packages https://bugzilla.redhat.com/show_bug.cgi?id=1431587 What|Removed |Added Status|CLOSED |ASSIGNED Resolution|DUPLICATE |--- -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1431735] Review Request: golang-github-cznic-sortutil - Supplemental utilities for Go' s sort package
https://bugzilla.redhat.com/show_bug.cgi?id=1431735 Bug 1431735 depends on bug 1431587, which changed state. Bug 1431587 Summary: Review Request: golang-github-cznic-mathutil - Supplemental utilities for Go's rand and math packages https://bugzilla.redhat.com/show_bug.cgi?id=1431587 What|Removed |Added Status|NEW |CLOSED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1431735] Review Request: golang-github-cznic-sortutil - Supplemental utilities for Go' s sort package
https://bugzilla.redhat.com/show_bug.cgi?id=1431735 Athos Ribeirochanged: What|Removed |Added Depends On||1246526 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1246526 [Bug 1246526] Review Request: golang-github-cznic-mathutil - Utilities supplemental to the Go standard "rand" and "math" packages -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1431735] Review Request: golang-github-cznic-sortutil - Supplemental utilities for Go' s sort package
https://bugzilla.redhat.com/show_bug.cgi?id=1431735 Fabio Valentinichanged: What|Removed |Added Blocks||1431745 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1431745 [Bug 1431745] Review Request: golang-github-cznic-lldb - Low-level database engine implementation in Go -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1431735] Review Request: golang-github-cznic-sortutil - Supplemental utilities for Go' s sort package
https://bugzilla.redhat.com/show_bug.cgi?id=1431735 Fabio Valentinichanged: What|Removed |Added Depends On||1431587 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1431587 [Bug 1431587] Review Request: golang-github-cznic-mathutil - Supplemental utilities for Go's rand and math packages -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org