[Bug 1437937] Review Request: libva-utils - Tools for VAAPI ( including vainfo)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1437937

Nicolas Chauvet (kwizart)  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |NEXTRELEASE
Last Closed||2017-04-04 15:52:41



--- Comment #9 from Nicolas Chauvet (kwizart)  ---
Thx for the review. License field added.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1437937] Review Request: libva-utils - Tools for VAAPI ( including vainfo)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1437937



--- Comment #8 from Gwyn Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/libva-utils

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1437937] Review Request: libva-utils - Tools for VAAPI ( including vainfo)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1437937



--- Comment #7 from Nicolas Chauvet (kwizart)  ---
(In reply to Mattia Verga from comment #6)
...
> All other aspects of the package are OK, so I'm going to APPROVE it. Just
> make sure of the license tag before importing in Fedora.
ACk

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1437937] Review Request: libva-utils - Tools for VAAPI ( including vainfo)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1437937

Mattia Verga  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #6 from Mattia Verga  ---
Well, if Fedora is going to redistribute the test suite in sources, the license
should note that.
I think we have two options: remove the test suite from sources or add the
double license "MIT and BSD". There are also some other files:
libva-utils-1.8.0/decode/loadjpeg.c
libva-utils-1.8.0/decode/tinyjpeg-internal.h
libva-utils-1.8.0/decode/tinyjpeg.c
libva-utils-1.8.0/decode/tinyjpeg.h
which are licensed BSD, so I think the best option is the double license.

All other aspects of the package are OK, so I'm going to APPROVE it. Just make
sure of the license tag before importing in Fedora.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1437937] Review Request: libva-utils - Tools for VAAPI ( including vainfo)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1437937



--- Comment #5 from Nicolas Chauvet (kwizart)  ---
Thanks for the review Mattia.

Most of theses files from the BSD licenses are from the test suite.
We don't enable the test suite as this would requires a given vaapi backend
implementation to be available from the builders. 
Also the test suite isn't meant to be redistributed.

About the old macros, I've submitted a PR upstream:
https://github.com/01org/libva-utils/pull/31 (test suite still pending).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1437937] Review Request: libva-utils - Tools for VAAPI ( including vainfo)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1437937



--- Comment #4 from Mattia Verga  ---
= MUST items =
[!]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "BSD (3 clause)", "Unknown or generated". 84 files have unknown
 license. Detailed output of licensecheck in /home/rpmbuild/1437937
 -libva-utils/licensecheck.txt

It seems that many files are licensed as BSD, there's also a BSD LICENSE file
under test/gtest. I think it's better to add a double license in .spec, or
maybe this should be clarified with upstream.

BSD (3 clause)
--
libva-utils-1.8.0/decode/loadjpeg.c
libva-utils-1.8.0/decode/tinyjpeg-internal.h
libva-utils-1.8.0/decode/tinyjpeg.c
libva-utils-1.8.0/decode/tinyjpeg.h
libva-utils-1.8.0/test/gtest/LICENSE
libva-utils-1.8.0/test/gtest/include/gtest/gtest-death-test.h
libva-utils-1.8.0/test/gtest/include/gtest/gtest-message.h
libva-utils-1.8.0/test/gtest/include/gtest/gtest-printers.h
libva-utils-1.8.0/test/gtest/include/gtest/gtest-spi.h
libva-utils-1.8.0/test/gtest/include/gtest/gtest-test-part.h
libva-utils-1.8.0/test/gtest/include/gtest/gtest-typed-test.h
libva-utils-1.8.0/test/gtest/include/gtest/gtest.h
libva-utils-1.8.0/test/gtest/include/gtest/gtest_prod.h
libva-utils-1.8.0/test/gtest/include/gtest/internal/custom/gtest-port.h
libva-utils-1.8.0/test/gtest/include/gtest/internal/custom/gtest-printers.h
libva-utils-1.8.0/test/gtest/include/gtest/internal/custom/gtest.h
libva-utils-1.8.0/test/gtest/include/gtest/internal/gtest-death-test-internal.h
libva-utils-1.8.0/test/gtest/include/gtest/internal/gtest-filepath.h
libva-utils-1.8.0/test/gtest/include/gtest/internal/gtest-internal.h
libva-utils-1.8.0/test/gtest/include/gtest/internal/gtest-linked_ptr.h
libva-utils-1.8.0/test/gtest/include/gtest/internal/gtest-param-util.h
libva-utils-1.8.0/test/gtest/include/gtest/internal/gtest-port-arch.h
libva-utils-1.8.0/test/gtest/include/gtest/internal/gtest-port.h
libva-utils-1.8.0/test/gtest/include/gtest/internal/gtest-string.h
libva-utils-1.8.0/test/gtest/include/gtest/internal/gtest-tuple.h.pump
libva-utils-1.8.0/test/gtest/src/gtest-all.cc
libva-utils-1.8.0/test/gtest/src/gtest-death-test.cc
libva-utils-1.8.0/test/gtest/src/gtest-filepath.cc
libva-utils-1.8.0/test/gtest/src/gtest-internal-inl.h
libva-utils-1.8.0/test/gtest/src/gtest-port.cc
libva-utils-1.8.0/test/gtest/src/gtest-printers.cc
libva-utils-1.8.0/test/gtest/src/gtest-test-part.cc
libva-utils-1.8.0/test/gtest/src/gtest-typed-test.cc
libva-utils-1.8.0/test/gtest/src/gtest.cc
libva-utils-1.8.0/test/gtest/src/gtest_main.cc


= EXTRA items =
[!]: Package should not use obsolete m4 macros
 Note: Some obsoleted macros found, see the attachment.
AutoTools: Obsoleted m4s found
--
  AC_PROG_LIBTOOL found in: libva-utils-1.8.0/configure.ac:99

Maybe this should be reported upstream.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1437937] Review Request: libva-utils - Tools for VAAPI ( including vainfo)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1437937



--- Comment #3 from Mattia Verga  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

C/C++:
[X]: Package does not contain kernel modules.
[X]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[X]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[!]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "BSD (3 clause)", "Unknown or generated". 84 files have unknown
 license. Detailed output of licensecheck in /home/rpmbuild/1437937
 -libva-utils/licensecheck.txt
[X]: License file installed when any subpackage combination is installed.
[X]: Package does not own files or directories owned by other packages.
 Note: Dirs in package are owned also by: /usr/lib/.build-
 id/b6(kactivitymanagerd, powerdevil, kernel-devel, kde-print-manager,
 libkscreen-qt5, abrt-addon-xorg, valgrind, kde-runtime-libs, libevent,
 kwin-common, python-gobject), /usr/lib/.build-id/42(libuser, kdelibs,
 ImageMagick-libs, kf5-kcrash, gtk3, samba-client), /usr/lib/.build-
 id(webkitgtk4-jsc, abrt-python3, cups-client, efivar-libs, gc,
 policycoreutils-python-utils, gdbm, poppler, gpgme, rpm-plugin-
 selinux, abrt, kgpg, libreport-plugin-systemd-journal, libqmi-utils,
 gtk3, libv4l, ksysguardd, kompare-libs, rpm-build, device-mapper-
 persistent-data, cryptsetup-libs, plasma-breeze, plasma-nm-openvpn,
 libselinux-utils, libblockdev-btrfs, gnome-disk-utility, bluez-libs,
 mesa-libwayland-egl, libblockdev-mdraid, libinput, libxslt, libreport-
 cli, plasma-workspace-drkonqi, system-config-printer-udev, abrt-gui-
 libs, keyutils-libs, python2-cryptography, libgpg-error, audit-libs-
 python3, kscreen, sane-backends-libs, plasma-nm, python2-rpm, adwaita-
 gtk2-theme, anaconda-core, plasma-integration, kdelibs-webkit,
 kdeplasma-addons, libkworkspace5, vte291, sssd-krb5, kcolorchooser,
 plasma-pa, qt5-style-oxygen, libsss_nss_idmap, qemu-guest-agent, sssd-
 common-pac, libblockdev-swap, giflib, libsmbclient, python3-gobject,
 plasma-user-manager, pam-kwallet, krb5-workstation, apper, kdepimlibs-
 akonadi, harfbuzz-devel, lazarus, drpm, libblockdev-utils, network-
 manager-applet, kamera, anaconda-widgets, sssd-ad, dolphin,
 keditbookmarks-libs, gcc, fpc, alsa-lib, abrt-libs, efibootmgr, mesa-
 dri-drivers, baloo-libs, samba-common-libs, libreswan, libreport-
 plugin-logger, gvfs-archive, libblockdev-kbd, python3-rpm, qupzilla,
 qt5-qttools-libs-designer, openssh-clients, libuser, perl-libs, abrt-
 retrace-client, mbedtls, boost-date-time, python3-cryptography,
 kactivitymanagerd, kwrited, satyr, xorg-x11-drv-ati, policycoreutils,
 abrt-plugin-bodhi, libbluray, poppler-qt5, kcharselect, krb5-devel,
 konsole5-part, powerdevil, python3-systemd, ibus-libs, libblockdev-
 mpath, mesa-libxatracker, audit-libs, nss-sysinit, bluez, libgcc,
 gettext-libs, system-python, polkit-kde, plasma-workspace-geolocation,
 abrt-gui, at-spi2-core, baloo-widgets, git, qt-x11, poppler-glib,
 kdepimlibs-gpgme, libkscreen-qt5, openssh, atk, libblockdev-lvm, ibus-
 gtk3, ibus-gtk2, perl-Net-SSLeay, cryptsetup, udisks2, ImageMagick,
 gssproxy, harfbuzz, cups, gtk-update-icon-cache, vim-minimal,
 harfbuzz-icu, libgfortran, libpkgconf, libplist, python3-wrapt, gvfs-
 client, NetworkManager-libnm, kwin-common, NetworkManager, kf5-kipi-
 plugins-libs, NetworkManager-glib, kcalc, kfind, authconfig, mesa-
 libGL, ksysguard, kscreenlocker, abrt-addon-ccpp, kruler, sddm-kcm,
 plasma-nm-openconnect, pcre-utf16, python-gobject, xfce4-notifyd,
 plasma-nm-openswan, PackageKit-gstreamer-plugin, libblockdev,
 spectacle, dconf, xorg-x11-drv-wacom, mesa-libgbm, liblogging-stdlog,
 samba-client-libs, python-gobject-base, boost-chrono, gwenview-libs,
 kompare, samba-client, sssd-nfs-idmap, kinfocenter, libwbclient,
 kdegraphics-thumbnailers, kio-extras, gpgmepp, gwenview, libquadmath,
 rpm-libs, kdelibs, libreport, gcc-gdb-plugin, libreport-gtk, nss-
 tools, lmdb-libs, libevent, kf5-libkdcraw, kde-print-manager, iproute,
 xmlrpc-c-client, plasma-desktop, konsole5, kwrite, libsss_idmap,
 gobject-introspection, boost-atomic, keyutils, python3-hawkey, os-
 prober, gcc-c++, libblockdev-dm, iproute-tc, NetworkManager-wifi, qt,
 kernel-core, kexec-tools, PackageKit-glib, krb5-libs, kwayland-
 integration, pkgconf, rpcbind, 

[Bug 1437937] Review Request: libva-utils - Tools for VAAPI ( including vainfo)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1437937

Mattia Verga  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||mattia.ve...@email.it
   Assignee|nob...@fedoraproject.org|mattia.ve...@email.it
  Flags||fedora-review?



--- Comment #2 from Mattia Verga  ---
I'm starting the review now...

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1437937] Review Request: libva-utils - Tools for VAAPI ( including vainfo)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1437937

Nicolas Chauvet (kwizart)  changed:

   What|Removed |Added

 Blocks||1437885




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1437885
[Bug 1437885] libva-1.8.0 is available
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1437937] Review Request: libva-utils - Tools for VAAPI ( including vainfo)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1437937



--- Comment #1 from Nicolas Chauvet (kwizart)  ---
This package is a split from upstream libva source archive.
The matching libva version is already commited in git, but not built.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org