[Bug 1438090] Review Request: GetIt - Application to send HTTP requests

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438090

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 CC||zbys...@in.waw.pl



--- Comment #4 from Zbigniew Jędrzejewski-Szmek  ---
Hm, what happened here?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1438090] Review Request: GetIt - Application to send HTTP requests

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438090

Bart Kessels  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |CURRENTRELEASE
Last Closed||2017-06-01 09:50:30



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1438090] Review Request: GetIt - Application to send HTTP requests

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438090

Jan Kalina  changed:

   What|Removed |Added

 CC||jkal...@redhat.com



--- Comment #3 from Jan Kalina  ---
(not official review)

Source0 is invalid - it resolves to "getit-1.2.tar.gz", but Github sends
"GetIt-1.1-1.fc26.src.rpm", so fedora-review and similar tools fails to build,
as they are not able to find downloaded file.

You should also attach ONLY ONE SRPM in one review request - as any review
should be against rawhide, it does not make sense to attach SRPMs for more
fedora releases.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1438090] Review Request: GetIt - Application to send HTTP requests

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438090



--- Comment #2 from Bart Kessels  ---
(In reply to iwicki.artur from comment #1)
> I am not a packager, so this is not an official review.
> 
> Your %files section does not include the %license.
> https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text

Thank you, just added the %license to the %files section.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1438090] Review Request: GetIt - Application to send HTTP requests

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438090

iwicki.ar...@svgames.pl changed:

   What|Removed |Added

 CC||iwicki.ar...@svgames.pl



--- Comment #1 from iwicki.ar...@svgames.pl ---
I am not a packager, so this is not an official review.

Your %files section does not include the %license.
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1438090] Review Request: GetIt - Application to send HTTP requests

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438090

Bart Kessels  changed:

   What|Removed |Added

 Blocks||177841 (FE-NEEDSPONSOR)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org