[Bug 1438842] Review Request: matrix-synapse - a Matrix reference homeserver written in Python using Twisted

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438842

Jeremy Cline  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 CC||jcl...@redhat.com
 Resolution|--- |RAWHIDE
Last Closed||2017-11-01 18:22:37



--- Comment #16 from Jeremy Cline  ---
Nope, I'm just sloppy. Sorry!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1438842] Review Request: matrix-synapse - a Matrix reference homeserver written in Python using Twisted

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438842

Adam Williamson  changed:

   What|Removed |Added

 CC||awill...@redhat.com



--- Comment #15 from Adam Williamson  ---
Is there a reason this review request ticket is still open, if the review is
complete and the package is imported?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1438842] Review Request: matrix-synapse - a Matrix reference homeserver written in Python using Twisted

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438842



--- Comment #14 from Stephen  ---
Great, thanks :)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1438842] Review Request: matrix-synapse - a Matrix reference homeserver written in Python using Twisted

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438842



--- Comment #13 from Jeremy Cline  ---
Okay, it's built for Fedora 26!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1438842] Review Request: matrix-synapse - a Matrix reference homeserver written in Python using Twisted

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438842



--- Comment #12 from Jeremy Cline  ---
(In reply to Stephen from comment #11)
> This is fantastic that this is now in Fedora! Can I get clarification on
> whether it will be packaged for F25/F26?
> 
> https://admin.fedoraproject.org/pkgdb/package/rpms/matrix-synapse/ is
> showing it as approved for both of those releases but there's no apparent
> activity for those releases on
> https://apps.fedoraproject.org/packages/matrix-synapse
> 
> Thanks :)

Hi Stephen,

It's been on my to-do list to see what needs to get updated/built in F26/25 for
Synapse to be build-able, I just haven't gotten around to it yet. From what I
remember, most dependencies were built in F26 so it shouldn't be too much of a
challenge. I suspect F25 will be more troublesome, but we'll see.

I also need to package a few more dependencies before it can be updated to 0.20
so it may be a few weeks before that happens (even in rawhide).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1438842] Review Request: matrix-synapse - a Matrix reference homeserver written in Python using Twisted

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438842



--- Comment #11 from Stephen  ---
This is fantastic that this is now in Fedora! Can I get clarification on
whether it will be packaged for F25/F26?

https://admin.fedoraproject.org/pkgdb/package/rpms/matrix-synapse/ is showing
it as approved for both of those releases but there's no apparent activity for
those releases on https://apps.fedoraproject.org/packages/matrix-synapse

Thanks :)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1438842] Review Request: matrix-synapse - a Matrix reference homeserver written in Python using Twisted

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438842



--- Comment #10 from Gwyn Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/matrix-synapse

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1438842] Review Request: matrix-synapse - a Matrix reference homeserver written in Python using Twisted

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438842

Randy Barlow  changed:

   What|Removed |Added

  Flags||fedora-review+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1438842] Review Request: matrix-synapse - a Matrix reference homeserver written in Python using Twisted

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438842

Randy Barlow  changed:

   What|Removed |Added

 Attachment|0   |1
#1279342 is||
   obsolete||



--- Comment #9 from Randy Barlow  ---
Created attachment 1284232
  --> https://bugzilla.redhat.com/attachment.cgi?id=1284232=edit
review.txt

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1438842] Review Request: matrix-synapse - a Matrix reference homeserver written in Python using Twisted

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438842

Jeremy Cline  changed:

   What|Removed |Added

  Flags|needinfo?(jer...@jcline.org |
   |)   |



--- Comment #8 from Jeremy Cline  ---
Okay, fixed the _sharedstatedir macro. I decided to uniformly use "homeserver"
since that's what upstream uses.

Scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=19785375

SRPM URL: https://jcline.fedorapeople.org/matrix-synapse-0.19.3-4.fc27.src.rpm
Spec URL: https://jcline.fedorapeople.org/matrix-synapse.spec

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1438842] Review Request: matrix-synapse - a Matrix reference homeserver written in Python using Twisted

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438842



--- Comment #7 from Sayan Chowdhury  ---
(In reply to Randy Barlow from comment #6)
> One more thing needs to be fixed for approval:
> 
> The macro used for /var/lib is still incorrect. It is currently
> %{_localstatedir}/lib, when it should be %{_sharedstatedir}.
+1

> 
> Optional: The summary section still uses "homeserver" instead of "home
> server".
matrix uses the term "homeserver" instead of "home server".

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1438842] Review Request: matrix-synapse - a Matrix reference homeserver written in Python using Twisted

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438842



--- Comment #6 from Randy Barlow  ---
One more thing needs to be fixed for approval:

The macro used for /var/lib is still incorrect. It is currently
%{_localstatedir}/lib, when it should be %{_sharedstatedir}.

Optional: The summary section still uses "homeserver" instead of "home server".

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1438842] Review Request: matrix-synapse - a Matrix reference homeserver written in Python using Twisted

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438842



--- Comment #5 from Jeremy Cline  ---
Thanks, I believe I covered everything except updating to the latest version
since it introduces new dependencies that I need to package before upgrading.

Scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=19629006

SRPM URL: https://jcline.fedorapeople.org/matrix-synapse-0.19.3-3.fc27.src.rpm
Spec URL: https://jcline.fedorapeople.org/matrix-synapse.spec

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1438842] Review Request: matrix-synapse - a Matrix reference homeserver written in Python using Twisted

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438842

Randy Barlow  changed:

   What|Removed |Added

 CC||jer...@jcline.org
  Flags||needinfo?(jer...@jcline.org
   ||)



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1438842] Review Request: matrix-synapse - a Matrix reference homeserver written in Python using Twisted

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438842



--- Comment #4 from Randy Barlow  ---
Created attachment 1279342
  --> https://bugzilla.redhat.com/attachment.cgi?id=1279342=edit
review_0.txt

There are a few things to fix. In addition to the !'s, there are a few rpmlint
things that would be easy to fix:

* s/homeserver/home server/
* Capitalize the summary.
* s/codebase/code base/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1438842] Review Request: matrix-synapse - a Matrix reference homeserver written in Python using Twisted

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438842

Igor Gnatenko  changed:

   What|Removed |Added

   Assignee|ignate...@redhat.com|ra...@electronsweatshop.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1438842] Review Request: matrix-synapse - a Matrix reference homeserver written in Python using Twisted

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438842



--- Comment #3 from Randy Barlow  ---
Igor, are you still planning to review this package? I'm willing to review it,
but I don't want to step on your toes ☺

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1438842] Review Request: matrix-synapse - a Matrix reference homeserver written in Python using Twisted

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438842

Sayan Chowdhury  changed:

   What|Removed |Added

 CC||sayanchowdhury@fedoraprojec
   ||t.org



--- Comment #2 from Sayan Chowdhury  ---
This is an informal review. Can we fix the rpmlint errors?

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Apache (v2.0)", "*No copyright* Apache (v2.0)", "Unknown or
 generated", "*No copyright* Apache (v2)". 171 files have unknown
 license. Detailed output of licensecheck in /tmp/1438842-matrix-
 synapse/licensecheck.txt
[x]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/lib/systemd/system,
 /usr/lib/systemd
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 133120 bytes in 6 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: %config files are marked noreplace or the reason is justified.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: No %config files under /usr.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[?]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[!]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
 

[Bug 1438842] Review Request: matrix-synapse - a Matrix reference homeserver written in Python using Twisted

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438842



--- Comment #1 from Jeremy Cline  ---
Updated to remove the python-pysaml2 < 4.0.0 requirement since there's already
a python-pysaml2 >= 3.0.0 requirement.

SRPM URL: https://jcline.fedorapeople.org/matrix-synapse-0.19.3-2.fc27.src.rpm
Spec URL: https://jcline.fedorapeople.org/matrix-synapse.spec

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1438842] Review Request: matrix-synapse - a Matrix reference homeserver written in Python using Twisted

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438842

Igor Gnatenko  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|ignate...@redhat.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org