[Bug 1440992] Review Request: python-booleanoperations - Boolean operations on paths

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1440992

Athos Ribeiro  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |NEXTRELEASE
Last Closed||2018-02-21 07:46:17



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1440992] Review Request: python-booleanoperations - Boolean operations on paths

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1440992



--- Comment #13 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/python-booleanoperations

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1440992] Review Request: python-booleanoperations - Boolean operations on paths

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1440992

Peter Oliver  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #12 from Peter Oliver  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[!]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[?]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 20480 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
 Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
 python2-booleanoperations , python3-booleanoperations
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[?]: Package should compile and build into binary rpms on all supported
 architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
 files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} 

[Bug 1440992] Review Request: python-booleanoperations - Boolean operations on paths

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1440992

Peter Oliver  changed:

   What|Removed |Added

 Blocks|182235 (FE-Legal)   |
   Assignee|quantum.anal...@gmail.com   |ma...@mavit.org.uk
  Flags||fedora-review?



--- Comment #11 from Peter Oliver  ---
Upstream have confirmed that "based on" here means "uses as a library", so
nothing to worry about.


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=182235
[Bug 182235] Fedora Legal Tracker
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1440992] Review Request: python-booleanoperations - Boolean operations on paths

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1440992

Athos Ribeiro  changed:

   What|Removed |Added

 Blocks||182235 (FE-Legal)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=182235
[Bug 182235] Fedora Legal Tracker
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1440992] Review Request: python-booleanoperations - Boolean operations on paths

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1440992



--- Comment #10 from Athos Ribeiro  ---
(In reply to Peter Oliver from comment #9)
> I notice that
> https://github.com/typemytype/booleanOperations/blob/master/README.rst
> states:
> 
> > Boolean operations on paths based on a super fast polygon clipper library 
> > by Angus Johnson
> 
> However, this Clipper library is released under the Boost Software License,
> not the MIT licence which BooleanOperations claims.  The Boost Software
> License require that this licence is preserved in derivatives.
> 
> I have raised https://github.com/typemytype/booleanOperations/issues/47
> upstream, asking them to clarify the situation.

BooleanOperations is not a derivative work of pyclipper. It is not a derivative
of the clipper library as well and pyclipper itself is not a derivative work of
the clipper library.

- pyclipper is a set of python bindings for the clipper library (this is not a
derivative, it just uses the library).

- BooleanOperations is a python package that uses (imports) pyclipper, which
does not mean it is a derivative as well.

Derivative works would be modifications on top of the software in question.

Just to be sure, I am rasing Fedora legal flag.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1440992] Review Request: python-booleanoperations - Boolean operations on paths

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1440992

Peter Oliver  changed:

   What|Removed |Added

 CC||ma...@mavit.org.uk



--- Comment #9 from Peter Oliver  ---
I notice that
https://github.com/typemytype/booleanOperations/blob/master/README.rst states:

> Boolean operations on paths based on a super fast polygon clipper library by 
> Angus Johnson

However, this Clipper library is released under the Boost Software License, not
the MIT licence which BooleanOperations claims.  The Boost Software License
require that this licence is preserved in derivatives.

I have raised https://github.com/typemytype/booleanOperations/issues/47
upstream, asking them to clarify the situation.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1440992] Review Request: python-booleanoperations - Boolean operations on paths

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1440992

Itamar Reis Peixoto  changed:

   What|Removed |Added

 CC||ita...@ispbrasil.com.br



--- Comment #8 from Itamar Reis Peixoto  ---
consider using the macro %{python3_pkgversion} even if you don't have plans to
build for epel right now

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1440992] Review Request: python-booleanoperations - Boolean operations on paths

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1440992



--- Comment #7 from Athos Ribeiro  ---
Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=25103198

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1440992] Review Request: python-booleanoperations - Boolean operations on paths

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1440992



--- Comment #6 from Athos Ribeiro  ---
No more blockers on the way, so I am updating the package so we can go on with
the review:

Spec URL:
https://athoscr.fedorapeople.org/packaging/python-booleanoperations.spec
SRPM URL:
https://athoscr.fedorapeople.org/packaging/python-booleanoperations-0.8.0-1.fc27.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1440992] Review Request: python-booleanoperations - Boolean operations on paths

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1440992
Bug 1440992 depends on bug 1440971, which changed state.

Bug 1440971 Summary: Review Request: python-pyclipper  - Cython wrapper for the 
C++ translation of the Angus Johnson's Clipper library
https://bugzilla.redhat.com/show_bug.cgi?id=1440971

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1440992] Review Request: python-booleanoperations - Boolean operations on paths

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1440992



--- Comment #5 from Athos Ribeiro  ---
Yes. As per BZ#1440971, polyclipping is embedded in one of the dependencies. We
need should help upstream updating the bindings to the latest polyclipping
library. Help doing that is much appreciated.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1440992] Review Request: python-booleanoperations - Boolean operations on paths

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1440992



--- Comment #4 from Shawn Starr  ---
Any help here to move the review though process?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1440992] Review Request: python-booleanoperations - Boolean operations on paths

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1440992
Bug 1440992 depends on bug 1440968, which changed state.

Bug 1440968 Summary: Review Request: python-setuptools_scm_git_archive - A 
setuptools_scm plugin that adds support for git archives
https://bugzilla.redhat.com/show_bug.cgi?id=1440968

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1440992] Review Request: python-booleanoperations - Boolean operations on paths

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1440992

Athos Ribeiro  changed:

   What|Removed |Added

Summary|Review Request: |Review Request:
   |python-booleanOperations -  |python-booleanoperations -
   |Boolean operations on paths |Boolean operations on paths



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1440992] Review Request: python-booleanOperations - Boolean operations on paths

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1440992



--- Comment #3 from Athos Ribeiro  ---
Changed the package name and updated version

Spec URL:
https://athoscr.fedorapeople.org/packaging/python-booleanoperations.spec
SRPM URL:
https://athoscr.fedorapeople.org/packaging/python-booleanoperations-0.7.1-1.fc26.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1440992] Review Request: python-booleanOperations - Boolean operations on paths

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1440992

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||zbys...@in.waw.pl
   Assignee|nob...@fedoraproject.org|quantum.anal...@gmail.com



--- Comment #2 from Zbigniew Jędrzejewski-Szmek  ---
If you keep the camelCased name, please add %python_provide with the lowercased
names too (python2-booleanoperations and python3-booleanoperations).

QuLogic, I assigned the review to you because it seems you have already done
most of the work for this one. If you don't want to take it, assign it back to
me.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1440992] Review Request: python-booleanOperations - Boolean operations on paths

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1440992

Elliott Sales de Andrade  changed:

   What|Removed |Added

 CC||quantum.anal...@gmail.com



--- Comment #1 from Elliott Sales de Andrade  ---
This is not a formal review. I did not have any chance to test this out,
but the tests pass. Fedora tends not to use upper case in its package names,
though without a delimiter between the words, changing it might not be a good 
choice.



Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "MIT/X11 (BSD like)", "Unknown or generated". 15 files have
 unknown license. Detailed output of licensecheck in
 1440992-python-booleanOperations/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[?]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/lib/python3.6/site-
 packages, /usr/lib/python3.6
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[?]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[?]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 20480 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
 Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
 python2-booleanOperations , python3-booleanOperations
[?]: 

[Bug 1440992] Review Request: python-booleanOperations - Boolean operations on paths

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1440992

Elliott Sales de Andrade  changed:

   What|Removed |Added

 Depends On||1440971




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1440971
[Bug 1440971] Review Request: python-pyclipper  - Cython wrapper for the
C++ translation of the Angus Johnson's Clipper library
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1440992] Review Request: python-booleanOperations - Boolean operations on paths

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1440992

Athos Ribeiro  changed:

   What|Removed |Added

 Blocks||1441023




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1441023
[Bug 1441023] Review Request: python-fontmake - Compile fonts from sources
to binary
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1440992] Review Request: python-booleanOperations - Boolean operations on paths

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1440992

Athos Ribeiro  changed:

   What|Removed |Added

 Depends On||1440968




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1440968
[Bug 1440968] Review Request: python-setuptools_scm_git_archive - A
setuptools_scm plugin that adds support for git archives
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org