[Bug 1462466] Review Request: jp2a - Converts jpg images to ASCII
https://bugzilla.redhat.com/show_bug.cgi?id=1462466 --- Comment #22 from Fedora Update System --- jp2a-1.0.7-1.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1462466] Review Request: jp2a - Converts jpg images to ASCII
https://bugzilla.redhat.com/show_bug.cgi?id=1462466 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed|2017-08-14 16:44:16 |2017-09-02 18:24:39 --- Comment #21 from Fedora Update System --- jp2a-1.0.7-1.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1462466] Review Request: jp2a - Converts jpg images to ASCII
https://bugzilla.redhat.com/show_bug.cgi?id=1462466 --- Comment #20 from Fedora Update System --- jp2a-1.0.7-1.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-5519555fe5 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1462466] Review Request: jp2a - Converts jpg images to ASCII
https://bugzilla.redhat.com/show_bug.cgi?id=1462466 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #19 from Fedora Update System --- jp2a-1.0.7-1.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-cd32c84ca3 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1462466] Review Request: jp2a - Converts jpg images to ASCII
https://bugzilla.redhat.com/show_bug.cgi?id=1462466 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1462466] Review Request: jp2a - Converts jpg images to ASCII
https://bugzilla.redhat.com/show_bug.cgi?id=1462466 --- Comment #18 from Fedora Update System --- jp2a-1.0.7-1.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-cd32c84ca3 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1462466] Review Request: jp2a - Converts jpg images to ASCII
https://bugzilla.redhat.com/show_bug.cgi?id=1462466 --- Comment #17 from Fedora Update System --- jp2a-1.0.7-1.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-5519555fe5 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1462466] Review Request: jp2a - Converts jpg images to ASCII
https://bugzilla.redhat.com/show_bug.cgi?id=1462466 Raphael Groner changed: What|Removed |Added Status|CLOSED |ASSIGNED Resolution|RAWHIDE |--- Keywords||Reopened --- Comment #16 from Raphael Groner --- Requested branches: f27, f26, epel7. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1462466] Review Request: jp2a - Converts jpg images to ASCII
https://bugzilla.redhat.com/show_bug.cgi?id=1462466 mpr...@redhat.com changed: What|Removed |Added CC||mpr...@redhat.com --- Comment #15 from mpr...@redhat.com --- Please disregard my two comments. These were for testing. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1462466] Review Request: jp2a - Converts jpg images to ASCII
https://bugzilla.redhat.com/show_bug.cgi?id=1462466 --- Comment #13 from mpr...@redhat.com --- (fedrepo-req-admin): The Pagure repository was created at https://src.stg.fedoraproject.org/rpms/jp2a. You may create the branch "f26" using git in about 10 minutes. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1462466] Review Request: jp2a - Converts jpg images to ASCII
https://bugzilla.redhat.com/show_bug.cgi?id=1462466 --- Comment #14 from mpr...@redhat.com --- (fedrepo-req-admin): The Pagure repository was created at https://src.stg.fedoraproject.org/rpms/jp2a. You may create the branch "f26" using git in about 10 minutes. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1462466] Review Request: jp2a - Converts jpg images to ASCII
https://bugzilla.redhat.com/show_bug.cgi?id=1462466 Raphael Groner changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE Last Closed||2017-08-14 16:44:16 --- Comment #12 from Raphael Groner --- Imported and built in rawhide. As pagure does not allow me to build for other branches, I'll delay till pagure is ready. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1462466] Review Request: jp2a - Converts jpg images to ASCII
https://bugzilla.redhat.com/show_bug.cgi?id=1462466 --- Comment #11 from Raphael Groner --- (In reply to Jonny Heggheim from comment #4) > - All build dependencies are listed in BuildRequires, except for any that > are listed in the exceptions section of Packaging Guidelines. > Note: These BR are not needed: gcc > See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2 This is a bug in f-r. Exceptions were removed from guidelines to not enforce gcc. https://fedoraproject.org/wiki/Packaging:Guidelines#Compiler https://pagure.io/packaging-committee/issue/497#comment-146293 (In reply to Jonny Heggheim from comment #5) > There are some files in the no debug package in /usr/lib, not sure how they > ended up there since they are not defined in %files > > Rpmlint: > jp2a.x86_64: W: only-non-binary-in-usr-lib > jp2a.x86_64: W: hidden-file-or-dir /usr/lib/.build-id > jp2a.x86_64: W: hidden-file-or-dir /usr/lib/.build-id Bug in rpmlint. https://bugzilla.redhat.com/show_bug.cgi?id=1431408 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1462466] Review Request: jp2a - Converts jpg images to ASCII
https://bugzilla.redhat.com/show_bug.cgi?id=1462466 --- Comment #10 from Gwyn Ciesla --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/jp2a -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1462466] Review Request: jp2a - Converts jpg images to ASCII
https://bugzilla.redhat.com/show_bug.cgi?id=1462466 --- Comment #9 from Gwyn Ciesla --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/jp2a -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1462466] Review Request: jp2a - Converts jpg images to ASCII
https://bugzilla.redhat.com/show_bug.cgi?id=1462466 Raphael Groner changed: What|Removed |Added Status|NEW |POST --- Comment #8 from Raphael Groner --- Jonny, thanks for the review! I'll care about your comments while importing the package. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1462466] Review Request: jp2a - Converts jpg images to ASCII
https://bugzilla.redhat.com/show_bug.cgi?id=1462466 Jonny Heggheim changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #7 from Jonny Heggheim --- Review approved, none of the comments are must items -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1462466] Review Request: jp2a - Converts jpg images to ASCII
https://bugzilla.redhat.com/show_bug.cgi?id=1462466 --- Comment #6 from Jonny Heggheim --- I would prefer a bit more information in %description, can use the text from Debian for instance https://packages.debian.org/unstable/jp2a -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1462466] Review Request: jp2a - Converts jpg images to ASCII
https://bugzilla.redhat.com/show_bug.cgi?id=1462466 Jonny Heggheim changed: What|Removed |Added Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1462466] Review Request: jp2a - Converts jpg images to ASCII
https://bugzilla.redhat.com/show_bug.cgi?id=1462466 --- Comment #5 from Jonny Heggheim --- There are some files in the no debug package in /usr/lib, not sure how they ended up there since they are not defined in %files Rpmlint: jp2a.x86_64: W: only-non-binary-in-usr-lib jp2a.x86_64: W: hidden-file-or-dir /usr/lib/.build-id jp2a.x86_64: W: hidden-file-or-dir /usr/lib/.build-id -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1462466] Review Request: jp2a - Converts jpg images to ASCII
https://bugzilla.redhat.com/show_bug.cgi?id=1462466 --- Comment #4 from Jonny Heggheim --- - All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. Note: These BR are not needed: gcc See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1462466] Review Request: jp2a - Converts jpg images to ASCII
https://bugzilla.redhat.com/show_bug.cgi?id=1462466
--- Comment #3 from Jonny Heggheim ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
Note: These BR are not needed: gcc
See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "GPL (v2)", "Unknown or generated", "zlib/libpng curl GPL
(v2)". 46 files have unknown license. Detailed output of licensecheck
in /home/jonny/tmp/1462466-jp2a/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 30720 bytes in 6 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in jp2a-
debuginfo
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file requ
[Bug 1462466] Review Request: jp2a - Converts jpg images to ASCII
https://bugzilla.redhat.com/show_bug.cgi?id=1462466 Jonny Heggheim changed: What|Removed |Added CC||heg...@gmail.com Assignee|nob...@fedoraproject.org|heg...@gmail.com -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1462466] Review Request: jp2a - Converts jpg images to ASCII
https://bugzilla.redhat.com/show_bug.cgi?id=1462466 Raphael Groner changed: What|Removed |Added Alias||jp2a --- Comment #2 from Raphael Groner --- Task info: https://koji.fedoraproject.org/koji/taskinfo?taskID=20057135 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1462466] Review Request: jp2a - Converts jpg images to ASCII
https://bugzilla.redhat.com/show_bug.cgi?id=1462466 Raphael Groner changed: What|Removed |Added Blocks||1462467 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1462467 [Bug 1462467] Review Request: hollywood - Fill your console with Hollywood melodrama techno-babble -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1462466] Review Request: jp2a - Converts jpg images to ASCII
https://bugzilla.redhat.com/show_bug.cgi?id=1462466 Raphael Groner changed: What|Removed |Added CC||morphe...@gmail.com --- Comment #1 from Raphael Groner --- *** Bug 708664 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
