[Bug 1462472] Review Request: qotd - A simple and lightweight Quote of the Day daemon
https://bugzilla.redhat.com/show_bug.cgi?id=1462472 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed|2017-07-20 11:52:49 |2017-08-17 21:20:50 --- Comment #14 from Fedora Update System --- qotd-0.11.3-2.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1462472] Review Request: qotd - A simple and lightweight Quote of the Day daemon
https://bugzilla.redhat.com/show_bug.cgi?id=1462472 Fedora Update System changed: What|Removed |Added Status|CLOSED |ON_QA Resolution|ERRATA |--- Keywords||Reopened --- Comment #13 from Fedora Update System --- qotd-0.11.3-2.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-4084c13468 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1462472] Review Request: qotd - A simple and lightweight Quote of the Day daemon
https://bugzilla.redhat.com/show_bug.cgi?id=1462472 --- Comment #12 from Fedora Update System --- qotd-0.11.3-2.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-4084c13468 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1462472] Review Request: qotd - A simple and lightweight Quote of the Day daemon
https://bugzilla.redhat.com/show_bug.cgi?id=1462472 --- Comment #11 from Fedora Update System --- qotd-0.11.3-1.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1462472] Review Request: qotd - A simple and lightweight Quote of the Day daemon
https://bugzilla.redhat.com/show_bug.cgi?id=1462472 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2017-07-20 11:52:49 --- Comment #10 from Fedora Update System --- qotd-0.11.3-1.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1462472] Review Request: qotd - A simple and lightweight Quote of the Day daemon
https://bugzilla.redhat.com/show_bug.cgi?id=1462472 --- Comment #9 from Fedora Update System --- qotd-0.11.3-1.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-2156b74af7 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1462472] Review Request: qotd - A simple and lightweight Quote of the Day daemon
https://bugzilla.redhat.com/show_bug.cgi?id=1462472 --- Comment #8 from Fedora Update System --- qotd-0.11.3-1.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-8ae3c81d37 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1462472] Review Request: qotd - A simple and lightweight Quote of the Day daemon
https://bugzilla.redhat.com/show_bug.cgi?id=1462472 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #7 from Fedora Update System --- qotd-0.11.3-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-fa23e4d91b -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1462472] Review Request: qotd - A simple and lightweight Quote of the Day daemon
https://bugzilla.redhat.com/show_bug.cgi?id=1462472 --- Comment #6 from Fedora Update System --- qotd-0.11.3-1.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-2156b74af7 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1462472] Review Request: qotd - A simple and lightweight Quote of the Day daemon
https://bugzilla.redhat.com/show_bug.cgi?id=1462472 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1462472] Review Request: qotd - A simple and lightweight Quote of the Day daemon
https://bugzilla.redhat.com/show_bug.cgi?id=1462472 --- Comment #5 from Fedora Update System --- qotd-0.11.3-1.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-8ae3c81d37 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1462472] Review Request: qotd - A simple and lightweight Quote of the Day daemon
https://bugzilla.redhat.com/show_bug.cgi?id=1462472 --- Comment #4 from Gwyn Ciesla --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/qotd -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1462472] Review Request: qotd - A simple and lightweight Quote of the Day daemon
https://bugzilla.redhat.com/show_bug.cgi?id=1462472 Sandro Mani changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #3 from Sandro Mani --- All good, approved! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1462472] Review Request: qotd - A simple and lightweight Quote of the Day daemon
https://bugzilla.redhat.com/show_bug.cgi?id=1462472 --- Comment #2 from Ben Rosser --- Spec URL: https://tc01.fedorapeople.org/qotd/qotd.spec SRPM URL: https://tc01.fedorapeople.org/qotd/qotd-0.11.3-1.fc25.src.rpm - Update to latest upstream release. - Enable parallel build. - Change license tag to correct GPLv2+. - Add buildrequires on make. I reported the setgroups issue upstream here; it's since been fixed in one of the point releases of 0.11. https://github.com/ammongit/qotd/issues/11 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1462472] Review Request: qotd - A simple and lightweight Quote of the Day daemon
https://bugzilla.redhat.com/show_bug.cgi?id=1462472
--- Comment #1 from Sandro Mani ---
Full review below. Only some small stuff:
- BR make
- comment why parallel build is disabled, or enable (could use %make_build)
- license GPLv2+
- could update to 0.11.3
- to clarify with upstream? qotd.x86_64: E:
missing-call-to-setgroups-before-setuid /usr/bin/qotdd
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[!]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "*No copyright* GPL (v2 or later)", "GPL (v2 or later)",
"Unknown or generated". 9 files have unknown license. Detailed output
of licensecheck in /home/sandro/Desktop/1462472-qotd/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/lib/systemd/system,
/usr/lib/systemd
[?]: Package does not own files or directories owned by other packages.
[!]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[!]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 20480 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: %config files are marked noreplace or the reason is justified.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: No %config files under /usr.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[!]: Uses parallel make %{?_smp_mflags} macro.
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
[?]: Package functions as described.
[!]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and bu
[Bug 1462472] Review Request: qotd - A simple and lightweight Quote of the Day daemon
https://bugzilla.redhat.com/show_bug.cgi?id=1462472 Sandro Mani changed: What|Removed |Added Status|NEW |ASSIGNED CC||manisan...@gmail.com Assignee|nob...@fedoraproject.org|manisan...@gmail.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
