[Bug 1464778] Review Request: whichwayisup - 2D platform game with a slight rotational twist
https://bugzilla.redhat.com/show_bug.cgi?id=1464778 --- Comment #23 from Iwicki Artur --- I'm not entirely sure, but I think the GNOME Software Center simply looks at the License: tag in the RPM and makes a free/proprietary distinction based on that. I checked the tag in the package source and the value is set properly, so this seems to me like a bug in the SC. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1464778] Review Request: whichwayisup - 2D platform game with a slight rotational twist
https://bugzilla.redhat.com/show_bug.cgi?id=1464778 --- Comment #22 from rugk <7d28c...@opayq.com> --- Yet another thing: Why is it marked as "proprietary" in the software center? I think all source code is freely available. Also the German translation in the app description is missing. Can I help somewhere to translate it? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1464778] Review Request: whichwayisup - 2D platform game with a slight rotational twist
https://bugzilla.redhat.com/show_bug.cgi?id=1464778 --- Comment #21 from rugk <7d28c...@opayq.com> --- Great! Thanks for all your work! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1464778] Review Request: whichwayisup - 2D platform game with a slight rotational twist
https://bugzilla.redhat.com/show_bug.cgi?id=1464778 --- Comment #20 from Iwicki Artur --- Said metadata is present in the package - it's the .appdata.xml file. It's just that Fedora doesn't immediately rebuilt the catalog for GNOME Software - it's done periodically, every week or two weeks (IIRC). Just wait a few days. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1464778] Review Request: whichwayisup - 2D platform game with a slight rotational twist
https://bugzilla.redhat.com/show_bug.cgi?id=1464778 --- Comment #19 from rugk <7d28c...@opayq.com> --- Can we somehow get it into GNOME software? AFAIK just somemetadata is needed for this. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1464778] Review Request: whichwayisup - 2D platform game with a slight rotational twist
https://bugzilla.redhat.com/show_bug.cgi?id=1464778 --- Comment #18 from Fedora Update System --- whichwayisup-0.7.9-3.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1464778] Review Request: whichwayisup - 2D platform game with a slight rotational twist
https://bugzilla.redhat.com/show_bug.cgi?id=1464778 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2017-09-03 18:19:19 --- Comment #17 from Fedora Update System --- whichwayisup-0.7.9-3.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1464778] Review Request: whichwayisup - 2D platform game with a slight rotational twist
https://bugzilla.redhat.com/show_bug.cgi?id=1464778 --- Comment #16 from Fedora Update System --- whichwayisup-0.7.9-3.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-61c13c84db -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1464778] Review Request: whichwayisup - 2D platform game with a slight rotational twist
https://bugzilla.redhat.com/show_bug.cgi?id=1464778 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #15 from Fedora Update System --- whichwayisup-0.7.9-3.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-e705f0a2fe -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1464778] Review Request: whichwayisup - 2D platform game with a slight rotational twist
https://bugzilla.redhat.com/show_bug.cgi?id=1464778 --- Comment #14 from Fedora Update System --- whichwayisup-0.7.9-3.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-e705f0a2fe -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1464778] Review Request: whichwayisup - 2D platform game with a slight rotational twist
https://bugzilla.redhat.com/show_bug.cgi?id=1464778 --- Comment #13 from Fedora Update System --- whichwayisup-0.7.9-3.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-61c13c84db -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1464778] Review Request: whichwayisup - 2D platform game with a slight rotational twist
https://bugzilla.redhat.com/show_bug.cgi?id=1464778 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1464778] Review Request: whichwayisup - 2D platform game with a slight rotational twist
https://bugzilla.redhat.com/show_bug.cgi?id=1464778 --- Comment #12 from Gwyn Ciesla --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/whichwayisup -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1464778] Review Request: whichwayisup - 2D platform game with a slight rotational twist
https://bugzilla.redhat.com/show_bug.cgi?id=1464778 Andrea Musuruane changed: What|Removed |Added Status|NEW |ASSIGNED --- Comment #11 from Andrea Musuruane --- Thanks for the review, Wart! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1464778] Review Request: whichwayisup - 2D platform game with a slight rotational twist
https://bugzilla.redhat.com/show_bug.cgi?id=1464778
Wart changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #10 from Wart ---
Looks like all of the issues have been resolved in the above comments.
I feel that the two rpmlint warnings are safe to ignore:
* spelling error is intentional based on upstream's web page
* dangling symlink to font is unavoidable due to fedora's packaging guidelines
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated". 143 files have unknown license.
Detailed output of licensecheck in /usr/local/src/fedora/rpmbuild
/review-whichwayisup/licensecheck.txt
[x]: If the package is under multiple licenses, the licensing breakdown
must be documented in the spec.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[-]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: gtk-update-icon-cache is invoked in %postun and %posttrans if package
contains icons.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
desktop-file-validate if there is such a file.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[x]: Avoid bundling fonts in non-fonts packages.
Note: Package contains font files
[x]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[ ]: Final provides and requires are sane (see attachments).
[ ]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
justified.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architect
[Bug 1464778] Review Request: whichwayisup - 2D platform game with a slight rotational twist
https://bugzilla.redhat.com/show_bug.cgi?id=1464778 Wart changed: What|Removed |Added CC||w...@kobold.org Assignee|nob...@fedoraproject.org|w...@kobold.org Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1464778] Review Request: whichwayisup - 2D platform game with a slight rotational twist
https://bugzilla.redhat.com/show_bug.cgi?id=1464778 --- Comment #9 from Andrea Musuruane --- Spec URL: https://musuruan.fedorapeople.org/whichwayisup.spec SRPM URL: https://musuruan.fedorapeople.org/whichwayisup-0.7.9-3.fc25.src.rpm Changelog: - Added missing BR -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1464778] Review Request: whichwayisup - 2D platform game with a slight rotational twist
https://bugzilla.redhat.com/show_bug.cgi?id=1464778 rugk <7d28c...@opayq.com> changed: What|Removed |Added CC||7d28c...@opayq.com --- Comment #8 from rugk <7d28c...@opayq.com> --- "Removed Thumbs.db file (Windows Explorer thumbnail database)" Hah, you were caught (red-handed) developing/working on Windows… ;) In any case once this package is in bodhi or such a test instance, I would happily test it… -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1464778] Review Request: whichwayisup - 2D platform game with a slight rotational twist
https://bugzilla.redhat.com/show_bug.cgi?id=1464778 --- Comment #7 from Andrea Musuruane --- Thanks Neal, I totally forgot about fedorapeople.org :-/ Spec URL: https://musuruan.fedorapeople.org/whichwayisup.spec SRPM URL: https://musuruan.fedorapeople.org/whichwayisup-0.7.9-2.fc25.src.rpm Changelog: - Removed wrapper script and changed data path in launcher script - Added a patch from Debian to initialize only required pygame modules - Added AppData file - Removed Thumbs.db file (Windows Explorer thumbnail database) - Fixed macro style - Minor fixes -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1464778] Review Request: whichwayisup - 2D platform game with a slight rotational twist
https://bugzilla.redhat.com/show_bug.cgi?id=1464778 Neal Gompa changed: What|Removed |Added CC||ngomp...@gmail.com --- Comment #6 from Neal Gompa --- (In reply to Andrea Musuruane from comment #5) > > This is due to dropbox. Unluckily right now I have no other way to share > spec and SRPM files. Every Fedora contributor has access to fedorapeople space. You can use this as a distribution space for packages being reviewed: https://fedoraproject.org/wiki/Infrastructure/fedorapeople.org -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1464778] Review Request: whichwayisup - 2D platform game with a slight rotational twist
https://bugzilla.redhat.com/show_bug.cgi?id=1464778
--- Comment #5 from Andrea Musuruane ---
(In reply to Björn "besser82" Esser from comment #2)
> Some other hints on the spec-file:
>
> > URL:http://www.oletus.fi/static/whichwayisup/
> > Source0:
> > http://www.oletus.fi/static/whichwayisup/%{name}_b%{pkgversion}.zip
>
> URL should NOT end with a trailing slash '/')
Actually the reverse is true. URL should end with a trailing slash, otherwise
you'll get HTTP status 301.
> and you can shorten and
> simplify those really good using:
>
> URL:http://www.oletus.fi/static/${name}
> Source0:%{url}/%{name}_b%{pkgversion}.zip
I think this is less legible.
> > %setup -qn %{name}
> > %patch0 -p1
>
> Using the `autosetup`-macro is preferred (and support since el5) for new
> packages. It supports automatic patching and all:
>
> %autosetup -p 1
Right now there is just one patch. It was not the case when I started to write
the spec file.
Using autosetup all the patches need to have the same strip level. Therefore,
at the time, I couldn't use this macro.
> > > install -d %{buildroot}%{_bindir}
> > install -m 755 -p %{SOURCE1} %{buildroot}%{_bindir}/%{name}
>
> This applies to most of the code using `install`. You can do all of this in
> one line and mode SHOULD be set in four-digit octal (e.g. 0755 / 0644):
>
> install -Dpm 0755 %{SOURCE1} %{buildroot}%{_bindir}/%{name}
I guess this is just a matter of taste.
Moreover, 3 digits are fine to specify the file/directory permissions. From the
install man page:
-m, --mode=MODE
set permission mode (as in chmod), instead of rwxr-xr-x
And from the chmod man page:
A numeric mode is from one to four octal digits (0-7), derived by
adding up the bits with values 4, 2, and 1. Omitted digits are assumed
to be leading zeros.
Moreover the guidelines just state that "Permissions on files MUST be set
properly [...]":
https://fedoraproject.org/wiki/Packaging:Guidelines#File_Permissions
> > %{_mandir}/man6/*
>
> Should be: %{_mandir}/man6/%{name}.6*
Why? There is only one file in that directory and it found correctly:
$ rpm -ql whichwayisup | grep man
/usr/share/man/man6/whichwayisup.6.gz
Moreover, the guidelines just state that "When installing man pages, note that
they should be installed uncompressed as the build system will compress them as
needed. The compression method may change, so it is important to reference the
pages in the %files section with a pattern that takes this into account"
https://fedoraproject.org/wiki/Packaging:Guidelines#Manpages
> I'm not too happy with the wrapper script… You shouldn't install that from
> a static file as is… Instead you should auto-generate that from inside the
> spec-file (don't forget to have BR: python2-devel):
>
> %{__cat} << EOF > %{buildroot}%{_bindir}/%{name}
> #!/bin/sh
> set -e
>
> pushd %{_datadir}/%{name}
> %{__python2} -s run_game.py "$@"
> popd
> EOF
I think that having the wrapper file (and desktop file, and appdata file, etc)
as a different file improves readability a lot. Moreover, version control is
more efficient using different files.
> At last I'd recommend using rpm-defined macros instead of plain command
> invocation (my personal preference, left open to you):
>
> * %{__sed} instead of `sed`
> * %{__install} instead of `install`
> * %{__cp} instead of `cp`
> * %{__mkdir_p} instead of `mkdir -p`
> * %{__rm} instead of `rm`
> * %{__ln_s} instead of `ln -s`
This is actually deprecated.
Macro forms of system executables SHOULD NOT be used except when there is a
need to allow the location of those executables to be configurable. For
example, rm should be used in preference to %{__rm}, but %{__python} is
acceptable.
https://fedoraproject.org/wiki/Packaging:Guidelines#Macros
> ***
>
>
> Spec-file and srpm are no direct downloads:
>
> $ fedora-review -m fedora-rawhide-x86_64 -b 1464778 ;
> INFO: Processing bugzilla bug: 1464778
> INFO: Getting .spec and .srpm Urls from : 1464778
> INFO: --> SRPM url: https://svgames.pl/fedora/whichwayisup-0.7.9-1.src.rpm
> INFO: --> Spec url:
> https://www.dropbox.com/sh/46vz8vz5rmxx0ac/AADLlEEIDcFazfpKuVQJcs53a/reviews/
> whichwayisup.spec
> INFO: Using review directory:
> /home/besser82/vm_shared/fedora/review/1464778-whichwayisup
> INFO: Downloading .spec and .srpm files
> error: line 1: Unknown tag: xmlns:fb="http://ogp.me/ns/fb#"; xml:lang="en" class="maestro"
> xmlns="http://www.w3.org/1999/xhtml";>
> ERROR: "Can't parse specfile: can't parse specfile\n" (logs in
> /home/besser82/.cache/fedora-review.log)
This is due to dropbox. Unluckily right now I have no other way to share spec
and SRPM files.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraprojec
[Bug 1464778] Review Request: whichwayisup - 2D platform game with a slight rotational twist
https://bugzilla.redhat.com/show_bug.cgi?id=1464778
--- Comment #4 from Andrea Musuruane ---
(In reply to Iwicki Artur from comment #1)
> Ha, I was just finishing packaging this. If you're interested, you can take
> a look at my package here:
> https://svgames.pl/fedora/whichwayisup-0.7.9-1.src.rpm
>
> Anyway, regarding your package:
> - There's no appdata.xml file (you can borrow it from my package)
> - There are Thumbs.db files present in the built package
> - fedora-review complains about using both $RPM_BUILD_ROOT and %{buildroot}
> in the spec file
I had a look at your spec file. It has some interesting things. I'll try to
merge them in the coming days. Thank you.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1464778] Review Request: whichwayisup - 2D platform game with a slight rotational twist
https://bugzilla.redhat.com/show_bug.cgi?id=1464778
--- Comment #3 from Iwicki Artur ---
Björn, regarding macros for system executables, the packaging guidelines
actually say to avoid them:
> Macro forms of system executables SHOULD NOT be used except when there is a
> need to allow the location of those executables to be configurable. For
> example, rm should be used in preference to %{__rm}, but %{__python} is
> acceptable.
https://fedoraproject.org/wiki/Packaging:Guidelines#Macros
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1464778] Review Request: whichwayisup - 2D platform game with a slight rotational twist
https://bugzilla.redhat.com/show_bug.cgi?id=1464778
Björn "besser82" Esser changed:
What|Removed |Added
CC||besse...@fedoraproject.org
--- Comment #2 from Björn "besser82" Esser ---
Some other hints on the spec-file:
> URL:http://www.oletus.fi/static/whichwayisup/
> Source0:
> http://www.oletus.fi/static/whichwayisup/%{name}_b%{pkgversion}.zip
URL should NOT end with a trailing slash '/') and you can shorten and simplify
those really good using:
URL:http://www.oletus.fi/static/${name}
Source0:%{url}/%{name}_b%{pkgversion}.zip
> %setup -qn %{name}
> %patch0 -p1
Using the `autosetup`-macro is preferred (and support since el5) for new
packages. It supports automatic patching and all:
%autosetup -p 1
> install -d %{buildroot}%{_bindir}
> install -m 755 -p %{SOURCE1} %{buildroot}%{_bindir}/%{name}
This applies to most of the code using `install`. You can do all of this in
one line and mode SHOULD be set in four-digit octal (e.g. 0755 / 0644):
install -Dpm 0755 %{SOURCE1} %{buildroot}%{_bindir}/%{name}
> %{_mandir}/man6/*
Should be: %{_mandir}/man6/%{name}.6*
I'm not too happy with the wrapper script… You shouldn't install that from a
static file as is… Instead you should auto-generate that from inside the
spec-file (don't forget to have BR: python2-devel):
%{__cat} << EOF > %{buildroot}%{_bindir}/%{name}
#!/bin/sh
set -e
pushd %{_datadir}/%{name}
%{__python2} -s run_game.py "$@"
popd
EOF
At last I'd recommend using rpm-defined macros instead of plain command
invocation (my personal preference, left open to you):
* %{__sed} instead of `sed`
* %{__install} instead of `install`
* %{__cp} instead of `cp`
* %{__mkdir_p} instead of `mkdir -p`
* %{__rm} instead of `rm`
* %{__ln_s} instead of `ln -s`
***
Spec-file and srpm are no direct downloads:
$ fedora-review -m fedora-rawhide-x86_64 -b 1464778 ;
INFO: Processing bugzilla bug: 1464778
INFO: Getting .spec and .srpm Urls from : 1464778
INFO: --> SRPM url: https://svgames.pl/fedora/whichwayisup-0.7.9-1.src.rpm
INFO: --> Spec url:
https://www.dropbox.com/sh/46vz8vz5rmxx0ac/AADLlEEIDcFazfpKuVQJcs53a/reviews/whichwayisup.spec
INFO: Using review directory:
/home/besser82/vm_shared/fedora/review/1464778-whichwayisup
INFO: Downloading .spec and .srpm files
error: line 1: Unknown tag: http://ogp.me/ns/fb#"; xml:lang="en" class="maestro"
xmlns="http://www.w3.org/1999/xhtml";>
ERROR: "Can't parse specfile: can't parse specfile\n" (logs in
/home/besser82/.cache/fedora-review.log)
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1464778] Review Request: whichwayisup - 2D platform game with a slight rotational twist
https://bugzilla.redhat.com/show_bug.cgi?id=1464778
Iwicki Artur changed:
What|Removed |Added
CC||fed...@svgames.pl
--- Comment #1 from Iwicki Artur ---
Ha, I was just finishing packaging this. If you're interested, you can take a
look at my package here: https://svgames.pl/fedora/whichwayisup-0.7.9-1.src.rpm
Anyway, regarding your package:
- There's no appdata.xml file (you can borrow it from my package)
- There are Thumbs.db files present in the built package
- fedora-review complains about using both $RPM_BUILD_ROOT and %{buildroot} in
the spec file
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1464778] Review Request: whichwayisup - 2D platform game with a slight rotational twist
https://bugzilla.redhat.com/show_bug.cgi?id=1464778 Andrea Musuruane changed: What|Removed |Added Blocks||1364745 (FE-GAMESIG) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1364745 [Bug 1364745] Games SIG tracker bug -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
