[Bug 1465588] Review Request: xoreos-tools - Tools to help the development of xoreos

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1465588



--- Comment #12 from Fedora Update System  ---
xoreos-tools-0.0.4-2.el7 has been pushed to the Fedora EPEL 7 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1465588] Review Request: xoreos-tools - Tools to help the development of xoreos

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1465588



--- Comment #11 from Fedora Update System  ---
xoreos-tools-0.0.4-2.fc25 has been pushed to the Fedora 25 stable repository.
If problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1465588] Review Request: xoreos-tools - Tools to help the development of xoreos

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1465588

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-07-20 11:52:36



--- Comment #10 from Fedora Update System  ---
xoreos-tools-0.0.4-2.fc26 has been pushed to the Fedora 26 stable repository.
If problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1465588] Review Request: xoreos-tools - Tools to help the development of xoreos

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1465588



--- Comment #9 from Fedora Update System  ---
xoreos-tools-0.0.4-2.el7 has been pushed to the Fedora EPEL 7 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-f4ad70a91d

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1465588] Review Request: xoreos-tools - Tools to help the development of xoreos

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1465588



--- Comment #8 from Fedora Update System  ---
xoreos-tools-0.0.4-2.fc26 has been pushed to the Fedora 26 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-d5a8491e46

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1465588] Review Request: xoreos-tools - Tools to help the development of xoreos

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1465588

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #7 from Fedora Update System  ---
xoreos-tools-0.0.4-2.fc25 has been pushed to the Fedora 25 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-ce142c9640

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1465588] Review Request: xoreos-tools - Tools to help the development of xoreos

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1465588



--- Comment #6 from Fedora Update System  ---
xoreos-tools-0.0.4-2.el7 has been submitted as an update to Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-f4ad70a91d

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1465588] Review Request: xoreos-tools - Tools to help the development of xoreos

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1465588

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1465588] Review Request: xoreos-tools - Tools to help the development of xoreos

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1465588



--- Comment #5 from Fedora Update System  ---
xoreos-tools-0.0.4-2.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-d5a8491e46

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1465588] Review Request: xoreos-tools - Tools to help the development of xoreos

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1465588



--- Comment #4 from Gwyn Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/xoreos-tools

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1465588] Review Request: xoreos-tools - Tools to help the development of xoreos

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1465588

Sandro Mani  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #3 from Sandro Mani  ---
> It's not actually empty; it contains the new debuginfo build-id stuff that 
> seems to be a consequence of this F27 change: > 
> https://fedoraproject.org/wiki/Changes/ParallelInstallableDebuginfo. (that 
> sadly rpmlint doesn't seem to know about yet). In other words, I don't think 
> it's a problem with this package. But I could be wrong.

Ah yes, correct. All good then, approved!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1465588] Review Request: xoreos-tools - Tools to help the development of xoreos

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1465588



--- Comment #2 from Ben Rosser  ---
- Remove spurious rm -rf of the buildroot from install section.
- Switch to make build/install macros.

Spec URL: https://tc01.fedorapeople.org/xoreos/xoreos-tools.spec
SRPM URL:
https://tc01.fedorapeople.org/xoreos/xoreos-tools-0.0.4-2.fc25.src.rpm

> - empty /usr/lib in xoreos-tools-0.0.4-1.fc27.x86_64.rpm 

It's not actually empty; it contains the new debuginfo build-id stuff that
seems to be a consequence of this F27 change:
https://fedoraproject.org/wiki/Changes/ParallelInstallableDebuginfo. (that
sadly rpmlint doesn't seem to know about yet). In other words, I don't think
it's a problem with this package. But I could be wrong.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1465588] Review Request: xoreos-tools - Tools to help the development of xoreos

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1465588



--- Comment #1 from Sandro Mani  ---
Full review below, just some trivial stuff:
- could use %make_build, %make_install
- not needed: rm -rf %{buildroot}
- empty /usr/lib in xoreos-tools-0.0.4-1.fc27.x86_64.rpm 


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[?]: Package does not own files or directories owned by other packages.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
 Note: rm -rf %{buildroot} present but not required
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 30720 bytes in 8 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
 architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
 files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
 $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Uses parallel make %{?_smp_mflags} 

[Bug 1465588] Review Request: xoreos-tools - Tools to help the development of xoreos

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1465588

Sandro Mani  changed:

   What|Removed |Added

   Docs Contact|manisan...@gmail.com|
   Assignee|nob...@fedoraproject.org|manisan...@gmail.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1465588] Review Request: xoreos-tools - Tools to help the development of xoreos

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1465588

Sandro Mani  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||manisan...@gmail.com
   Docs Contact||manisan...@gmail.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1465588] Review Request: xoreos-tools - Tools to help the development of xoreos

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1465588

Ben Rosser  changed:

   What|Removed |Added

 Blocks||1364745 (FE-GAMESIG)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1364745
[Bug 1364745] Games SIG tracker bug
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org