[Bug 1467129] Review Request: python-pdir2 - Pretty dir() printing with joy

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1467129

Carl George  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |NEXTRELEASE
Last Closed||2017-07-06 17:50:47



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1467129] Review Request: python-pdir2 - Pretty dir() printing with joy

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1467129



--- Comment #9 from Gwyn Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/python-pdir2

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1467129] Review Request: python-pdir2 - Pretty dir() printing with joy

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1467129



--- Comment #8 from Carl George  ---
I actually was not aware of that, thank you for letting me know.  I also found
the supporting documentation that explains it in greater detail.

http://rpm.org/user_doc/macros.html#using-a-macro

I'll delete the braces on those macros in the final SRPM I import.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1467129] Review Request: python-pdir2 - Pretty dir() printing with joy

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1467129

Neal Gompa  changed:

   What|Removed |Added

 Depends On|177841 (FE-NEEDSPONSOR) |



--- Comment #7 from Neal Gompa  ---
I have sponsored in carlwgeorge.


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1467129] Review Request: python-pdir2 - Pretty dir() printing with joy

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1467129

Neal Gompa  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #6 from Neal Gompa  ---
Review notes:

[x] Follows general Fedora packaging guidelines
[x] Package is named appropriately per Python packaging guidelines
[x] License is marked correctly, and license file is included as %license file

Looks good to me. There's only one thing...

SHOULD FIX (on import):

[!] %{py2_build} -> %py2_build. For the sake of clarity, command macros should
not be wrapped in braces. Especially when they actually *can* accept
parameters.



Otherwise, package approved!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1467129] Review Request: python-pdir2 - Pretty dir() printing with joy

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1467129



--- Comment #5 from Carl George  ---
Upstream released 0.2.1, which lets me drop two patches.

Spec URL: https://carl.george.computer/review/python-pdir2.spec
SRPM URL: https://carl.george.computer/review/python-pdir2-0.2.1-1.fc27.src.rpm
Scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=20335807

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1467129] Review Request: python-pdir2 - Pretty dir() printing with joy

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1467129



--- Comment #4 from Carl George  ---
FYI, I'm aware of the policy on multiple FAS accounts.  Once my new carlwgeorge
id is sponsored, I'll add it to all my current packages and mark the old
carlgeorge id as inactive.

https://fedoraproject.org/wiki/Account_System#Voluntary

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1467129] Review Request: python-pdir2 - Pretty dir() printing with joy

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1467129



--- Comment #3 from Neal Gompa  ---
I will sponsor this packager upon full review of the package.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1467129] Review Request: python-pdir2 - Pretty dir() printing with joy

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1467129

Neal Gompa  changed:

   What|Removed |Added

 Depends On||177841 (FE-NEEDSPONSOR)



--- Comment #2 from Neal Gompa  ---
This packager needs sponsorship, though it is a new version of "carlgeorge"
account.


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1467129] Review Request: python-pdir2 - Pretty dir() printing with joy

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1467129

Neal Gompa  changed:

   What|Removed |Added

 CC||ngomp...@gmail.com
   Assignee|nob...@fedoraproject.org|ngomp...@gmail.com
  Flags||fedora-review?



--- Comment #1 from Neal Gompa  ---
Taking this review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org