[Bug 1468830] Review Request: abbayedesmorts-gpl - Platform game set in 13th century
https://bugzilla.redhat.com/show_bug.cgi?id=1468830 --- Comment #19 from Fedora Update System--- abbayedesmorts-gpl-2.0.1-3.20170709git.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1468830] Review Request: abbayedesmorts-gpl - Platform game set in 13th century
https://bugzilla.redhat.com/show_bug.cgi?id=1468830 Fedora Update Systemchanged: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2017-07-24 15:21:39 --- Comment #18 from Fedora Update System --- abbayedesmorts-gpl-2.0.1-3.20170709git.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1468830] Review Request: abbayedesmorts-gpl - Platform game set in 13th century
https://bugzilla.redhat.com/show_bug.cgi?id=1468830 --- Comment #17 from Fedora Update System--- abbayedesmorts-gpl-2.0.1-3.20170709git.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-d26259dbf8 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1468830] Review Request: abbayedesmorts-gpl - Platform game set in 13th century
https://bugzilla.redhat.com/show_bug.cgi?id=1468830 Fedora Update Systemchanged: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #16 from Fedora Update System --- abbayedesmorts-gpl-2.0.1-3.20170709git.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-f93c14f76b -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1468830] Review Request: abbayedesmorts-gpl - Platform game set in 13th century
https://bugzilla.redhat.com/show_bug.cgi?id=1468830 Fedora Update Systemchanged: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1468830] Review Request: abbayedesmorts-gpl - Platform game set in 13th century
https://bugzilla.redhat.com/show_bug.cgi?id=1468830 --- Comment #15 from Fedora Update System--- abbayedesmorts-gpl-2.0.1-3.20170709git.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-d26259dbf8 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1468830] Review Request: abbayedesmorts-gpl - Platform game set in 13th century
https://bugzilla.redhat.com/show_bug.cgi?id=1468830 --- Comment #14 from Gwyn Ciesla--- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/abbayedesmorts-gpl -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1468830] Review Request: abbayedesmorts-gpl - Platform game set in 13th century
https://bugzilla.redhat.com/show_bug.cgi?id=1468830 Antonio Trandechanged: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #13 from Antonio Trande --- Package approved. Package Review == Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed = MUST items = C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "*No copyright* GPL (v3)", "Unknown or generated". 60 files have unknown license. Detailed output of licensecheck in /home/sagitter/1468830-abbayedesmorts-gpl/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [-]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 235520 bytes in 10 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local = SHOULD items = Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in abbayedesmorts-gpl-debuginfo [x]: Package functions as described. [x]: Latest version is packaged. [x]:
[Bug 1468830] Review Request: abbayedesmorts-gpl - Platform game set in 13th century
https://bugzilla.redhat.com/show_bug.cgi?id=1468830 --- Comment #12 from Andrea Musuruane--- Spec URL: https://musuruan.fedorapeople.org/abbayedesmorts-gpl.spec SRPM URL: https://musuruan.fedorapeople.org/abbayedesmorts-gpl-2.0.1-3.20170709git.fc25.src.rpm Changelog: - Fixed AppData file - Fixed LDFLAGS usage -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1468830] Review Request: abbayedesmorts-gpl - Platform game set in 13th century
https://bugzilla.redhat.com/show_bug.cgi?id=1468830 --- Comment #11 from Andrea Musuruane--- (In reply to Iwicki Artur from comment #10) > (In reply to Antonio Trande from comment #9) > > It's a specific request for games: > > https://fedoraproject.org/wiki/SIGs/Games/Packaging > Oh, I haven't seen that before. Actually, now that I read it, I probably > have to fix one of my packages. Thanks! Actually the Games Packaging Guidelines should be amended. They were written a long before the Group tag was dropped. Games Packaging Guidelines must not conflict with Fedora Packaging Guidelines. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1468830] Review Request: abbayedesmorts-gpl - Platform game set in 13th century
https://bugzilla.redhat.com/show_bug.cgi?id=1468830 --- Comment #10 from Iwicki Artur--- (In reply to Antonio Trande from comment #9) > It's a specific request for games: > https://fedoraproject.org/wiki/SIGs/Games/Packaging Oh, I haven't seen that before. Actually, now that I read it, I probably have to fix one of my packages. Thanks! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1468830] Review Request: abbayedesmorts-gpl - Platform game set in 13th century
https://bugzilla.redhat.com/show_bug.cgi?id=1468830 --- Comment #9 from Antonio Trande--- (In reply to Iwicki Artur from comment #8) > (In reply to Antonio Trande from comment #7) > > > - Spec file group: 'Group: Amusements/Games' missing > The packaging guidelines say the Group: tag should not be used. > https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections It's a specific request for games: https://fedoraproject.org/wiki/SIGs/Games/Packaging -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1468830] Review Request: abbayedesmorts-gpl - Platform game set in 13th century
https://bugzilla.redhat.com/show_bug.cgi?id=1468830 --- Comment #8 from Iwicki Artur--- (In reply to Antonio Trande from comment #7) > - Spec file group: 'Group: Amusements/Games' missing The packaging guidelines say the Group: tag should not be used. https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1468830] Review Request: abbayedesmorts-gpl - Platform game set in 13th century
https://bugzilla.redhat.com/show_bug.cgi?id=1468830 --- Comment #7 from Antonio Trande--- - Linker flags are not honored (see '$ rpm --eval %__global_ldflags') - Spec file group: 'Group: Amusements/Games' missing - tags do not provide licenses like that in the SPEC file. Package Review == Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed = MUST items = C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "*No copyright* GPL (v3)", "Unknown or generated". 60 files have unknown license. Detailed output of licensecheck in /home/sagitter/1468830-abbayedesmorts-gpl/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [-]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [!]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 235520 bytes in 10 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local = SHOULD items = Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in abbayedesmorts-gpl-debuginfo [ ]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]:
[Bug 1468830] Review Request: abbayedesmorts-gpl - Platform game set in 13th century
https://bugzilla.redhat.com/show_bug.cgi?id=1468830 --- Comment #6 from Andrea Musuruane--- Spec URL: https://musuruan.fedorapeople.org/abbayedesmorts-gpl.spec SRPM URL: https://musuruan.fedorapeople.org/abbayedesmorts-gpl-2.0.1-2.20170709git.fc25.src.rpm Changelog: - Updated to new upstream post-release - Added missing BR -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1468830] Review Request: abbayedesmorts-gpl - Platform game set in 13th century
https://bugzilla.redhat.com/show_bug.cgi?id=1468830 --- Comment #5 from Andrea Musuruane--- (In reply to Antonio Trande from comment #4) > > > > (In reply to Antonio Trande from comment #2) > > > Please, clarify what license is used for this software and include a > > > related > > > license file. > > > > License is GPLv3 as stated here: > > https://github.com/nevat/abbayedesmorts-gpl > > > > I'm not allowed to include a license file if upstream does not ship it: > > "If the source package does not include the text of the license(s), the > > packager should contact upstream and encourage them to correct this mistake. > > " > > https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text > > Continuing to read: > > > However, in situations where upstream is unresponsive, unable, or > > unwilling... I still have to open a bug upstream. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1468830] Review Request: abbayedesmorts-gpl - Platform game set in 13th century
https://bugzilla.redhat.com/show_bug.cgi?id=1468830 --- Comment #4 from Antonio Trande--- > > (In reply to Antonio Trande from comment #2) > > Please, clarify what license is used for this software and include a related > > license file. > > License is GPLv3 as stated here: > https://github.com/nevat/abbayedesmorts-gpl > > I'm not allowed to include a license file if upstream does not ship it: > "If the source package does not include the text of the license(s), the > packager should contact upstream and encourage them to correct this mistake. > " > https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text Continuing to read: > However, in situations where upstream is unresponsive, unable, or unwilling... -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1468830] Review Request: abbayedesmorts-gpl - Platform game set in 13th century
https://bugzilla.redhat.com/show_bug.cgi?id=1468830 --- Comment #3 from Andrea Musuruane--- (In reply to Iwicki Artur from comment #1) > >desktop-file-validate %{buildroot}%{_datadir}/applications/abbaye.desktop > >appstream-util validate-relax --nonet > >%{buildroot}/%{_datadir}/appdata/abbaye.appdata.xml > Needs "desktop-file-utils" and "libappstream-glib" as part of BuildRequires. Good catch. > Does this use the original game's assets? Those are under CC-BY-3.0 (which > is fine). AFAIK yes. (In reply to Antonio Trande from comment #2) > Please, clarify what license is used for this software and include a related > license file. License is GPLv3 as stated here: https://github.com/nevat/abbayedesmorts-gpl I'm not allowed to include a license file if upstream does not ship it: "If the source package does not include the text of the license(s), the packager should contact upstream and encourage them to correct this mistake. " https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1468830] Review Request: abbayedesmorts-gpl - Platform game set in 13th century
https://bugzilla.redhat.com/show_bug.cgi?id=1468830 --- Comment #2 from Antonio Trande--- Please, clarify what license is used for this software and include a related license file. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1468830] Review Request: abbayedesmorts-gpl - Platform game set in 13th century
https://bugzilla.redhat.com/show_bug.cgi?id=1468830 Antonio Trandechanged: What|Removed |Added Status|NEW |ASSIGNED CC||anto.tra...@gmail.com Assignee|nob...@fedoraproject.org|anto.tra...@gmail.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1468830] Review Request: abbayedesmorts-gpl - Platform game set in 13th century
https://bugzilla.redhat.com/show_bug.cgi?id=1468830 Iwicki Arturchanged: What|Removed |Added CC||fed...@svgames.pl --- Comment #1 from Iwicki Artur --- >desktop-file-validate %{buildroot}%{_datadir}/applications/abbaye.desktop >appstream-util validate-relax --nonet >%{buildroot}/%{_datadir}/appdata/abbaye.appdata.xml Needs "desktop-file-utils" and "libappstream-glib" as part of BuildRequires. Does this use the original game's assets? Those are under CC-BY-3.0 (which is fine). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1468830] Review Request: abbayedesmorts-gpl - Platform game set in 13th century
https://bugzilla.redhat.com/show_bug.cgi?id=1468830 Andrea Musuruanechanged: What|Removed |Added Blocks||1364745 (FE-GAMESIG) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1364745 [Bug 1364745] Games SIG tracker bug -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org