[Bug 1470436] Review Request: astrometry - Blind astrometric calibration of arbitrary astronomical images

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1470436

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed|2017-09-20 15:50:23 |2017-09-30 02:25:29



--- Comment #18 from Fedora Update System  ---
astrometry-0.72-2.fc27, astrometry-tycho2-1.1.1-1.fc27 has been pushed to the
Fedora 27 stable repository. If problems still persist, please make note of it
in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1470436] Review Request: astrometry - Blind astrometric calibration of arbitrary astronomical images

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1470436

Fedora Update System  changed:

   What|Removed |Added

 Status|CLOSED  |ON_QA
 Resolution|ERRATA  |---
   Keywords||Reopened



--- Comment #17 from Fedora Update System  ---
astrometry-0.72-2.fc27, astrometry-tycho2-1.1.1-1.fc27 has been pushed to the
Fedora 27 testing repository. If problems still persist, please make note of it
in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-37cbeee31d

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1470436] Review Request: astrometry - Blind astrometric calibration of arbitrary astronomical images

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1470436



--- Comment #16 from Fedora Update System  ---
astrometry-0.72-2.fc27 astrometry-tycho2-1.1.1-1.fc27 has been submitted as an
update to Fedora 27.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-37cbeee31d

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1470436] Review Request: astrometry - Blind astrometric calibration of arbitrary astronomical images

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1470436



--- Comment #15 from Fedora Update System  ---
astrometry-0.72-1.fc26, astrometry-tycho2-1.1.1-1.fc26 has been pushed to the
Fedora 26 stable repository. If problems still persist, please make note of it
in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1470436] Review Request: astrometry - Blind astrometric calibration of arbitrary astronomical images

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1470436

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-09-20 15:50:23



--- Comment #14 from Fedora Update System  ---
astrometry-0.72-1.fc25, astrometry-tycho2-1.1.1-1.fc25 has been pushed to the
Fedora 25 stable repository. If problems still persist, please make note of it
in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1470436] Review Request: astrometry - Blind astrometric calibration of arbitrary astronomical images

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1470436



--- Comment #13 from Fedora Update System  ---
astrometry-0.72-1.fc25, astrometry-tycho2-1.1.1-1.fc25 has been pushed to the
Fedora 25 testing repository. If problems still persist, please make note of it
in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-b241075778

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1470436] Review Request: astrometry - Blind astrometric calibration of arbitrary astronomical images

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1470436



--- Comment #12 from Fedora Update System  ---
astrometry-0.72-1.fc26, astrometry-tycho2-1.1.1-1.fc26 has been pushed to the
Fedora 26 testing repository. If problems still persist, please make note of it
in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-4be93a69b1

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1470436] Review Request: astrometry - Blind astrometric calibration of arbitrary astronomical images

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1470436

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #11 from Fedora Update System  ---
astrometry-0.72-1.fc27, astrometry-tycho2-1.1.1-1.fc27 has been pushed to the
Fedora 27 testing repository. If problems still persist, please make note of it
in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-37cbeee31d

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1470436] Review Request: astrometry - Blind astrometric calibration of arbitrary astronomical images

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1470436



--- Comment #10 from Fedora Update System  ---
astrometry-tycho2-1.1.1-1.fc27 astrometry-0.72-1.fc27 has been submitted as an
update to Fedora 27.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-37cbeee31d

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1470436] Review Request: astrometry - Blind astrometric calibration of arbitrary astronomical images

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1470436



--- Comment #9 from Fedora Update System  ---
astrometry-tycho2-1.1.1-1.fc26 astrometry-0.72-1.fc26 has been submitted as an
update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-4be93a69b1

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1470436] Review Request: astrometry - Blind astrometric calibration of arbitrary astronomical images

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1470436

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1470436] Review Request: astrometry - Blind astrometric calibration of arbitrary astronomical images

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1470436



--- Comment #8 from Fedora Update System  ---
astrometry-tycho2-1.1.1-1.fc25 astrometry-0.72-1.fc25 has been submitted as an
update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-b241075778

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1470436] Review Request: astrometry - Blind astrometric calibration of arbitrary astronomical images

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1470436



--- Comment #7 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/astrometry

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1470436] Review Request: astrometry - Blind astrometric calibration of arbitrary astronomical images

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1470436



--- Comment #6 from Christian Dersch  ---
Thank you very much!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1470436] Review Request: astrometry - Blind astrometric calibration of arbitrary astronomical images

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1470436

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |POST
 CC||zebo...@gmail.com
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review+



--- Comment #5 from Robert-André Mauchin  ---
Everything seems good, package accepted.


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
 Note: Unversioned so-files in private %_libdir subdirectory (see
 attachment). Verify they are not in ld path.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "GPL", "GPL (v2 or later)", "GPL (v3 or later)", "Unknown or
 generated", "*No copyright* GPL", "Public domain GPL (v2 or later)",
 "GPL (v3 or later) (with incorrect FSF address)", "zlib/libpng", "BSD
 (3 clause)", "GPL (v3)", "GPL (v2)". 751 files have unknown license.
 Detailed output of licensecheck in
 /home/bob/packaging/review/astrometry/review-
 astrometry/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: If the package is under multiple licenses, the licensing breakdown
 must be documented in the spec.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: %config files are marked noreplace or the reason is justified.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: No %config files under /usr.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec 

[Bug 1470436] Review Request: astrometry - Blind astrometric calibration of arbitrary astronomical images

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1470436

Mattia Verga  changed:

   What|Removed |Added

 CC||mattia.ve...@email.it



--- Comment #4 from Mattia Verga  ---
Thanks for your effort in continuing the process of importing astrometry.net
into Fedora.

I have no free time at the moment to follow a full review, but here are my 2
cents:
- I think would be better asking upstream to rename the conflicting executable
and also some other executables that have too common name and can become a
problem in future. Renaming the executable only here in Fedora can cause
confusion and I think this should be the last chance.
- Patches should be reported upstream
https://fedoraproject.org/wiki/Packaging:Guidelines#Patch_Guidelines and the
fact we are not the only distro using them should make the developer more open
to accept them upstream.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1470436] Review Request: astrometry - Blind astrometric calibration of arbitrary astronomical images

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1470436

Christian Dersch  changed:

   What|Removed |Added

  Alias||review-astrometry



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1470436] Review Request: astrometry - Blind astrometric calibration of arbitrary astronomical images

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1470436

Christian Dersch  changed:

   What|Removed |Added

 Blocks||1470470
   ||(review-astrometry-tycho2)
 Depends On|1470470 |
   |(review-astrometry-tycho2)  |




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1470470
[Bug 1470470] Review Request: astrometry-tycho2 - Tycho-2 catalogue for
astrometry.net
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1470436] Review Request: astrometry - Blind astrometric calibration of arbitrary astronomical images

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1470436

Christian Dersch  changed:

   What|Removed |Added

 Depends On||1470470




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1470470
[Bug 1470470] Review Request: astrometry-tycho2 - Tycho-2 catalogue for
astrometry.net
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1470436] Review Request: astrometry - Blind astrometric calibration of arbitrary astronomical images

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1470436



--- Comment #3 from Christian Dersch  ---
Note that fedora-review will complain about the should item "[!]: Uses parallel
make %{?_smp_mflags} macro." The handwritten Makefile from upstream does not
support parallel build very well and we get build issues then.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1470436] Review Request: astrometry - Blind astrometric calibration of arbitrary astronomical images

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1470436

Christian Dersch  changed:

   What|Removed |Added

 Whiteboard|NotReady|



--- Comment #2 from Christian Dersch  ---
Licensing checked and updated, ready now.

Koji scratch build (rawhide):
https://koji.fedoraproject.org/koji/taskinfo?taskID=20484428

As a reference: Debian package where patches were taken from:
https://packages.debian.org/source/sid/astrometry.net

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1470436] Review Request: astrometry - Blind astrometric calibration of arbitrary astronomical images

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1470436



--- Comment #1 from Christian Dersch  ---
NotReady means: Have to check the licensing in detail as there is also some GPL
code.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1470436] Review Request: astrometry - Blind astrometric calibration of arbitrary astronomical images

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1470436

Christian Dersch  changed:

   What|Removed |Added

 Blocks||115 (Astronomy-SIG)
 Whiteboard||NotReady




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=115
[Bug 115] Astronomy SIG - review tracker
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1470436] Review Request: astrometry - Blind astrometric calibration of arbitrary astronomical images

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1470436

Christian Dersch  changed:

   What|Removed |Added

   See Also||https://bugzilla.redhat.com
   ||/show_bug.cgi?id=1299139



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org