[Bug 1470678] Review Request: perl-Data-Dmp - Dump Perl data structures as Perl code

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1470678

Jitka Plesnikova  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
   Fixed In Version||perl-Data-Dmp-0.23-1.fc27
 Resolution|--- |RAWHIDE
Last Closed||2017-08-01 09:04:52



--- Comment #3 from Jitka Plesnikova  ---
Thank you for the review and the repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1470678] Review Request: perl-Data-Dmp - Dump Perl data structures as Perl code

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1470678



--- Comment #2 from Gwyn Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/perl-Data-Dmp

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1470678] Review Request: perl-Data-Dmp - Dump Perl data structures as Perl code

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1470678

Petr Pisar  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #1 from Petr Pisar  ---
URL and Source0 addresses are Ok.
Source0 archive (SHA-256:
f2b326d703fb845d9dffd3b8b46d6c5d461143ac8f0f3c94d555ed294f0daf21) is original.
Ok.
Summary verified from lib/Data/Dmp.pm. Ok.

TODO: Remove the space in `compact , starts' in the description.

License verified from lib/Data/Dmp.pm and LICENSE. Ok.
No XS code, noarch BuildArch is Ok.

FIX: Build-require `perl(blib)' for tests (t/00-compile.t:19).

Test::Pod, Test::Pod::Coverage, and Pod::Coverage::TrustPod are not used. Ok.
All tests pass. Ok.

$ rpmlint perl-Data-Dmp.spec ../SRPMS/perl-Data-Dmp-0.23-1.fc27.src.rpm
../RPMS/noarch/perl-Data-Dmp-0.23-1.fc27.noarch.rpm 
perl-Data-Dmp.src: W: spelling-error %description -l en_US Stringify -> Stringy
perl-Data-Dmp.src: W: spelling-error %description -l en_US regexes -> regexps,
regex's, reg exes
perl-Data-Dmp.src: W: spelling-error %description -l en_US coderefs -> code
refs, code-refs, recorders
perl-Data-Dmp.noarch: W: spelling-error %description -l en_US Stringify ->
Stringy
perl-Data-Dmp.noarch: W: spelling-error %description -l en_US regexes ->
regexps, regex's, reg exes
perl-Data-Dmp.noarch: W: spelling-error %description -l en_US coderefs -> code
refs, code-refs, recorders
2 packages and 1 specfiles checked; 0 errors, 6 warnings.
rpmlint is Ok.

$ rpm -q -lv -p ../RPMS/noarch/perl-Data-Dmp-0.23-1.fc27.noarch.rpm
drwxr-xr-x2 rootroot0 Aug  1 08:20
/usr/share/doc/perl-Data-Dmp
-rw-r--r--1 rootroot 2742 Jan 30  2017
/usr/share/doc/perl-Data-Dmp/Changes
-rw-r--r--1 rootroot 5076 Jan 30  2017
/usr/share/doc/perl-Data-Dmp/README
drwxr-xr-x2 rootroot0 Aug  1 08:20
/usr/share/doc/perl-Data-Dmp/devscripts
-rw-r--r--1 rootroot 1127 Aug  1 08:20
/usr/share/doc/perl-Data-Dmp/devscripts/bench
drwxr-xr-x2 rootroot0 Aug  1 08:20
/usr/share/licenses/perl-Data-Dmp
-rw-r--r--1 rootroot18367 Jan 30  2017
/usr/share/licenses/perl-Data-Dmp/LICENSE
-rw-r--r--1 rootroot 4287 Aug  1 08:20
/usr/share/man/man3/Data::Dmp.3pm.gz
drwxr-xr-x2 rootroot0 Aug  1 08:20
/usr/share/perl5/vendor_perl/Data
-rw-r--r--1 rootroot11944 Jan 30  2017
/usr/share/perl5/vendor_perl/Data/Dmp.pm
File layout and permissions are Ok.

$ rpm -q --requires -p ../RPMS/noarch/perl-Data-Dmp-0.23-1.fc27.noarch.rpm |
sort -f | uniq -c
  1 perl(:MODULE_COMPAT_5.26.0)
  1 perl(:VERSION) >= 5.10.1
  1 perl(B::Deparse)
  1 perl(Exporter)
  1 perl(Regexp::Stringify)
  1 perl(Scalar::Util)
  1 perl(strict)
  1 perl(warnings)
  1 rpmlib(CompressedFileNames) <= 3.0.4-1
  1 rpmlib(FileDigests) <= 4.6.0-1
  1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
  1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -q --provides -p ../RPMS/noarch/perl-Data-Dmp-0.23-1.fc27.noarch.rpm |
sort -f | uniq -c
  1 perl(Data::Dmp) = 0.23
  1 perl-Data-Dmp = 0.23-1.fc27
Binary provides are Ok.

$ resolvedeps f27-build ../RPMS/noarch/perl-Data-Dmp-0.23-1.fc27.noarch.rpm 
Binary dependencies resolvable. Ok.

Package builds in F27
(https://koji.fedoraproject.org/koji/taskinfo?taskID=20938874). Ok.

Otherwise the package is in line with Fedora and Perl packaging guidelines.

Please correct the `FIX' item and consider fixing the `TODO' item before
building this package.
Resolution: Package APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1470678] Review Request: perl-Data-Dmp - Dump Perl data structures as Perl code

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1470678

Petr Pisar  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||ppi...@redhat.com
   Assignee|nob...@fedoraproject.org|ppi...@redhat.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1470678] Review Request: perl-Data-Dmp - Dump Perl data structures as Perl code

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1470678
Bug 1470678 depends on bug 1470656, which changed state.

Bug 1470656 Summary: Review Request: perl-Regexp-Stringify - Stringify a Regexp 
object
https://bugzilla.redhat.com/show_bug.cgi?id=1470656

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1470678] Review Request: perl-Data-Dmp - Dump Perl data structures as Perl code

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1470678

Jitka Plesnikova  changed:

   What|Removed |Added

 Blocks||1470705




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1470705
[Bug 1470705] Review Request: perl-Log-ger - Lightweight, flexible logging
framework
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1470678] Review Request: perl-Data-Dmp - Dump Perl data structures as Perl code

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1470678

Jitka Plesnikova  changed:

   What|Removed |Added

 Depends On||1470656




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1470656
[Bug 1470656] Review Request: perl-Regexp-Stringify - Stringify a Regexp
object
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org