[Bug 1472824] package review: rubygem-jekyll-redirect-from

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1472824

Didik Supriadi  changed:

   What|Removed |Added

 Whiteboard||AwaitingSubmitter
 CC||didiksupriad...@gmail.com




-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure

[Bug 1472824] package review: rubygem-jekyll-redirect-from

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1472824

Didik Supriadi  changed:

   What|Removed |Added

 Whiteboard|AwaitingSubmitter   |NotReady



--- Comment #5 from Didik Supriadi  ---
SPEC and SRPM's urls are expired


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure

needinfo canceled: [Bug 1472824] package review: rubygem-jekyll-redirect-from

[bugzilla]

Product: Fedora
Version: rawhide
Component: Package Review

Package Review  has canceled Package
Review 's request for Robert-André
Mauchin  's needinfo:
Bug 1472824: package review: rubygem-jekyll-redirect-from
https://bugzilla.redhat.com/show_bug.cgi?id=1472824



--- Comment #4 from Package Review  ---
This is an automatic action taken by review-stats script.

The ticket reviewer failed to clear the NEEDINFO flag in a month.
As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews
we reset the status and the assignee of this ticket.
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1472824] package review: rubygem-jekyll-redirect-from

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1472824

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||zebo...@gmail.com
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review?



--- Comment #2 from Robert-André Mauchin  ---
Hello,

 - Version: is 0.11.0 but version in %changelog (and upstream) is 0.12.1. Did
you forget to update the tag?

 - The Group: tag is not used in Fedora. See
https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections

 - You didn't fill the %changelog entry with your name and email.

* Tue Jul 04 2017 John Heidemann  - 0.12.1-1

 - The %check section is currently not testing anything, missing "rspec spec/"
?

   For this, some dependencies are missing, I remember reviewing jekyll-sitemap
so I already have a rpm laying around. It is not yet in Rawhide because it
depend on the jekyll update. Rubocop has a review request but it doesn't seem
mandatory.
   However the jekyll-sitemap packaged is a 1.x version, and the compatibility
with such version is only available on a recent GIT snapshot:
https://github.com/jekyll/jekyll-redirect-from/commit/55b91b3748f53679697225e07a62688baf9a917c

   Thus I suggest you to package the latest development snapshot:

   First:

%global commit  bc5ab9bd672e005f59ae6beabe8cbce5c77e0cdc
%global shortcommit %(c=%{commit}; echo ${c:0:7})
%global commitdate  20170731


  Then:

Release: 0.1.%{commitdate}git%{shortcommit}%{?dist}

  With the following source:

# git clone https://github.com/jekyll/jekyll-redirect-from/
# cd jekyll-redirect-from; gem build jekyll-redirect-from.gemspec
Source0: %{gem_name}-%{version}.gem


  And the corresponding changelog entry:

* Tue Sep 12 2017 John Heidemann  -
0.12.1-0.1.20170731gitbc5ab9b


Of course, it will depend on the jekyll update going through (bug #1470699)
then the sitemap package being imported (bug #1470702).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1472824] package review: rubygem-jekyll-redirect-from

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1472824



--- Comment #1 from John Heidemann  ---
Related tickets: #1470699 (update to rubygem-jekyll)
#1470702 (another jekyll extension)
#1310368 (my prior request for jekyll including this module, fortunately
overtaken by someone else's packaging fo it)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org